VinPropane
f5ff0b8dc3
NEO-85: Drop dead emission props on unshaded dummy highlight.
...
Bugbot: emission_* on SHADING_MODE_UNSHADED materials has no visible effect
without glow; lock highlight is albedo-only. Add GdUnit coverage for albedo
brightening without emission.
2026-05-25 13:42:33 -04:00
VinPropane
2316303ad7
NEO-85: gdformat position authority client test signal asserts.
...
Pre-push gdformat --check failed on long await assert_signal lines.
2026-05-25 13:35:45 -04:00
VinPropane
9c8e8c2109
NEO-85: Wrap craft feedback signal assert for gdlint line length.
...
Pre-push gdlint rejects the long await assert_signal line added in the
GdUnit signal-assertion fix.
2026-05-25 13:34:19 -04:00
VinPropane
b90fedf7a8
NEO-85: Fix flaky GdUnit signal assertions in full suite runs.
...
Await async assert_signal calls and match emitted payload args with any()
where tests only care that the signal fired, preventing orphaned 2s timeouts
that surfaced as false failures in later suites (e.g. hotbar_loadout_client_test).
2026-05-25 13:32:51 -04:00
VinPropane
bf9fd84b1c
NEO-85: Apply gdformat to client scripts and tests.
2026-05-25 13:26:22 -04:00
VinPropane
4d32d068dc
NEO-85: Fix gdlint max line length in combat HP label render.
2026-05-25 13:26:09 -04:00
VinPropane
79b8a68364
NEO-85: Make combat dummies visible with labels and lock highlight.
...
Replace subtle mast markers with capsule bodies, Dummy α/β Label3D names,
and brighten the Tab-locked target; HUD hints point to orange/purple dummies.
2026-05-25 13:23:13 -04:00
VinPropane
c8f6884ea0
NEO-85: Track GdUnit test script uid companions.
2026-05-25 13:22:17 -04:00
VinPropane
35ff76b532
NEO-85: Auto-bind pulse to slot 0 and show cast HUD errors.
...
Fresh hotbar starts empty so digit 1 was a silent no-op; bootstrap
prototype_pulse on first sync and surface empty-slot/send failures on CastFeedbackLabel.
2026-05-25 13:22:06 -04:00
VinPropane
504d3228dd
NEO-85: Address code review doc sync and 404 test gap.
...
Update module dependency register and E5.M1 related-slices entry for
NEO-85 landed; add combat-targets HTTP 404 GdUnit case; strike review suggestions.
2026-05-25 13:17:47 -04:00
VinPropane
7466f2bcba
NEO-85: Add code review for client combat HUD.
2026-05-25 13:16:56 -04:00
VinPropane
faf3fe1139
NEO-85: Add manual QA, README, and module doc reconciliation.
...
Mark E5M1-11 acceptance complete in backlog and alignment register.
2026-05-25 13:15:59 -04:00
VinPropane
493e963a28
NEO-85: Wire client combat feedback and target HP HUD.
...
Parse combatResolution on cast accept, add combat-targets GET client,
CombatTargetHpLabel, and event-driven HP refresh on lock change and cast.
2026-05-25 13:15:59 -04:00
VinPropane
f03e689ce9
NEO-85: Add kickoff implementation plan for client combat HUD.
...
Documents event-driven combat-target refresh, CastFeedbackLabel resolution
copy, and dedicated CombatTargetHpLabel per kickoff clarifications.
2026-05-25 13:13:53 -04:00
VinPropane
b65bff2a36
Merge pull request #119 from ViPro-Technologies/NEO-84-combat-telemetry-hooks
...
NEO-84: Slice 1 combat telemetry hook sites
2026-05-25 13:11:54 -04:00
VinPropane
3cbbcb6c2f
NEO-84: Address code review — register sync and hook comment parity.
...
Append NEO-44/NEO-84 to E5.M1 dependency register note, fix E2.M2 NEO-44
status, and add playerId correlation hint on damage-path ability_used hook.
2026-05-25 13:06:04 -04:00
VinPropane
e61ee333ee
NEO-84: Add code review for combat telemetry hook sites.
2026-05-25 13:05:08 -04:00
VinPropane
667a1a960a
NEO-84: Add combat telemetry hook sites in CombatOperations.
...
Comment-only ability_used, enemy_defeat, and reserved encounter_start/player_death
markers; README and module docs updated. All 407 server tests pass.
2026-05-25 13:04:11 -04:00
VinPropane
fb2bfe5614
NEO-84: Add kickoff implementation plan for combat telemetry hooks.
...
Documents engine-only comment hook sites in CombatOperations per kickoff clarifications.
2026-05-25 12:45:32 -04:00
VinPropane
a216219aab
Merge pull request #118 from ViPro-Technologies/NEO-44-gig-xp-combat-defeat
...
NEO-44: Grant gig XP on combat defeat (E5M1-10)
2026-05-25 12:27:49 -04:00
VinPropane
adc34e0a9f
NEO-44: Fix Bruno collection ordering and interaction pre-request
...
Remove gig-progression folder seq so defeat spine runs after ability-cast;
run defeat spine at seq 31. Gather until node_depleted in interaction test
so craft spine pollution does not break the depleted-node deny case.
2026-05-25 12:20:30 -04:00
VinPropane
32fbcec766
NEO-44: Fix Bruno defeat spine for CI collection order.
...
Reset prototype target HP before cast chain, use slot 2 to avoid
cooldown pollution, and assert +25 gig XP delta from baseline.
2026-05-25 12:14:29 -04:00
VinPropane
9d9b53332f
NEO-44: Address code review — docs, debug log, Bruno playerId.
...
Update E5.M1/E2.M2 module docs for gig XP path; LogDebug on failed
gig store write; Bruno defeat spine uses {{playerId}}; strike review items.
2026-05-25 12:08:21 -04:00
VinPropane
1e06b7174d
NEO-44: Add code review for gig XP on combat defeat.
2026-05-25 12:06:46 -04:00
VinPropane
71a6761f3c
NEO-44: Grant gig XP on combat defeat via dedicated store.
...
Add IPlayerGigProgressionStore (in-memory + Postgres V007), GET
/gig-progression snapshot, and CombatDefeatGigXpGrant on cast accept
when targetDefeated — 25 XP to breach, outside E2.M2 skill XP.
Includes tests, Bruno, README, manual QA, and plan reconciliation.
2026-05-25 12:04:40 -04:00
VinPropane
30d379c98c
NEO-44: Add kickoff implementation plan for gig XP on combat defeat.
...
Documents E5M1-10 scope: breach main gig, 25 XP per targetDefeated,
GET gig-progression snapshot, Postgres+in-memory store, and cast hook
after NEO-82 combat resolution — outside E2.M2 skill XP.
2026-05-25 12:01:48 -04:00
VinPropane
25876a16fd
Merge pull request #117 from ViPro-Technologies/NEO-83-combat-targets-snapshot
...
NEO-83: GET /game/world/combat-targets HP snapshot
2026-05-25 11:38:25 -04:00
VinPropane
7d325eec4c
NEO-83: Use slot 1 in Bruno defeat spine to avoid seq 2 cooldown.
...
Combat-targets fixture resets HP only; seq 2 leaves slot 0 on cooldown so the four-pulse spine follows NEO-82 and binds slot 1.
2026-05-25 11:31:02 -04:00
VinPropane
ea13b05196
NEO-83: Fix Bruno CI combat-targets HP state pollution.
...
Add dev combat-targets fixture reset endpoint, Bruno pre-request helper, and enable fixture in CI Bruno step so combat-targets tests run after ability-cast defeat spine.
2026-05-25 11:28:13 -04:00
VinPropane
24eb355a26
NEO-83: Reconcile plan with code review Bruno follow-up.
...
Document one-pulse cast→GET smoke request and review-driven handler/test changes.
2026-05-25 11:23:41 -04:00
VinPropane
50a2c9ca9d
NEO-83: Address code review follow-ups for combat-targets GET.
...
Fail fast on health store TryGet miss, tighten one-pulse integration test assertions, add fast Bruno cast→GET smoke, update review doc.
2026-05-25 11:23:32 -04:00
VinPropane
aafa5e472a
NEO-83: Add code review for combat-targets GET snapshot.
2026-05-25 11:22:13 -04:00
VinPropane
52b1d4d206
NEO-83: Add GET /game/world/combat-targets HP snapshot.
...
Wire CombatTargetsWorldApi backed by ICombatEntityHealthStore, Bruno happy + cast defeat spine, integration tests, README and module tracking docs.
2026-05-25 11:20:13 -04:00
VinPropane
902e03848c
NEO-83: Add implementation plan for combat-targets GET snapshot.
...
Kickoff clarifications recorded; server-only scope with Bruno and API test coverage for authoritative HP reads.
2026-05-25 11:18:41 -04:00
VinPropane
157564e810
Merge pull request #116 from ViPro-Technologies/NEO-82-wire-ability-cast-combat-resolution
...
NEO-82: Wire ability-cast into combat engine + cast response
2026-05-25 11:13:22 -04:00
VinPropane
3e0d370677
NEO-82: Use slot 1 in Bruno defeat spine to avoid cooldown clash.
...
Happy cast (seq 22) leaves slot 0 cooling; defeat spine pre-request casts
were denied with on_cooldown. Slot 1 + pre-request fail-fast on bad cast.
2026-05-25 11:07:59 -04:00
VinPropane
71d93ee1fd
NEO-82: Note Bugbot fix in code review follow-up.
2026-05-25 11:05:02 -04:00
VinPropane
52bf9fc4bf
NEO-82: Fix cast definition lookup order and Bruno target isolation.
...
Load ability definition before TryResolve so cooldown lookup cannot deny
after HP mutation (Bugbot). Happy Bruno cast uses beta; defeat spine keeps
alpha; bump spine seq and cooldown sleep margin for CI.
2026-05-25 11:04:55 -04:00
VinPropane
322798b2ef
NEO-82: Address code review doc sync and test AAA follow-ups.
...
Update E5.M1 module doc, dependency register, and alignment table for
NEO-82 landed; Bruno defeat spine HP stepping; refactor four-pulse cast
test Arrange/Act/Assert; strike through resolved review items.
2026-05-25 10:45:31 -04:00
VinPropane
0b40ae3598
NEO-82: Add code review for cast combat wiring.
2026-05-25 10:44:02 -04:00
VinPropane
e8be100f80
NEO-82: Wire cast POST into combat engine and cast response.
...
Invoke CombatOperations.TryResolve after E1 gates; nested combatResolution
on accept; per-ability catalog cooldown; target_defeated deny without
cooldown. Tests, Bruno defeat spine, README and module docs updated.
2026-05-25 10:36:42 -04:00
VinPropane
4126ac9bcc
NEO-82: Add implementation plan for cast combat wiring.
...
Kickoff clarifications: nested combatResolution on accept, per-ability
cooldown on successful resolve only, no manual QA doc (server-only).
2026-05-25 10:32:33 -04:00
VinPropane
b8d87bbb54
Merge pull request #115 from ViPro-Technologies/NEO-81-combat-operations-try-resolve
...
NEO-81: CombatOperations.TryResolve + CombatResult
2026-05-25 10:28:52 -04:00
VinPropane
c7aa75ebc5
NEO-81: Address code review doc sync and test follow-ups.
...
Update module tracking and E5M1 backlog for NEO-81 landed; tighten AAA
in four-pulse test, add guard/dash deny parity and dash smoke test.
2026-05-25 10:20:09 -04:00
VinPropane
d63e448a08
NEO-81: Add code review for CombatOperations.TryResolve.
2026-05-25 10:18:28 -04:00
VinPropane
ca15e7a689
NEO-81: Add CombatOperations.TryResolve and CombatResult.
...
Pure server combat resolution applies catalog damage via the health store,
denies re-hits on defeated targets, and validates unknown ability/target ids.
2026-05-25 10:16:24 -04:00
VinPropane
849c34f460
NEO-81: Add implementation plan for CombatOperations.TryResolve.
2026-05-25 10:14:53 -04:00
VinPropane
dda0dadf56
Merge pull request #114 from ViPro-Technologies/NEO-80-combat-entity-health-store
...
NEO-80: Combat entity health store for prototype dummies
2026-05-24 22:49:42 -04:00
VinPropane
bfb0eb9306
NEO-80: Address code review follow-ups for health store.
2026-05-24 22:42:33 -04:00
VinPropane
c3df7fc8d0
NEO-80: Add code review for combat entity health store.
2026-05-24 22:40:26 -04:00
VinPropane