VinPropane
d4388e25aa
NEO-142: rename shadowed name variable in quest defs tests
...
Avoid SHADOWED_VARIABLE_BASE_CLASS warnings against Node.name.
2026-06-17 21:24:30 -04:00
VinPropane
3a509d560e
chore: silence IDE0301 and redundant await linter warnings
...
Use static empty bundle grant lists in RewardRouterOperations; drop
redundant await on synchronous GdUnit assert_signal in quest defs test.
2026-06-17 21:19:27 -04:00
VinPropane
ee918c5412
NEO-142: reconcile docs and close out code review findings
...
Check off AC in plan/backlog; update E7.M3 module + alignment register;
strike through addressed review suggestions and nits.
2026-06-17 21:16:17 -04:00
VinPropane
00590d5944
NEO-142: review follow-up — static faction display names + gate rules tests
...
Use FactionStandingClient.display_name_for directly; add GdUnit coverage for
faction_gate_rules_for helper.
2026-06-17 21:16:17 -04:00
VinPropane
187ecc9c0d
NEO-142: add code review for faction standing HUD branch
2026-06-17 21:14:49 -04:00
VinPropane
e39622893b
chore: use collection expressions for empty grant fallbacks
...
Replace Array.Empty<T>() with [] in RewardRouterOperations (IDE0301).
2026-06-17 21:13:29 -04:00
VinPropane
f8a36213a1
NEO-142: clear GDScript linter warnings in faction HUD work
...
Hoist quest progress label lines binding; drop redundant await on synchronous
GdUnit assert_signal calls.
2026-06-17 21:12:54 -04:00
VinPropane
be7878a199
NEO-142: fix GdUnit HTTPClient method enum in faction tests
...
Use METHOD_GET default params matching existing client test mocks; auto_free
progress client stub to avoid orphan exit code.
2026-06-17 21:11:27 -04:00
VinPropane
84bd46635d
NEO-142: document faction HUD and manual QA checklist
...
Add client README section, NEO-142 manual QA steps, and plan reconciliation.
2026-06-17 21:10:36 -04:00
VinPropane
c8c706f839
NEO-142: add faction standing client and HUD wiring
...
Introduce faction-standing GET client, standing label in HudRoot, readable
faction_gate_blocked accept feedback, reputationGrants reward lines, and GdUnit tests.
2026-06-17 21:10:34 -04:00
VinPropane
fb9a8ab8b2
NEO-142: add E7M3-10 client faction HUD implementation plan
...
Kickoff plan for Godot faction standing label, gate deny feedback, and
reputationGrants reward lines after NEO-139/140 server APIs landed.
2026-06-17 21:08:56 -04:00
VinPropane
b4d48f6e36
NEO-141: remove server-only manual QA doc after story end
...
Comment-only infrastructure story — acceptance fully covered by dotnet
test; align with NEO-140 and planning-implementation-docs skip rule.
2026-06-17 19:36:33 -04:00
VinPropane
e102a6b539
Merge pull request #181 from ViPro-Technologies/NEO-141-faction-telemetry-hooks
...
NEO-141: E7M3-09 faction telemetry hook sites (comment-only)
2026-06-17 19:34:12 -04:00
VinPropane
0a4450a199
NEO-141: address review — backlog wording and class summary
...
Align E7M3-09 in-scope bullet with ops-only hook anchors; pluralize
FactionGateOperations telemetry remark; mark review findings done.
2026-06-17 19:27:27 -04:00
VinPropane
cbd8444da3
NEO-141: add code review for faction telemetry hook sites
2026-06-17 19:26:54 -04:00
VinPropane
3c1ade4185
NEO-141: add manual QA and reconcile module docs
...
Update E7M3 backlog, alignment register, and implementation plan
for landed faction telemetry hook sites.
2026-06-17 19:25:27 -04:00
VinPropane
73403622f2
NEO-141: consolidate faction telemetry hook comment sites
...
Complete reputation_delta anchor in ReputationOperations, extend
faction_gate_blocked on both gate deny paths, remove router duplicate
stub, and add README Faction telemetry hooks subsection.
2026-06-17 19:25:25 -04:00
VinPropane
5ab81215ad
NEO-141: add faction telemetry hook sites implementation plan
...
Kickoff plan for E7M3-09 — consolidate comment-only reputation_delta
and faction_gate_blocked anchors from NEO-136/137/138 per NEO-121/130 pattern.
2026-06-17 19:23:25 -04:00
VinPropane
ef75111b2a
NEO-140: remove server-only manual QA doc after story end
...
Manual QA checklists are for client-facing stories; Bruno and dotnet
test cover this HTTP projection slice.
2026-06-17 19:21:48 -04:00
VinPropane
960b4900d0
Merge pull request #180 from ViPro-Technologies/NEO-140-e7m3-quest-http-rep-gate-projections
...
NEO-140: Extend quest HTTP projections for rep + gates (E7M3-08)
2026-06-17 19:19:15 -04:00
VinPropane
7011a56755
NEO-140: address code review — grid-contract rep and wire-level gate test
...
Add integration coverage for +10 Rust Collective reputationGrants,
JsonDocument omission test for factionGateRules, extend accept Bruno,
fix manual QA link, strike through review findings.
2026-06-17 19:12:33 -04:00
VinPropane
3ba2fd100c
NEO-140: add code review for quest HTTP rep + gate projections
2026-06-17 19:11:03 -04:00
VinPropane
1dedc5fc99
NEO-140: reconcile plan, manual QA, and E7.M3 module alignment
...
Mark acceptance criteria done; document Bruno/curl verification checklist.
2026-06-17 19:08:38 -04:00
VinPropane
2b4a0d1e34
NEO-140: project faction gates and rep grants on quest HTTP GETs
...
World quest-definitions expose optional factionGateRules; quest-progress
completionRewardSummary maps GrantedReputation to reputationGrants.
2026-06-17 19:08:37 -04:00
VinPropane
367f894b34
NEO-140: add E7M3-08 quest HTTP projection kickoff plan
...
Document factionGateRules world GET and completionRewardSummary
reputationGrants scope before implementation.
2026-06-17 19:05:54 -04:00
VinPropane
72668e1cab
Merge pull request #179 from ViPro-Technologies/NEO-139-e7m3-get-faction-standing-http-read
...
NEO-139: GET faction-standing HTTP read (E7M3-07)
2026-06-16 17:56:04 -04:00
VinPropane
7347b3b3b3
NEO-139: reset faction standing before default Bruno GET.
...
Seq 2 pre-request clears prototype faction rows so re-runs pass after operator-chain flows leave +15 standing.
2026-06-16 17:50:07 -04:00
VinPropane
329028429d
NEO-139: fix Bruno operator-chain helper require path.
...
Use ./scripts/ from collection root so developer sandbox allows the import.
2026-06-16 17:46:20 -04:00
VinPropane
0dfc17486e
NEO-139: fix Bruno default test playerId env lookup.
...
Use getEnvVar fallback so CI Local environment resolves playerId in test assertions.
2026-06-16 17:41:50 -04:00
VinPropane
0fe182565e
NEO-139: address review — trim-path tests and Bruno folder note.
...
Add whitespace-only 404 and padded-path playerId echo tests; document seq 4 standing side effect in faction-standing folder docs.
2026-06-16 17:26:40 -04:00
VinPropane
cc7786ba3a
NEO-139: add code review for faction-standing GET API.
2026-06-16 17:22:40 -04:00
VinPropane
3f08812e93
NEO-139: add GET faction-standing snapshot API with tests and Bruno.
...
Expose client-readable standing for all catalog factions; 404 unknown players via position gate; Bruno asserts +15 after operator chain.
2026-06-16 17:19:50 -04:00
VinPropane
5fc780c8ab
NEO-139: kickoff implementation plan for faction-standing GET API.
2026-06-16 17:17:42 -04:00
VinPropane
e405d43d43
Merge pull request #178 from ViPro-Technologies/NEO-138-e7m3-reward-router-reputation-grants
...
NEO-138: Extend reward router for reputationGrants
2026-06-15 23:16:54 -04:00
VinPropane
6999eb3303
NEO-138: clear delivery and audit on quest fixture reset.
...
resetQuestIds now clears IRewardDeliveryStore rows and quest-completion
audit deltas so Bruno re-runs re-apply rep grants after standing reset.
2026-06-15 23:10:58 -04:00
VinPropane
4ee29e867b
NEO-138: quest-fixture resetFactionIds for gate deny Bruno.
...
Clear prototype faction standing in seq 10 pre-request so stale +15 from
prior seq 11 runs does not pass the grid contract gate locally.
2026-06-15 23:00:21 -04:00
VinPropane
2581677dd5
NEO-138: reset grid contract in faction gate deny Bruno.
...
Clear stale completed progress from prior seq 11 runs so accept
returns faction_gate_blocked instead of already_completed locally.
2026-06-15 22:40:38 -04:00
VinPropane
57215d401a
NEO-138: re-review confirms follow-ups addressed.
2026-06-15 22:31:29 -04:00
VinPropane
69c3ad4915
NEO-138: address code review follow-ups.
...
Fix Bruno grid-contract status expectation, add race rep rollback and
multi-row audit-failure tests, audit-row assertion, and doc comments.
2026-06-15 22:29:36 -04:00
VinPropane
245f0a84ed
NEO-138: add code review for reward router reputation grants.
2026-06-15 22:22:06 -04:00
VinPropane
3466f1ee32
NEO-138: reward router reputation grants, Bruno quest-flow, docs.
...
Apply completionRewardBundle.reputationGrants via ReputationOperations with
compensating rollback; thread faction stores through quest wiring; add operator
chain Bruno helper and grid-contract accept success; update README and E7.M3 docs.
2026-06-15 22:18:27 -04:00
VinPropane
599d87bd0d
NEO-138: Add E7M3-06 implementation plan for reputationGrants router wiring.
2026-06-15 22:03:33 -04:00
VinPropane
a70c41db5a
Merge pull request #177 from ViPro-Technologies/chore/bruno-self-reset-fixtures
...
chore: Bruno self-reset dev fixtures for order-independent collection runs
2026-06-15 21:59:36 -04:00
VinPropane
64920792ee
chore: address Bruno self-reset review — README, Postgres test, nits.
...
Document resetQuestIds, resource-node fixture, and cooldown clear in server README; add TryClearProgress Postgres integration test; sync-review doc and Bruno require paths.
2026-06-15 21:53:44 -04:00
VinPropane
95cf5d1f83
chore: add Bruno self-reset dev fixtures for order-independent collection runs.
...
Extend quest and resource-node fixture APIs so Bruno pre-requests can reset shared dev-local-1 state (cooldowns, nodes, inventory, quest progress) instead of relying on a fresh Postgres baseline.
2026-06-15 21:50:22 -04:00
VinPropane
0af21e002c
Merge pull request #176 from ViPro-Technologies/NEO-137-e7m3-faction-gate-operations-tryaccept
...
NEO-137: FactionGateOperations + wire into TryAccept
2026-06-15 21:32:48 -04:00
VinPropane
a36e7b56b5
NEO-137: Address review — quest fixture for Bruno CI and test/docs nits.
...
Add POST …/__dev/quest-fixture to mark quests completed without reward
delivery; wire Bruno pre-request and CI flag. Multi-rule AND unit test,
README notes, gate deny comment, review strikethroughs.
2026-06-15 21:24:21 -04:00
VinPropane
4ffc60f226
NEO-137: Add code review for faction gate operations branch.
2026-06-15 21:21:23 -04:00
VinPropane
0241cc31e3
NEO-137: Wire FactionGateOperations into quest accept with tests and docs.
...
Evaluate FactionGateRule rows before TryActivate; deny with faction_gate_blocked
when standing is below minStanding. Integration and Bruno deny smoke included.
2026-06-15 21:11:27 -04:00
VinPropane
1c3d075d6b
NEO-137: Add implementation plan for FactionGateOperations + TryAccept wiring.
2026-06-15 21:08:26 -04:00