VinPropane
cdf7c61ce4
NEO-32: defer review suggestion #1 (integration test AAA)
2026-04-30 22:04:11 -04:00
VinPropane
27daef70a7
NEO-32: commit Godot .uid companions; document convention for agents
2026-04-30 22:02:29 -04:00
VinPropane
7d64ed2adc
NEO-32: prune expired cooldown entries on TryGetCooldownEndUtc
2026-04-30 21:58:40 -04:00
VinPropane
7ddfb53219
NEO-32: add pre-merge code review (docs/reviews/2026-04-30-NEO-32.md)
2026-04-30 21:52:14 -04:00
VinPropane
56f7ae8a81
NEO-32: fix cooldown HUD anchor when serverTimeUtc parse fails
2026-04-30 21:45:25 -04:00
VinPropane
f4ba4cdd92
NEO-32: optional NEON_SPRAWL_API_LOG stdout for ability-cast
2026-04-30 21:37:03 -04:00
VinPropane
ae74f570dc
NEO-32: manual QA step 3 without server console logging
2026-04-30 21:33:08 -04:00
VinPropane
361a6800d2
NEO-32: cooldown snapshot API, on_cooldown deny, client HUD sync
2026-04-30 21:19:32 -04:00
VinPropane
b4b67bccfd
NEO-32: add implementation plan for cooldown snapshot sync
2026-04-30 21:13:17 -04:00
VinPropane
0790a3398d
Merge pull request #58 from ViPro-Technologies/NEO-30-cast-funnel-telemetry-hooks
...
NEO-30: Slice 3 cast funnel telemetry hook sites and docs
2026-04-30 21:09:28 -04:00
VinPropane
94cec78053
NEO-30: wrap telemetry doc comments for gdlint
2026-04-30 21:05:42 -04:00
VinPropane
8a9a9bcf78
NEO-30: address code review follow-ups
2026-04-30 21:04:31 -04:00
VinPropane
deec789af3
NEO-30: add code review for cast funnel telemetry hooks branch
2026-04-30 21:02:49 -04:00
VinPropane
b5478782a8
NEO-30: cast funnel telemetry hook sites and docs
2026-04-30 20:59:47 -04:00
VinPropane
0e95918b56
NEO-30: add implementation plan for cast funnel telemetry hooks
2026-04-30 20:53:47 -04:00
VinPropane
b91d0c8b65
Merge pull request #57 from ViPro-Technologies/NEO-28-combat-accept-deny-reason-ux
...
NEO-28: Cast accept/deny, target authority, client HUD, tests and docs
2026-04-27 22:21:27 -04:00
VinPropane
bbfa761aee
NEO-28: gdformat ability_cast_client_test.gd after connect() wrap.
2026-04-27 22:15:00 -04:00
VinPropane
0bce6ed74c
NEO-28: Wrap long lines for gdlint (ability cast + tests).
2026-04-27 22:14:47 -04:00
VinPropane
c3acbdb373
NEO-28: Add reviewability guideline; mark NEO-28 review suggestions done.
...
Document preferring separate branches/commits for mechanical test-only
churn vs ticket-scoped changes. Strike through resolved bullets in the
saved review file per project convention.
2026-04-27 22:13:11 -04:00
VinPropane
e6ccc4453c
chore: Apply Arrange/Act/Assert across server and client tests.
...
Split HTTP verification reads into Assert in C# API and integration tests.
Add # Arrange/# Act/# Assert to GdUnit suites and keep Act free of assertions
where casts and busy guards are under test.
2026-04-27 22:09:35 -04:00
VinPropane
7050bc12da
chore: AAA rules — no required blank line after phase comments
2026-04-27 21:54:02 -04:00
VinPropane
31f9b74d3f
chore: make AAA test layout mandatory in style rules and snippets
2026-04-27 21:52:39 -04:00
VinPropane
09e783a5e8
NEO-28: AAA layout for cast tests (C# + GdUnit)
2026-04-27 21:46:37 -04:00
VinPropane
7de8e7ecfd
NEO-28: cast target authority, HUD feedback, tests + docs
2026-04-27 21:03:04 -04:00
VinPropane
d379980c27
Merge pull request #56 from ViPro-Technologies/NEO-31-e1m4-02-input-to-abilitycastrequest-path
...
NEO-31: E1M4-02 hotbar input to ability cast POST
2026-04-27 20:52:03 -04:00
VinPropane
479d1e1806
NEO-31: Bruno collection metadata, cast script UIDs, review verification notes
2026-04-27 20:50:53 -04:00
VinPropane
18e55f717a
NEO-31: wrap long lines for gdlint pre-push
2026-04-27 20:49:11 -04:00
VinPropane
af1fdef816
NEO-31: single authority mirror for hotbar and ability cast clients
2026-04-27 20:45:48 -04:00
VinPropane
cc1c6f711e
NEO-31: request_cast bool for telemetry hook; document cast API in server README
2026-04-27 20:44:40 -04:00
VinPropane
e88e59f3a6
NEO-31: hotbar cast resolver tests, doc alignment, review follow-up
2026-04-27 20:42:36 -04:00
VinPropane
eac95f0c27
chore: group Bruno hotbar-loadout and ability-cast under subfolders
2026-04-27 20:27:53 -04:00
VinPropane
b34f7365b8
chore: make C# AAA test layout visible in AGENTS and review checklist
2026-04-27 20:24:20 -04:00
VinPropane
7c327994eb
NEO-31: structure AbilityCastApiTests in explicit AAA sections
2026-04-27 20:23:02 -04:00
VinPropane
b5b8c10d36
chore: add Godot UIDs for hotbar_loadout_client and hotbar_state
2026-04-27 20:22:23 -04:00
VinPropane
7e97eb4c1d
NEO-31: ability cast POST, client hotbar keys, tests, Bruno
2026-04-27 20:17:57 -04:00
VinPropane
e0e9f90329
NEO-31: plan Bruno requests for ability-cast API parity
2026-04-27 20:14:29 -04:00
VinPropane
e9fcf46b02
NEO-31: add E1M4-02 implementation plan (cast request path kickoff)
2026-04-27 20:13:10 -04:00
VinPropane
41a284a24e
Merge pull request #55 from ViPro-Technologies/NEO-29-manual-qa-client-checks
...
NEO-29: add client-driven manual QA checks
2026-04-26 00:04:38 -04:00
VinPropane
cb95876f73
NEO-29: expand manual QA with client-driven checks
...
Add explicit client-side validation steps to the NEO-29 manual QA checklist and include the generated Godot uid file created during client test runs.
2026-04-26 00:03:33 -04:00
VinPropane
1f43d7e26d
Merge pull request #54 from ViPro-Technologies/NEO-29-hotbarloadout-v1-contract-baseline-persistence-path
...
NEO-29: add hotbar loadout v1 contract and hydration path
2026-04-25 23:53:54 -04:00
VinPropane
1900a6fb69
NEO-29: require pulling main before branching
...
Add an explicit git-workflow rule to fetch and pull main before creating new story branches, preventing stale-base branch creation.
2026-04-25 23:51:32 -04:00
VinPropane
ed032e8bb5
Merge remote-tracking branch 'origin/main' into NEO-29-hotbarloadout-v1-contract-baseline-persistence-path
2026-04-25 23:51:20 -04:00
VinPropane
2d131671c2
NEO-29: add explicit MCP-only GitHub rule in AGENTS
...
Add a top-level AGENTS.md section that requires user-github MCP for GitHub actions and forbids gh CLI fallback.
2026-04-25 23:44:35 -04:00
VinPropane
01b627cc8a
NEO-29: enforce MCP-only GitHub workflow in rules
...
Strengthen project guidance to require user-github MCP tools for GitHub operations and explicitly prohibit gh CLI fallback in repo-level agent rules.
2026-04-25 23:32:44 -04:00
VinPropane
23da39f7d3
NEO-29: fix main script definition order for hook lint
...
Move hotbar state/client field declarations above onready definitions for class order compliance, and include a non-behavioral test file restage so client hooks can validate.
2026-04-25 23:28:14 -04:00
VinPropane
9ac4f27ea2
NEO-29: resolve follow-up review regressions
...
Fix the hotbar client test transport body construction so the suite parses and runs again, and normalize AAA marker ordering in the flagged C# tests to restore readability consistency with the test template.
2026-04-25 23:26:25 -04:00
VinPropane
71af7a5942
NEO-29: normalize test formatting across server and client suites
...
Audit all test files and bring them in line with formatting/style expectations by adding explicit AAA markers across server test methods and fixing GDScript test lint/format issues.
2026-04-25 22:57:05 -04:00
VinPropane
3dccab8edb
NEO-29: normalize hotbar API tests to explicit AAA style
...
Add explicit Arrange/Act/Assert sections to each hotbar API test method to align with the C# test style guide while preserving existing coverage and behavior.
2026-04-25 22:52:03 -04:00
VinPropane
e6f3d63318
NEO-29: move AAA enforcement to test authoring time
...
Remove the AAA pre-commit gate and instead provide write-time scaffolding via C# snippets and a test template, then document those defaults in the C# style and testing expectations rules.
2026-04-25 22:50:03 -04:00
VinPropane
3a2fce2ce0
NEO-29: enforce AAA markers in changed C# tests
...
Extend the pre-commit guard to fail when staged server test files lack explicit Arrange/Act/Assert markers, so AAA style compliance is checked automatically instead of relying on review memory.
2026-04-25 22:48:49 -04:00
VinPropane