VinPropane
b455ff5ad5
NEO-146: apply C# collection and using style fixes
...
Replace .ToArray() with collection spread, simplify single-statement
await using blocks, use Lock for Postgres schema gates, and document
IDE0063/IDE0305/IDE0330/CA1859 conventions in csharp-style.md.
2026-06-24 20:41:25 -04:00
VinPropane
1922900477
NEO-146: address code review findings for contract stores
...
Add Postgres race/deny tests, duplicate instance id coverage, FK-safe
outcome append, MakeInstanceKey locking, decomposition alignment updates,
and strike-through review doc.
2026-06-24 20:37:16 -04:00
VinPropane
be53d80705
NEO-146: add code review for contract instance and outcome stores
2026-06-24 20:35:16 -04:00
VinPropane
ae641a4dd0
NEO-146: add contract instance and outcome stores with Postgres split
...
Durable per-player contract instances (one active) and append-only
outcome audit rows, mirroring NEO-116/135 store patterns with V011/V012
migrations, AAA tests, README docs, and Bruno health smoke.
2026-06-24 20:27:32 -04:00
VinPropane
82c45941ae
NEO-146: add E7M4-03 contract instance and outcome stores kickoff plan
2026-06-22 20:36:47 -04:00
VinPropane
f18309809a
Merge pull request #186 from ViPro-Technologies/chore/neo-145-contract-catalog-analyzer-warnings
...
chore: fix contract catalog analyzer warnings
2026-06-20 19:53:37 -04:00
VinPropane
93fd8864dc
chore: fix contract catalog analyzer warnings.
...
Primary constructor on ContractTemplateCatalog; concrete List return
types in loader parse helpers; collection spread in NormalizeBundle;
const emptyCatalog in roster gate test.
2026-06-20 19:46:39 -04:00
VinPropane
e3988874d2
Merge pull request #185 from ViPro-Technologies/NEO-145-e7m4-02-server-contract-template-catalog-load-fail-fast
...
NEO-145: E7M4-02 server contract template catalog load (fail-fast)
2026-06-20 19:43:56 -04:00
VinPropane
56bc22c70d
NEO-145: address review findings — tests and decomposition docs.
...
Rename cross-ref unit test; add loader freeze-overflow and missing-schema
negatives; update E7.M4/CT.M1 alignment tables and strike through review.
2026-06-20 19:36:25 -04:00
VinPropane
1b904b594d
NEO-145: add code review for contract catalog load branch.
2026-06-20 19:34:37 -04:00
VinPropane
937412eda6
NEO-145: reconcile implementation plan with shipped catalog load.
2026-06-20 19:31:54 -04:00
VinPropane
5ab5022704
NEO-145: add fail-fast contract template catalog load and registry.
...
Startup loader mirrors validate_content.py E7M4 gates (roster, freeze,
cross-ref, band caps); IContractTemplateRegistry resolves templates by id.
Bruno health smoke confirms host boot after catalog validation.
2026-06-20 19:31:54 -04:00
VinPropane
215493f63b
NEO-145: add E7M4-02 contract catalog load implementation plan.
...
Kickoff plan for fail-fast server loader, IContractTemplateRegistry,
and CI-parity E7M4 gates following NEO-144 content landing.
2026-06-20 19:26:34 -04:00
VinPropane
b5a0f71bca
Merge pull request #184 from ViPro-Technologies/NEO-144-e7m4-01-contracttemplate-catalog-schemas-ci
...
NEO-144: E7M4-01 contract template catalog, schemas, and CI
2026-06-20 19:23:42 -04:00
VinPropane
9cfbf43936
NEO-144: reconcile plan and strike through review follow-ups
...
Document band-cap constant naming, NEO-145 C# port note, and mark review items done.
2026-06-20 19:22:02 -04:00
VinPropane
f7a014fe69
NEO-144: address review findings in contract CI gates
...
Use E7M3 bundle normalization for rep grants, smoke-test contract-seed schema,
and apply cross-ref/band-cap checks to all loaded template rows.
2026-06-20 19:22:02 -04:00
VinPropane
fe9b706092
NEO-144: add code review for contract catalog CI slice
2026-06-20 19:21:01 -04:00
VinPropane
2afd29e4d9
NEO-144: document contract catalog CI and reconcile plan
...
Update content README, module docs, alignment register, and backlog AC for E7M4-01 land.
2026-06-20 19:18:58 -04:00
VinPropane
7ecc8746f5
NEO-144: validate contract templates in content CI
...
Add roster, freeze, cross-ref, and band-1 economy cap gates for E7M4 prototype templates.
2026-06-20 19:18:58 -04:00
VinPropane
58d2c32152
NEO-144: add contract template schemas and prototype catalog
...
Lock ContractTemplate row shape and the single frozen repeat-combat-pocket template for CI.
2026-06-20 19:18:56 -04:00
VinPropane
c7a9e81067
NEO-144: align Epic 7 decomposition docs with E7M4 backlog
...
Update module status, freeze table, register, and Slice 4 DoD links for contract generator work.
2026-06-20 19:15:58 -04:00
VinPropane
4238038e11
NEO-144: add E7M4 Slice 4 pre-production backlog
...
Land NEO-144–NEO-154 story order, freeze table, and cross-link from E7M3 downstream.
2026-06-20 19:15:56 -04:00
VinPropane
53122f9f2a
NEO-144: add E7M4-01 contract catalog kickoff plan
...
Lock ContractTemplate schemas, CI gates, and file lists before server load in NEO-145.
2026-06-20 19:15:43 -04:00
VinPropane
74b6586004
Merge pull request #183 from ViPro-Technologies/NEO-143-playable-faction-reputation-gate-capstone
...
NEO-143: Playable faction reputation + gate capstone (Godot)
2026-06-17 22:24:10 -04:00
VinPropane
24a70d3566
NEO-143: Add Slice 3 faction capstone manual QA and docs.
...
Ship NEO-143 capstone checklist extending NEO-132, client README
end-to-end faction loop section, cross-links, and E7.M3 Ready alignment.
2026-06-17 21:43:35 -04:00
VinPropane
0903bf00bd
NEO-143: Add Slice 3 faction capstone implementation plan.
...
Kickoff clarifications adopt docs-primary scope, NEO-132-extended
capstone path, and NEO-142 regression for gate deny verification.
2026-06-17 21:40:03 -04:00
VinPropane
4f02dc47fa
Merge pull request #182 from ViPro-Technologies/NEO-142-client-faction-standing-gate-hud
...
NEO-142: Client faction standing + gate feedback HUD (Godot)
2026-06-17 21:38:07 -04:00
VinPropane
4b221cdf2a
NEO-142: gdformat faction standing and quest reward tests
2026-06-17 21:31:16 -04:00
VinPropane
4022a1c220
NEO-142: satisfy pre-push gdlint for faction HUD wiring
...
Wrap faction standing HUD deps in a setup dictionary to stay under the function-argument limit, shorten the faction client doc comment for max line length, and add a GdUnit test for setup wiring.
2026-06-17 21:31:09 -04:00
VinPropane
3308fa564f
NEO-142: track GdUnit test script uid companions
...
Stage matching *.gd.uid files for faction standing client and HUD tests so uid:// references stay stable across clones.
2026-06-17 21:30:01 -04:00
VinPropane
d4388e25aa
NEO-142: rename shadowed name variable in quest defs tests
...
Avoid SHADOWED_VARIABLE_BASE_CLASS warnings against Node.name.
2026-06-17 21:24:30 -04:00
VinPropane
3a509d560e
chore: silence IDE0301 and redundant await linter warnings
...
Use static empty bundle grant lists in RewardRouterOperations; drop
redundant await on synchronous GdUnit assert_signal in quest defs test.
2026-06-17 21:19:27 -04:00
VinPropane
ee918c5412
NEO-142: reconcile docs and close out code review findings
...
Check off AC in plan/backlog; update E7.M3 module + alignment register;
strike through addressed review suggestions and nits.
2026-06-17 21:16:17 -04:00
VinPropane
00590d5944
NEO-142: review follow-up — static faction display names + gate rules tests
...
Use FactionStandingClient.display_name_for directly; add GdUnit coverage for
faction_gate_rules_for helper.
2026-06-17 21:16:17 -04:00
VinPropane
187ecc9c0d
NEO-142: add code review for faction standing HUD branch
2026-06-17 21:14:49 -04:00
VinPropane
e39622893b
chore: use collection expressions for empty grant fallbacks
...
Replace Array.Empty<T>() with [] in RewardRouterOperations (IDE0301).
2026-06-17 21:13:29 -04:00
VinPropane
f8a36213a1
NEO-142: clear GDScript linter warnings in faction HUD work
...
Hoist quest progress label lines binding; drop redundant await on synchronous
GdUnit assert_signal calls.
2026-06-17 21:12:54 -04:00
VinPropane
be7878a199
NEO-142: fix GdUnit HTTPClient method enum in faction tests
...
Use METHOD_GET default params matching existing client test mocks; auto_free
progress client stub to avoid orphan exit code.
2026-06-17 21:11:27 -04:00
VinPropane
84bd46635d
NEO-142: document faction HUD and manual QA checklist
...
Add client README section, NEO-142 manual QA steps, and plan reconciliation.
2026-06-17 21:10:36 -04:00
VinPropane
c8c706f839
NEO-142: add faction standing client and HUD wiring
...
Introduce faction-standing GET client, standing label in HudRoot, readable
faction_gate_blocked accept feedback, reputationGrants reward lines, and GdUnit tests.
2026-06-17 21:10:34 -04:00
VinPropane
fb9a8ab8b2
NEO-142: add E7M3-10 client faction HUD implementation plan
...
Kickoff plan for Godot faction standing label, gate deny feedback, and
reputationGrants reward lines after NEO-139/140 server APIs landed.
2026-06-17 21:08:56 -04:00
VinPropane
b4d48f6e36
NEO-141: remove server-only manual QA doc after story end
...
Comment-only infrastructure story — acceptance fully covered by dotnet
test; align with NEO-140 and planning-implementation-docs skip rule.
2026-06-17 19:36:33 -04:00
VinPropane
e102a6b539
Merge pull request #181 from ViPro-Technologies/NEO-141-faction-telemetry-hooks
...
NEO-141: E7M3-09 faction telemetry hook sites (comment-only)
2026-06-17 19:34:12 -04:00
VinPropane
0a4450a199
NEO-141: address review — backlog wording and class summary
...
Align E7M3-09 in-scope bullet with ops-only hook anchors; pluralize
FactionGateOperations telemetry remark; mark review findings done.
2026-06-17 19:27:27 -04:00
VinPropane
cbd8444da3
NEO-141: add code review for faction telemetry hook sites
2026-06-17 19:26:54 -04:00
VinPropane
3c1ade4185
NEO-141: add manual QA and reconcile module docs
...
Update E7M3 backlog, alignment register, and implementation plan
for landed faction telemetry hook sites.
2026-06-17 19:25:27 -04:00
VinPropane
73403622f2
NEO-141: consolidate faction telemetry hook comment sites
...
Complete reputation_delta anchor in ReputationOperations, extend
faction_gate_blocked on both gate deny paths, remove router duplicate
stub, and add README Faction telemetry hooks subsection.
2026-06-17 19:25:25 -04:00
VinPropane
5ab81215ad
NEO-141: add faction telemetry hook sites implementation plan
...
Kickoff plan for E7M3-09 — consolidate comment-only reputation_delta
and faction_gate_blocked anchors from NEO-136/137/138 per NEO-121/130 pattern.
2026-06-17 19:23:25 -04:00
VinPropane
ef75111b2a
NEO-140: remove server-only manual QA doc after story end
...
Manual QA checklists are for client-facing stories; Bruno and dotnet
test cover this HTTP projection slice.
2026-06-17 19:21:48 -04:00
VinPropane
960b4900d0
Merge pull request #180 from ViPro-Technologies/NEO-140-e7m3-quest-http-rep-gate-projections
...
NEO-140: Extend quest HTTP projections for rep + gates (E7M3-08)
2026-06-17 19:19:15 -04:00