VinPropane
a9bc1acaa8
NEO-146: add re-review after cleanup and review follow-up
2026-06-24 20:51:04 -04:00
VinPropane
1922900477
NEO-146: address code review findings for contract stores
...
Add Postgres race/deny tests, duplicate instance id coverage, FK-safe
outcome append, MakeInstanceKey locking, decomposition alignment updates,
and strike-through review doc.
2026-06-24 20:37:16 -04:00
VinPropane
be53d80705
NEO-146: add code review for contract instance and outcome stores
2026-06-24 20:35:16 -04:00
VinPropane
56bc22c70d
NEO-145: address review findings — tests and decomposition docs.
...
Rename cross-ref unit test; add loader freeze-overflow and missing-schema
negatives; update E7.M4/CT.M1 alignment tables and strike through review.
2026-06-20 19:36:25 -04:00
VinPropane
1b904b594d
NEO-145: add code review for contract catalog load branch.
2026-06-20 19:34:37 -04:00
VinPropane
9cfbf43936
NEO-144: reconcile plan and strike through review follow-ups
...
Document band-cap constant naming, NEO-145 C# port note, and mark review items done.
2026-06-20 19:22:02 -04:00
VinPropane
fe9b706092
NEO-144: add code review for contract catalog CI slice
2026-06-20 19:21:01 -04:00
VinPropane
ee918c5412
NEO-142: reconcile docs and close out code review findings
...
Check off AC in plan/backlog; update E7.M3 module + alignment register;
strike through addressed review suggestions and nits.
2026-06-17 21:16:17 -04:00
VinPropane
187ecc9c0d
NEO-142: add code review for faction standing HUD branch
2026-06-17 21:14:49 -04:00
VinPropane
b4d48f6e36
NEO-141: remove server-only manual QA doc after story end
...
Comment-only infrastructure story — acceptance fully covered by dotnet
test; align with NEO-140 and planning-implementation-docs skip rule.
2026-06-17 19:36:33 -04:00
VinPropane
0a4450a199
NEO-141: address review — backlog wording and class summary
...
Align E7M3-09 in-scope bullet with ops-only hook anchors; pluralize
FactionGateOperations telemetry remark; mark review findings done.
2026-06-17 19:27:27 -04:00
VinPropane
cbd8444da3
NEO-141: add code review for faction telemetry hook sites
2026-06-17 19:26:54 -04:00
VinPropane
ef75111b2a
NEO-140: remove server-only manual QA doc after story end
...
Manual QA checklists are for client-facing stories; Bruno and dotnet
test cover this HTTP projection slice.
2026-06-17 19:21:48 -04:00
VinPropane
7011a56755
NEO-140: address code review — grid-contract rep and wire-level gate test
...
Add integration coverage for +10 Rust Collective reputationGrants,
JsonDocument omission test for factionGateRules, extend accept Bruno,
fix manual QA link, strike through review findings.
2026-06-17 19:12:33 -04:00
VinPropane
3ba2fd100c
NEO-140: add code review for quest HTTP rep + gate projections
2026-06-17 19:11:03 -04:00
VinPropane
0fe182565e
NEO-139: address review — trim-path tests and Bruno folder note.
...
Add whitespace-only 404 and padded-path playerId echo tests; document seq 4 standing side effect in faction-standing folder docs.
2026-06-16 17:26:40 -04:00
VinPropane
cc7786ba3a
NEO-139: add code review for faction-standing GET API.
2026-06-16 17:22:40 -04:00
VinPropane
6999eb3303
NEO-138: clear delivery and audit on quest fixture reset.
...
resetQuestIds now clears IRewardDeliveryStore rows and quest-completion
audit deltas so Bruno re-runs re-apply rep grants after standing reset.
2026-06-15 23:10:58 -04:00
VinPropane
57215d401a
NEO-138: re-review confirms follow-ups addressed.
2026-06-15 22:31:29 -04:00
VinPropane
69c3ad4915
NEO-138: address code review follow-ups.
...
Fix Bruno grid-contract status expectation, add race rep rollback and
multi-row audit-failure tests, audit-row assertion, and doc comments.
2026-06-15 22:29:36 -04:00
VinPropane
245f0a84ed
NEO-138: add code review for reward router reputation grants.
2026-06-15 22:22:06 -04:00
VinPropane
64920792ee
chore: address Bruno self-reset review — README, Postgres test, nits.
...
Document resetQuestIds, resource-node fixture, and cooldown clear in server README; add TryClearProgress Postgres integration test; sync-review doc and Bruno require paths.
2026-06-15 21:53:44 -04:00
VinPropane
a36e7b56b5
NEO-137: Address review — quest fixture for Bruno CI and test/docs nits.
...
Add POST …/__dev/quest-fixture to mark quests completed without reward
delivery; wire Bruno pre-request and CI flag. Multi-rule AND unit test,
README notes, gate deny comment, review strikethroughs.
2026-06-15 21:24:21 -04:00
VinPropane
4ffc60f226
NEO-137: Add code review for faction gate operations branch.
2026-06-15 21:21:23 -04:00
VinPropane
ddaf33ce87
NEO-136: fix rollback applied delta and normalize ids at ops boundary
2026-06-15 20:52:04 -04:00
VinPropane
2117b2f8d3
NEO-136: add code review for ReputationOperations
2026-06-15 20:50:57 -04:00
VinPropane
d5f16f4cf4
NEO-135: address code review findings
...
Update decomposition docs for E7M3-03, add in-memory read-clamp test via
test seed hook, fix empty factionId deny code, AAA integration test,
Postgres FK orchestration notes, and strike review suggestions Done.
2026-06-15 20:27:36 -04:00
VinPropane
c066121c9d
NEO-135: add code review for faction standing stores
2026-06-15 20:25:35 -04:00
VinPropane
aa3eb3597c
NEO-134: address code review findings
...
Update decomposition tracking docs, add faction loader integration tests,
reorder standing-band gate before freeze, and guard success logging.
2026-06-15 20:11:55 -04:00
VinPropane
058799a595
NEO-134: add code review for E7M3-02 faction catalog load
2026-06-15 20:10:17 -04:00
VinPropane
6cb7dfbb46
NEO-133: address code review — roster docs, CI cleanup, band gate
...
Cross-link E7.M1 doc to E7M3 five-quest roster; remove dead
_prototype_e7m1_quest_gate; add faction standing-band CI gate;
clarify server roster error strings; grid-contract loader test asserts.
2026-06-15 19:52:42 -04:00
VinPropane
92c078b0e3
NEO-133: Add code review for E7M3-01 catalog branch.
2026-06-15 19:51:42 -04:00
VinPropane
0e13a10b79
NEO-131: Address review — item grant and defs repaint tests.
...
Add operator-chain item display name and definitions_ready reward
label GdUnit cases; add NEO-131 plan link to alignment register.
2026-06-07 23:02:14 -04:00
VinPropane
ca9a3f1b38
NEO-131: Add code review for quest completion reward HUD.
2026-06-07 23:01:27 -04:00
VinPropane
1333da2938
NEO-130: Address review feedback on unlock_granted stub.
...
Document E9.M1 durable-emit gating for rollback paths; reconcile plan
bullet for class summary; strike through resolved review items.
2026-06-07 22:49:00 -04:00
VinPropane
471d4b61a7
NEO-130: add code review for reward telemetry hook sites.
2026-06-07 22:48:12 -04:00
VinPropane
9ab3a70796
NEO-129: address review test and Bruno coverage gaps.
2026-06-07 18:48:45 -04:00
VinPropane
185b38b242
NEO-129: add code review for quest-progress completionRewardSummary.
2026-06-07 18:40:05 -04:00
VinPropane
28e4a70846
NEO-128: address review — operator-chain delivery and wiring deny tests.
2026-06-07 18:27:10 -04:00
VinPropane
f3b4438968
NEO-128: add code review for quest-complete reward wiring.
2026-06-07 18:25:45 -04:00
VinPropane
039672cdac
NEO-127: avoid clobbering winner perks on TryRecord race rollback
...
Track perks unlocked per grant and remove only those on race loss instead
of restoring a full pre-apply snapshot; re-run ReevaluateAfterLevelUp at
post-rollback levels so a concurrent winner's path-auto unlocks survive.
2026-06-07 18:10:56 -04:00
VinPropane
be9bb8f961
NEO-127: restore perk state on TryRecord race rollback
...
Capture pre-skill-apply XP and perk snapshots; on TryRecord loss reverse
each applied skill row via negative delta and restore the perk snapshot so
level-up unlocks from the loser call are reverted without clobbering a
concurrent winner's XP.
2026-06-07 18:04:06 -04:00
VinPropane
c764f5af6b
NEO-127: update review summary after follow-up tests
2026-06-07 17:49:34 -04:00
VinPropane
65ca11171b
NEO-127: address code review test and backlog doc findings
...
Add null-bundle and invalid-id deny tests, fix replay XP assertion,
align E7M2-04 backlog wording with TryApplyGrant, strike review items done.
2026-06-07 17:49:26 -04:00
VinPropane
581c90ab34
NEO-127: add code review for reward router operations
2026-06-07 17:48:42 -04:00
VinPropane
35fa4ad192
NEO-126: address code review — module anchor and casing test
...
Add E7.M2 implementation anchor for the delivery store and assert
mixed-case TryRecord replays are rejected at the store layer.
2026-06-07 17:33:07 -04:00
VinPropane
3d8df939b6
NEO-126: add code review for reward delivery store
2026-06-07 17:32:37 -04:00
VinPropane
766837d7e8
NEO-125: address code review findings for bundle validation
...
Rename freeze-first loader tests, add PrototypeE7M2QuestCatalogRulesTests
for cross-ref paths, align missing skill-def error with Python, and
document bundle schema path resolution in server README.
2026-06-07 15:27:55 -04:00
VinPropane
ad80ed8760
NEO-125: add code review for quest bundle catalog load
2026-06-07 15:26:51 -04:00
VinPropane
d3c7dbb1ad
NEO-124: Fix E7.M2 alignment register row and close review follow-up.
...
Repair corrupted References column; document negative CI spot-check results in review.
2026-06-07 15:17:24 -04:00