VinPropane
3ce645a0f0
NEO-110: code review — request changes for loot label helper.
2026-05-31 19:37:21 -04:00
VinPropane
bcc9bf1c69
NEO-110: manual QA, README, plan reconciliation, and module docs.
2026-05-31 19:35:56 -04:00
VinPropane
d81d19b859
NEO-110: encounter progress client, HUD labels, and GdUnit tests.
2026-05-31 19:35:54 -04:00
VinPropane
3128f36df9
NEO-110: kickoff implementation plan for encounter HUD client.
2026-05-31 19:34:27 -04:00
VinPropane
c3022201fe
Merge pull request #148 from ViPro-Technologies/NEO-109-slice-3-encounter-telemetry-hook-sites
...
NEO-109: Slice 3 encounter telemetry hook sites
2026-05-31 19:29:34 -04:00
VinPropane
df248308c7
NEO-109: Restore early return on completion failure guard.
...
Bugbot PR #148 : keep consistent guard-clause pattern in
EncounterCombatWiring.TryProcessCastOutcome.
2026-05-31 19:25:33 -04:00
VinPropane
0f60423863
NEO-109: Drop unused definition out param in activation path.
2026-05-31 19:06:06 -04:00
VinPropane
c40bcd3ffe
NEO-109: Address code review hook-anchor findings.
...
Move encounter_start comments after successful TryActivate; clarify
encounter_complete_denied caller context; strike through review items.
2026-05-31 19:06:01 -04:00
VinPropane
d1a67a89bd
NEO-109: Add code review for encounter telemetry hook sites.
2026-05-31 19:04:55 -04:00
VinPropane
8cda0d76da
NEO-109: Document encounter telemetry hooks in README and module docs.
...
Reconcile plan, backlog, alignment register, and E5.M3 module snapshot.
2026-05-31 19:03:03 -04:00
VinPropane
1a7b5312c5
NEO-109: Add Slice 3 encounter telemetry hook comments.
...
Document encounter_start, encounter_complete, reward_attribution, and
encounter_complete_denied at engine anchors; remove wiring duplicate.
2026-05-31 19:03:03 -04:00
VinPropane
e6debc2968
NEO-109: Add kickoff implementation plan.
...
Documents comment-only encounter_start, encounter_complete, and
reward_attribution hook sites with kickoff decisions adopted.
2026-05-31 19:01:28 -04:00
VinPropane
4aa7665e7c
Merge pull request #147 from ViPro-Technologies/NEO-108-get-encounter-progress-wire-dtos-bruno
...
NEO-108: GET encounter-progress + wire DTOs + Bruno
2026-05-31 18:58:59 -04:00
VinPropane
40d948ff2c
NEO-108: Bruno elite defeat uses 12 pulses; reset HP baseline.
...
Elite has 200 HP (8 pulses at 25 damage); defeat loop matches C# tests.
Combat-health seq 1 resets dev fixture so currentHp is 100 after prior smokes.
2026-05-31 18:50:29 -04:00
VinPropane
05beec9644
NEO-108: Use bru.sleep in Bruno helper (no setTimeout).
...
Bruno pre-request sandbox does not define setTimeout; pulse waits and
telegraph polls now call bru.sleep via prototype-npc-bruno-helper.
2026-05-31 18:48:22 -04:00
VinPropane
af80b878ad
NEO-108: Bruno move near each NPC and isolate pulse slot.
...
Ranged/elite casts failed out_of_range after melee at (-5,-5); add
prototype-npc-bruno-helper moves and pulse cooldown between chains.
Combat-health uses slot 4 and moves near elite before cast.
2026-05-31 18:46:00 -04:00
VinPropane
a5182a4c14
NEO-108: Fix Bruno encounter-progress and combat-health smokes.
...
Use collection-relative ./scripts require path; reset encounter stores in
combat-targets dev fixture for inactive GET; combat-health uses slot 3.
2026-05-31 18:43:50 -04:00
VinPropane
25f3714554
NEO-108: Address code review findings for encounter-progress GET.
...
Add BuildSnapshot invariant tests, whitespace 404, idempotent second GET,
grant-order assertions; dedupe MapRow progress lookup; strike review items.
2026-05-31 18:39:52 -04:00
VinPropane
ebb27aed2d
NEO-108: Add code review for encounter-progress GET.
2026-05-31 18:38:31 -04:00
VinPropane
07ebb9efb8
NEO-108: Add Bruno smokes and document encounter-progress GET.
...
Bruno folder covers inactive default and three-NPC defeat spine; README and
E5.M3 docs mark E5M3-08 landed with plan reconciliation.
2026-05-31 18:37:43 -04:00
VinPropane
c1fd2053d0
NEO-108: Add GET encounter-progress API and integration tests.
...
Projects progress, completion, and event stores into versioned per-player
rows with inactive/active/completed state and commit-time grant summary.
2026-05-31 18:37:42 -04:00
VinPropane
16018586b7
NEO-108: Add kickoff implementation plan for encounter-progress GET.
...
Documents HTTP projection from progress, completion, and event stores,
Bruno defeat spine, and adopted grant-summary source from kickoff.
2026-05-31 18:35:42 -04:00
VinPropane
51e2007d60
Merge pull request #146 from ViPro-Technologies/NEO-107-encounter-complete-event-e7m2-hook
...
NEO-107: EncounterCompleteEvent persistence + E7.M2 hook stub
2026-05-31 18:34:16 -04:00
VinPropane
f51617f8b5
NEO-107: Address code review findings for event store persistence.
...
Update E5.M3 module summary and NEO-105 snapshot, fix store test AAA
layout, add empty encounter id fail-closed test, strike through review items.
2026-05-31 18:27:28 -04:00
VinPropane
29217c0fa0
NEO-107: Add code review for EncounterCompleteEvent persistence.
2026-05-31 18:26:51 -04:00
VinPropane
555c3235ff
NEO-107: Reconcile plan and module docs for event persistence.
...
Mark E5M3-09 acceptance criteria complete and cross-link E7.M2 consumer
hook anchor across backlog, alignment register, and module snapshots.
2026-05-31 18:26:13 -04:00
VinPropane
a02496c6bc
NEO-107: Persist EncounterCompleteEvent and wire E7.M2 hook stub.
...
Add IEncounterCompleteEventStore with in-memory implementation, record
events on successful TryCompleteAndGrant, and expand reward_delivery
hook comments for future QuestRewardBundle routing.
2026-05-31 18:26:11 -04:00
VinPropane
986cf55e73
NEO-107: Add kickoff implementation plan for EncounterCompleteEvent persistence.
2026-05-31 18:22:57 -04:00
VinPropane
856dc8dcf0
Merge pull request #145 from ViPro-Technologies/NEO-106-wire-combat-defeat-encounter-progress-completion
...
NEO-106: Wire combat defeat → encounter progress/completion
2026-05-31 18:16:21 -04:00
VinPropane
9c74933e6e
NEO-106: Address code review findings for combat encounter wiring.
2026-05-31 18:10:41 -04:00
VinPropane
a7b835290c
NEO-106: Add code review for combat encounter wiring.
2026-05-31 18:09:20 -04:00
VinPropane
8306f92554
NEO-106: Document combat encounter wiring and update E5.M3 docs.
2026-05-31 18:08:29 -04:00
VinPropane
f581cf412c
NEO-106: Wire encounter progress and completion from ability cast.
2026-05-31 18:08:28 -04:00
VinPropane
fc09808482
NEO-106: Add kickoff implementation plan for combat encounter wiring.
2026-05-31 18:05:42 -04:00
VinPropane
7656fded03
Merge pull request #144 from ViPro-Technologies/NEO-105-encounter-completion-inventory-reward-apply
...
NEO-105: EncounterCompletionOperations + inventory reward apply
2026-05-31 17:19:37 -04:00
VinPropane
01bcd7334c
NEO-105: Consolidate inventory snapshot clone helper.
...
Add PlayerInventorySnapshot.Clone() and use it from craft and
encounter completion pre-flight paths (Bugbot PR #144 ).
2026-05-31 17:11:55 -04:00
VinPropane
cbb6f137fd
NEO-105: Address code review findings for encounter completion.
...
Add apply-phase rollback test, E9.M1 deny hook comment, inventory
reason passthrough, and tighten idempotent replay assertions.
2026-05-31 17:02:32 -04:00
VinPropane
1a74fbda54
NEO-105: Add code review for encounter completion grants.
2026-05-31 16:59:46 -04:00
VinPropane
009fedf65e
NEO-105: Document encounter completion grants and update E5.M3 docs.
2026-05-31 16:57:54 -04:00
VinPropane
0cf82b9c0a
NEO-105: Add encounter completion operations and inventory grants.
...
TryCompleteAndGrant applies reward-table fixed grants with pre-flight
simulate, compensating rollback, and idempotent completion marking.
Returns EncounterCompleteEvent payload for NEO-107 persistence.
2026-05-31 16:57:53 -04:00
VinPropane
b5306aa933
NEO-105: Add kickoff implementation plan for encounter completion grants.
2026-05-31 16:55:22 -04:00
VinPropane
719a14f110
Merge pull request #143 from ViPro-Technologies/NEO-104-encounter-progress-completion-stores
...
NEO-104: E5M3-05 encounter progress + completion stores
2026-05-31 16:51:40 -04:00
VinPropane
0289930897
NEO-104: Use subset check for all-targets-defeated predicate.
...
Matches documented semantics; extra defeated ids via direct store
calls no longer block completion readiness (Bugbot PR #143 ).
2026-05-31 16:44:48 -04:00
VinPropane
91f74b7d6e
NEO-104: Address code review findings for encounter stores.
...
Normalize encounter ids in IsAllRequiredTargetsDefeated, document TryActivate
completion gating, lock IsCompleted reads, add operations tests, and update
plan and review doc.
2026-05-31 16:37:22 -04:00
VinPropane
87dff6e3f4
NEO-104: Add code review for encounter progress stores.
2026-05-31 16:36:42 -04:00
VinPropane
aaccbbbcaf
NEO-104: Add encounter progress and completion stores.
...
In-memory IEncounterProgressStore and IEncounterCompletionStore with
EncounterProgressOperations for activation, defeat tracking, and
all-targets-defeated checks; unit tests and docs.
2026-05-31 16:18:56 -04:00
VinPropane
727ce4774a
NEO-104: Add kickoff implementation plan for encounter stores.
2026-05-31 16:16:03 -04:00
VinPropane
aa81914e9f
Merge pull request #142 from ViPro-Technologies/NEO-103-get-world-encounter-definitions
...
NEO-103: GET /game/world/encounter-definitions + Bruno
2026-05-31 15:53:16 -04:00
VinPropane
e4e75f5dc7
NEO-103: Address code review follow-ups.
...
Mark E5M3-04 landed in module Summary, assert fixedGrants order in
C# test, add Bruno ordinal comment, strike through review items.
2026-05-31 15:43:37 -04:00
VinPropane
573c42add7
NEO-103: Add code review for encounter-definitions GET.
2026-05-31 15:41:49 -04:00