don
/
neon-sprawl
mirror of https://github.com/ViPro-Technologies/neon-sprawl
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
958 Commits
3 Branches
0 Tags
322 MiB
Commit Graph

83 Commits (047237e6512a2ca76db081a5daa91aba43a38337)

Author SHA1 Message Date
Don 047237e651 NEO-91: address code review follow-ups 
Add legacy alpha targeting integration test, elite HP assertion, AAA fix,
Bruno docs refresh, and module/alignment doc updates. Strike through
resolved items in the NEO-91 review.

Co-authored-by: Cursor <cursoragent@cursor.com>
 2026-05-26 23:46:39 -04:00
Don fa9acc85ac NEO-91: migrate combat targets to three NPC instances 
Replace alpha/beta dummies with PrototypeNpcRegistry (melee/ranged/elite),
per-archetype max HP from INpcBehaviorDefinitionRegistry, and updated
server tests + Bruno smokes. Documents breaking client change for NEO-97.

Co-authored-by: Cursor <cursoragent@cursor.com>
 2026-05-26 23:42:31 -04:00
VinPropane d3e765fb8f NEO-90: add GET /game/world/npc-behavior-definitions projection. 
Expose read-only npcBehaviors envelope backed by INpcBehaviorDefinitionRegistry,
with integration tests, Bruno smoke, and doc reconciliation.
 2026-05-25 17:49:01 -04:00
VinPropane 83282e76f0 NEO-88: Fail-fast NPC behavior catalog load at server startup. 
Mirror NEO-77 ability loader: JsonSchema.Net validation, E5M2 three-id
gate, leash > aggro numeric gate, DI singleton, Bruno health smoke, and
16 AAA loader/host tests.
 2026-05-25 17:08:40 -04:00
VinPropane adc34e0a9f NEO-44: Fix Bruno collection ordering and interaction pre-request 
Remove gig-progression folder seq so defeat spine runs after ability-cast;
run defeat spine at seq 31. Gather until node_depleted in interaction test
so craft spine pollution does not break the depleted-node deny case.
 2026-05-25 12:20:30 -04:00
VinPropane 32fbcec766 NEO-44: Fix Bruno defeat spine for CI collection order. 
Reset prototype target HP before cast chain, use slot 2 to avoid
cooldown pollution, and assert +25 gig XP delta from baseline.
 2026-05-25 12:14:29 -04:00
VinPropane 9d9b53332f NEO-44: Address code review — docs, debug log, Bruno playerId. 
Update E5.M1/E2.M2 module docs for gig XP path; LogDebug on failed
gig store write; Bruno defeat spine uses {{playerId}}; strike review items.
 2026-05-25 12:08:21 -04:00
VinPropane 71a6761f3c NEO-44: Grant gig XP on combat defeat via dedicated store. 
Add IPlayerGigProgressionStore (in-memory + Postgres V007), GET
/gig-progression snapshot, and CombatDefeatGigXpGrant on cast accept
when targetDefeated — 25 XP to breach, outside E2.M2 skill XP.
Includes tests, Bruno, README, manual QA, and plan reconciliation.
 2026-05-25 12:04:40 -04:00
VinPropane 7d325eec4c NEO-83: Use slot 1 in Bruno defeat spine to avoid seq 2 cooldown. 
Combat-targets fixture resets HP only; seq 2 leaves slot 0 on cooldown so the four-pulse spine follows NEO-82 and binds slot 1.
 2026-05-25 11:31:02 -04:00
VinPropane ea13b05196 NEO-83: Fix Bruno CI combat-targets HP state pollution. 
Add dev combat-targets fixture reset endpoint, Bruno pre-request helper, and enable fixture in CI Bruno step so combat-targets tests run after ability-cast defeat spine.
 2026-05-25 11:28:13 -04:00
VinPropane 50a2c9ca9d NEO-83: Address code review follow-ups for combat-targets GET. 
Fail fast on health store TryGet miss, tighten one-pulse integration test assertions, add fast Bruno cast→GET smoke, update review doc.
 2026-05-25 11:23:32 -04:00
VinPropane 52b1d4d206 NEO-83: Add GET /game/world/combat-targets HP snapshot. 
Wire CombatTargetsWorldApi backed by ICombatEntityHealthStore, Bruno happy + cast defeat spine, integration tests, README and module tracking docs.
 2026-05-25 11:20:13 -04:00
VinPropane 3e0d370677 NEO-82: Use slot 1 in Bruno defeat spine to avoid cooldown clash. 
Happy cast (seq 22) leaves slot 0 cooling; defeat spine pre-request casts
were denied with on_cooldown. Slot 1 + pre-request fail-fast on bad cast.
 2026-05-25 11:07:59 -04:00
VinPropane 52bf9fc4bf NEO-82: Fix cast definition lookup order and Bruno target isolation. 
Load ability definition before TryResolve so cooldown lookup cannot deny
after HP mutation (Bugbot). Happy Bruno cast uses beta; defeat spine keeps
alpha; bump spine seq and cooldown sleep margin for CI.
 2026-05-25 11:04:55 -04:00
VinPropane 322798b2ef NEO-82: Address code review doc sync and test AAA follow-ups. 
Update E5.M1 module doc, dependency register, and alignment table for
NEO-82 landed; Bruno defeat spine HP stepping; refactor four-pulse cast
test Arrange/Act/Assert; strike through resolved review items.
 2026-05-25 10:45:31 -04:00
VinPropane e8be100f80 NEO-82: Wire cast POST into combat engine and cast response. 
Invoke CombatOperations.TryResolve after E1 gates; nested combatResolution
on accept; per-ability catalog cooldown; target_defeated deny without
cooldown. Tests, Bruno defeat spine, README and module docs updated.
 2026-05-25 10:36:42 -04:00
VinPropane 94b6c67b07 NEO-78: Address code review follow-ups for ability-definitions GET. 
Update dependency register and E5M1 backlog, tighten tests and Bruno
spot-checks, strike through resolved review items.
 2026-05-24 22:26:54 -04:00
VinPropane 44e0056b37 NEO-78: Add GET /game/world/ability-definitions HTTP projection. 
Expose versioned read-only ability catalog via IAbilityDefinitionRegistry,
with integration tests, Bruno folder, and docs alignment.
 2026-05-24 22:22:48 -04:00
VinPropane 603cc525ad NEO-79: Fix Bruno cast unknown-ability test setup. 
Bind slot 0 in pre-request so the cast route reaches unknown_ability
instead of slot_unbound when run before other ability-cast requests.
 2026-05-24 22:11:01 -04:00
VinPropane bd4912004a NEO-79: Add IAbilityDefinitionRegistry and migrate hotbar/cast validation. 
Injectable registry backed by AbilityDefinitionCatalog; PrototypeAbilityRegistry
keeps id constants only. Bruno smoke for unknown_ability deny paths.
 2026-05-24 22:05:27 -04:00
VinPropane fd2ffee089 NEO-77: Address code review — Bruno folder, E5M1 gate test, docs. 
Add ability-catalog folder.bru, extra-id E5M1 gate AAA test, dependency
register NEO-77 note, and strike through resolved review suggestions.
 2026-05-24 21:44:02 -04:00
VinPropane 619089ca40 NEO-77: Add fail-fast ability catalog load at server startup. 
Load content/abilities/*_abilities.json with CI-parity validation, E5M1
four-id gate, DI registration, AAA loader/host tests, and Bruno health check.
 2026-05-24 21:40:58 -04:00
VinPropane 87c27e231b NEO-70: Emit explicit nulls on CraftResponse optional fields. 
Serialize reasonCode and xpGrantSummary as null when absent so Bruno
deny tests match inventory POST wire shape; assert JSON nulls in API tests.
 2026-05-24 18:13:10 -04:00
VinPropane 2221dc6b4b NEO-70: Fix Bruno craft assertions for CI wire JSON shape. 
Expect omitted reasonCode on success, refine XP delta >= 10 when refine
is skipped, and scrap unchanged on invalid_quantity without fixed totals.
 2026-05-24 18:10:17 -04:00
VinPropane db7c443b50 NEO-70: Fix Bruno craft tests for shared Postgres CI state. 
Clear refined stock for insufficient_materials deny; spine tolerates
node_depleted gathers, reuses persisted scrap, and asserts refine XP delta.
 2026-05-24 18:06:26 -04:00
VinPropane 5a3904c6bc NEO-70: Address code review findings for craft HTTP. 
Rename wire DTO to PlayerCraftRequest, add store-missing and default-quantity
API tests, improve Bruno deny isolation, README success sample, and doc nits.
 2026-05-24 18:00:26 -04:00
VinPropane 46393b8ca5 NEO-70: Add craft POST HTTP, Bruno spine, and docs. 
Wire POST /game/players/{id}/craft to CraftOperations with CraftResponse DTOs,
integration tests, gather→refine→make Bruno folder, and module/README updates.
 2026-05-24 17:57:55 -04:00
VinPropane 1636fdc2cb NEO-68: Add GET /game/world/recipe-definitions HTTP projection. 
Wire RecipeDefinitionsWorldApi over IRecipeDefinitionRegistry with schema v1
DTOs, Bruno folder, manual QA, and FrozenEightInIdOrder integration test.
 2026-05-24 17:08:15 -04:00
VinPropane f209636e7e NEO-66: Fail-fast server recipe catalog load at startup. 
Add Game/Crafting loader, Slice 3 gate rules, DI registration, and AAA tests
mirroring item/resource-node catalog patterns; cross-check item and skill ids.
 2026-05-24 16:41:48 -04:00
VinPropane 0f846f90b9 NEO-63: fix Bruno depletion test node isolation. 
Use prototype_urban_bulk_delta so earlier alpha gathers in the
collection do not pre-deplete capacity under CI Postgres persistence.
 2026-05-24 15:51:32 -04:00
VinPropane e681857778 NEO-63: wire interact to gather engine and expand registry. 
Four resource_node anchors; gather denies map to InteractionResponse;
integration tests, Bruno gather/inventory and depletion flows.
 2026-05-24 15:44:12 -04:00
VinPropane 2b66df86b8 NEO-60: address code review — register footnote and Bruno comment 
Extend E3.M1 dependency register note with NEO-57–NEO-60 landed slices;
add StringComparer.Ordinal comment to Bruno ordinal test for parity.
 2026-05-24 14:49:15 -04:00
VinPropane 97f8f31682 NEO-60: add GET /game/world/resource-node-definitions endpoint 
Versioned read-only projection backed by IResourceNodeDefinitionRegistry
with nested yield DTOs, integration test, Bruno, manual QA, and docs.
 2026-05-24 14:47:23 -04:00
VinPropane 0384b63046 NEO-58: add fail-fast resource-node catalog load at startup 
Loader, Slice 2 gates, DI registration, AAA tests, README and plan updates.
Cross-checks yield itemIds against ItemDefinitionCatalog loaded first.
 2026-05-24 14:01:29 -04:00
VinPropane b8ee4b55ee NEO-55: fix Bruno local module resolution for inventory helper 
Move helper to scripts/ and whitelist via bruno.json
additionalContextRoots so pre-request require() works in Bruno.
 2026-05-23 22:59:58 -04:00
VinPropane 1cbe6302b5 NEO-55: make inventory Bruno tests order-independent 
Shared inventory-api-helper seeds stock and records baselines in
pre-request scripts; assertions use exact deltas instead of cumulative
at.least checks. Harden C# remove round-trip add assertion.
 2026-05-23 22:57:53 -04:00
VinPropane 00ada50b95 NEO-55: fix Bruno GET inventory test for persistent dev player state 
Assert slot shape rules instead of requiring an all-empty grid when
dev-local-1 already holds items from prior collection runs.
 2026-05-23 22:53:50 -04:00
VinPropane fddbb95a45 NEO-55: address code review suggestions for inventory HTTP 
Add remove round-trip and invalid_quantity API tests, Bruno remove request,
dependency register NEO-55 footnote, and strike-through review follow-ups.
 2026-05-23 22:51:59 -04:00
VinPropane 69327f50b4 NEO-55: player inventory GET/POST HTTP, Bruno, and docs 
Versioned snapshot read and mutationKind add/remove POST backed by
PlayerInventoryOperations; AAA API tests; Bruno happy path + deny case.
 2026-05-23 22:45:27 -04:00
VinPropane 52590fa749 NEO-53: address code review suggestions 
Register footnote NEO-53, Bruno exact id-order test, test indent fix,
review doc strikethroughs.
 2026-05-23 19:12:20 -04:00
VinPropane 08428c4da4 NEO-53: GET world item-definitions, Bruno, docs, and tests 
Registry-backed read model at /game/world/item-definitions; Bruno
collection, manual QA checklist, README and module alignment updates.
 2026-05-23 19:09:46 -04:00
VinPropane 2ba129dca1 NEO-51: Fail-fast item catalog load at server startup. 
Mirror NEO-34/validate_content.py: *_items.json schema validation,
Slice 1 gate, ItemDefinitionCatalog DI, loader/host tests, Bruno health smoke.
 2026-05-17 21:56:09 -04:00
VinPropane 00c5937872 NEO-48: revert WhenWritingNull on skill-progression grant API 
Keep omit-null reasonCode only on new perk-state responses; restoring
the existing grant endpoint wire format (reasonCode: null on success).
 2026-05-17 20:59:37 -04:00
VinPropane aa83790703 NEO-48: omit null reasonCode from success JSON responses 
WhenWritingNull on PerkBranchSelectResponse and SkillProgressionGrantResponse
matches hotbar/cast/interaction; fixes Bruno tier1 undefined check.
 2026-05-17 20:46:28 -04:00
VinPropane aba26446d3 NEO-48: address r2 review — atomic fixture, tests, docs 
Batch skillXp then resetPerkState with XP rollback; 400 for invalid skillXp;
MasteryFixtureApi gate tests; README fixture vs grant semantics; Bruno GET playerId.
 2026-05-17 20:37:00 -04:00
VinPropane ffdbed26f2 NEO-48: dev mastery-fixture API for Bruno state setup 
Replace fixture player ids with POST …/__dev/mastery-fixture (resetPerkState,
absolute skillXp). Bruno deny tests set state in pre-request on dev-local-1.
Gated to Development/Testing or Game:EnableMasteryFixtureApi.
 2026-05-17 20:31:26 -04:00
VinPropane b72201b1f0 NEO-48: Bruno fixture players for deterministic perk deny tests 
Seed neo48-perk-fresh and neo48-perk-branch via Game:FixturePlayerIds;
level_too_low uses isolated fresh player, branch_already_chosen sets up
neo48-perk-branch in pre-request instead of skipping on shared state.
 2026-05-17 20:26:21 -04:00
VinPropane f4c3fe86e4 NEO-48: skip level_too_low Bruno when dev player already progressed 
Pre-request checks salvage level and tier-1 pick; bru.skipRequest avoids
false failure after branch_already_chosen or skill-progression grants.
 2026-05-17 20:23:42 -04:00
VinPropane d5b65c94f6 NEO-48: fix Bruno pre-request baseUrl for branch_already_chosen 
Use getEnvVar fallback and axios like other collection scripts; Invalid URL
when baseUrl was undefined in pre-request.
 2026-05-17 20:22:22 -04:00
VinPropane 3ba8300652 NEO-48: address code review — Bruno deny, API deny tests 
Add self-contained branch_already_chosen Bruno request, HTTP deny smoke
for unknown track/tier/branch and null-body 400, folder docs for level_too_low.
 2026-05-17 20:21:42 -04:00