1.9 KiB
1.9 KiB
Manual QA — NEO-130 (reward telemetry hook sites)
Reference: implementation plan, NEO-127 implementation plan (reward router), NEO-128 implementation plan (quest-state wiring).
Preconditions
- Run
NeonSprawl.Server(dotnet runfromserver/NeonSprawl.Server; defaulthttp://localhost:5253) if exercising Bruno; not required for code review only. - This story adds comments only; reward delivery behavior matches NEO-127/128.
Code review check
- Open
server/NeonSprawl.Server/Game/Rewards/RewardRouterOperations.cs. - Confirm
unlock_grantedstub comment block after item + skill XP apply loops, beforeRewardDeliveryEventconstruction. - Confirm
reward_deliverycomment block immediately afterdeliveryStore.TryRecordreturnstrue(inside the success branch). - Confirm
TODO(E9.M1)markers and planned payload fields; no newILoggeror metrics calls. - Confirm no duplicate hook comments in
QuestStateOperations,QuestAcceptApi, orQuestProgressApi. - Open
server/NeonSprawl.Server/Game/Rewards/RewardDeliveryEvent.cs— xml summary cross-referencesreward_deliveryhook site. - Open server README — Reward telemetry hooks (NEO-130) — NEO-130 subsection present with event table.
Regression (optional)
cd server && dotnet test NeonSprawl.sln
Expect all tests pass (comments-only change).
Bruno (optional sanity)
From bruno/neon-sprawl-server/quest-progress/ against a running server:
- Get quest progress after gather intro complete —
completionRewardSummaryunchanged when quest completes via wiring. - Health after quest complete reward wiring — server health unchanged.