neon-sprawl/docs/reviews
VinPropane 435a32b3b3 NEO-24: fix movement-driven target refresh via authoritative_ack signal
Review 2026-04-21 caught that the hybrid soft-lock refresh path is
unreachable during normal WASD locomotion. `main.gd` was wiring
`TargetSelectionClient` to `PositionAuthorityClient.authoritative_position_received`,
which only fires on boot sync and move-rejection resync — successful
`move-stream` 200s are intentionally silent to avoid RTT rubber-banding.
So walking out of an alpha/beta radius never triggered the throttled
`GET /target` the HUD depends on, and validity stayed stuck at `ok`.

Add a separate `authoritative_ack(world)` signal on `PositionAuthorityClient`
emitted from both `BOOT_GET` 200 and successful `move-stream` 200, and
switch `TargetSelectionClient` (+ `main.gd`) to it. The snap signal keeps
its current semantics so rubber-band suppression is untouched; the ack
signal is a pure heartbeat that cooldown-throttled consumers can hook.

Also adds an integration test that wires both real clients together (per
the review's suggestion 1) so renames or mis-wires between the two
scripts fail loudly rather than silently skipping the end-to-end path.

- `client/scripts/position_authority_client.gd`: new `authoritative_ack`
  signal; extracted `_parse_world_from_response` helper to share JSON
  parse across `BOOT_GET` and `STREAM_POST`; emit ack from both.
- `client/scripts/target_selection_client.gd`: rename
  `on_authoritative_position_snap` to `on_authoritative_ack`; drop
  `apply_as_snap` gate (no longer meaningful).
- `client/scripts/main.gd`: connect the new signal.
- `client/test/position_authority_client_test.gd`: assert ack on boot
  200 and stream 200.
- `client/test/target_selection_client_test.gd`: rename tests for new
  handler.
- `client/test/target_refresh_on_locomotion_test.gd`: new integration
  suite wiring real authority + target clients.
- Plan Decision 3 + Tests row + Files-to-modify row updated.
- `docs/reviews/2026-04-21-NEO-24.md`: committed with blocking issue +
  suggestions struck through with `Done.` notes per
  planning-implementation-docs rule.
- `docs/decomposition/modules/documentation_and_implementation_alignment.md`:
  E1.M3 row now reflects NEO-24 landed.
- `client/README.md` + `docs/manual-qa/NEO-24.md`: refreshed signal names
  so the soft-lock refresh description matches the wiring.

Tests: 88/88 GdUnit headless passed locally.
2026-04-21 22:35:41 -04:00
..
2026-03-29-NEO-6.md chore: point docs and rules at Linear NEO issue ids 2026-04-13 13:15:32 -04:00
2026-03-30-NEO-7.md chore: point docs and rules at Linear NEO issue ids 2026-04-13 13:15:32 -04:00
2026-03-30-NEO-8.md chore: point docs and rules at Linear NEO issue ids 2026-04-13 13:15:32 -04:00
2026-03-31-game-design-skills-coherence.md docs: drop classless terminology; rename Epic 2 to skills and progression 2026-04-03 21:33:53 -04:00
2026-04-03-branch-chore-game-design-docs-vs-main.md docs: E2.M1 contract column lists allowedXpSourceKinds (nit #2) 2026-04-03 21:34:49 -04:00
2026-04-03-final-branch-docs-review.md chore: mark vision-plan suggestion done in final docs review 2026-04-03 22:58:14 -04:00
2026-04-03-game-design-branch-docs-review.md chore: stable Epic 3 slice anchors; deep-links from gather/craft docs 2026-04-03 22:14:47 -04:00
2026-04-04-NEO-9.md chore: point docs and rules at Linear NEO issue ids 2026-04-13 13:15:32 -04:00
2026-04-05-NEO-11.md chore: point docs and rules at Linear NEO issue ids 2026-04-13 13:15:32 -04:00
2026-04-05-NEO-14.md chore: point docs and rules at Linear NEO issue ids 2026-04-13 13:15:32 -04:00
2026-04-07-NEO-15.md chore: point docs and rules at Linear NEO issue ids 2026-04-13 13:15:32 -04:00
2026-04-08-NEO-13.md chore: point docs and rules at Linear NEO issue ids 2026-04-13 13:15:32 -04:00
2026-04-08-NEO-16.md chore: point docs and rules at Linear NEO issue ids 2026-04-13 13:15:32 -04:00
2026-04-08-NEO-17.md chore: point docs and rules at Linear NEO issue ids 2026-04-13 13:15:32 -04:00
2026-04-09-NEO-20.md chore: point docs and rules at Linear NEO issue ids 2026-04-13 13:15:32 -04:00
2026-04-10-NEO-14-followup.md chore: point docs and rules at Linear NEO issue ids 2026-04-13 13:15:32 -04:00
2026-04-10-NEO-18.md chore: point docs and rules at Linear NEO issue ids 2026-04-13 13:15:32 -04:00
2026-04-17-NEO-22.md NEO-22: Cache scrape contact in WASD tick; close review items 2026-04-17 20:21:13 -04:00
2026-04-17-NEO-23.md NEO-23: code review follow-up (E1.M3 docs, GET 404 test, radius bounds) 2026-04-17 21:14:43 -04:00
2026-04-18-e1m3-documentation.md chore: address E1.M3 docs review (Slice 3 anchor, Linear pointers) 2026-04-17 20:48:53 -04:00
2026-04-21-NEO-24.md NEO-24: fix movement-driven target refresh via authoritative_ack signal 2026-04-21 22:35:41 -04:00