don
/
neon-sprawl
mirror of https://github.com/ViPro-Technologies/neon-sprawl
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

chore: mark vision-plan suggestion done in final docs review

pull/18/head
VinPropane 2026-04-03 22:58:14 -04:00
parent 53fb1d6515
commit 3d9ea1fc6c
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
docs/reviews/2026-04-03-final-branch-docs-review.md
View File

@ -10,7 +10,7 @@
## Summary
The branch tightens the **skills** track around **`allowedXpSourceKinds`**, four **`SkillCategory`** values, and explicit rejection of **combat encounter → skill XP**. Game-design docs (`progression`, `gathering`, `crafting`, `abilities`, `gigs`, `skills`) and **`epic_02_skills_and_progression.md`** agree with **E2.M1** / **E2.M2**. **`zones.md`** and cross-links sit correctly beside **`risk-security-bands.md`** on the **E4.M1** graph. **`scripts/validate_content.py`** and **`scripts/check_decomposition_language.py`** both pass locally. Optional follow-up: one line under **E2.M2** in **`neon_sprawl_vision.plan.md`** for **`sourceKind`** / **`allowedXpSourceKinds`** parity with modules.
The branch tightens the **skills** track around **`allowedXpSourceKinds`**, four **`SkillCategory`** values, and explicit rejection of **combat encounter → skill XP**. Game-design docs (`progression`, `gathering`, `crafting`, `abilities`, `gigs`, `skills`) and **`epic_02_skills_and_progression.md`** agree with **E2.M1** / **E2.M2**. **`zones.md`** and cross-links sit correctly beside **`risk-security-bands.md`** on the **E4.M1** graph. **`scripts/validate_content.py`** and **`scripts/check_decomposition_language.py`** both pass locally. **`neon_sprawl_vision.plan.md`** **E2.M2** **grant channel policy** was added after this review (**53fb1d6**).
## Documentation checked
@ -29,7 +29,7 @@ The branch tightens the **skills** track around **`allowedXpSourceKinds`**, four
| `docs/decomposition/modules/E2_M3_*.md`, `E2_M4_*.md` | **Matches** | Epic link updated |
| `docs/decomposition/README.md` | **Matches** | Epic 2 row → new filename |
| `docs/decomposition/modules/CT_M1_ContentValidationPipeline.md` | **Matches** | PR gate + scripts described |
| `neon_sprawl_vision.plan.md` | **Partially matches** | Epic 2 title and E2.M1 note OK; E2.M2 could mention **grant channel** validation for parity with modules |
| `neon_sprawl_vision.plan.md` | **Matches** | Epic 2 title, E2.M1, E2.M2 **grant channel policy** bullet (**53fb1d6**) |
| `content/schemas/skill-def.schema.json` | **Matches** | Required fields + enum align with **E2.M1** |
| `content/skills/prototype_skills.json` | **Matches** | Three rows, distinct categories |
| `content/README.md` | **Matches** | Local validate instructions |
@ -45,7 +45,7 @@ None for **merge** from a **documentation correctness** standpoint.
## Suggestions
1. **`neon_sprawl_vision.plan.md`** — Optional one-line under **E2.M2**: reject **XP** grants whose **`sourceKind`** is not in the target skill’s **`allowedXpSourceKinds`** (mirrors module + schema descriptions).
1. ~~**`neon_sprawl_vision.plan.md`** — Optional one-line under **E2.M2**: reject **XP** grants whose **`sourceKind`** is not in the target skill’s **`allowedXpSourceKinds`** (mirrors module + schema descriptions).~~ **Done** (**53fb1d6**): **Grant channel policy** bullet under **E2.M2**.
## Nits