2.0 KiB
2.0 KiB
Manual QA — NEO-121 (quest telemetry hook sites)
Reference: implementation plan, NEO-117 implementation plan (quest operations), NEO-118 implementation plan (objective wiring).
Preconditions
- Run
NeonSprawl.Server(dotnet runfromserver/NeonSprawl.Server; defaulthttp://localhost:5253) if exercising Bruno; not required for code review only. - This story adds comments only; quest behavior matches NEO-117/118/119/120.
Code review check
- Open
server/NeonSprawl.Server/Game/Quests/QuestStateOperations.cs. - Confirm
quest_startcomment block immediately after successfulTryActivateinTryAccept(before objective wiring). - Confirm
quest_step_completecomment block after successfulTryAdvanceStepstore commit. - Confirm
quest_completecomment block after first-timeTryMarkCompletecommit (not on idempotentcompletedearly return). - Confirm
quest_accept_deniedcomment inDenyAccept(used by allTryAcceptdeny paths). - Confirm
TODO(E9.M1)markers and planned payload fields; no newILoggeror metrics calls. - Confirm no duplicate hook comments in
QuestAcceptApi,QuestProgressApi, orQuestObjectiveWiring. - Open server README — Quest telemetry hooks (NEO-121) — NEO-121 subsection present with event table.
Regression (optional)
cd server && dotnet test NeonSprawl.sln
Expect all tests pass (comments-only change).
Bruno (optional sanity)
From bruno/neon-sprawl-server/quest-progress/ against a running server:
- Get quest progress default — all quests
not_startedunchanged. - Post accept gather intro —
accepted: trueunchanged. - Post accept duplicate —
accepted: false,reasonCode: already_activeunchanged.