VinPropane
a36e7b56b5
NEO-137: Address review — quest fixture for Bruno CI and test/docs nits.
...
Add POST …/__dev/quest-fixture to mark quests completed without reward
delivery; wire Bruno pre-request and CI flag. Multi-rule AND unit test,
README notes, gate deny comment, review strikethroughs.
2026-06-15 21:24:21 -04:00
VinPropane
4ffc60f226
NEO-137: Add code review for faction gate operations branch.
2026-06-15 21:21:23 -04:00
VinPropane
0241cc31e3
NEO-137: Wire FactionGateOperations into quest accept with tests and docs.
...
Evaluate FactionGateRule rows before TryActivate; deny with faction_gate_blocked
when standing is below minStanding. Integration and Bruno deny smoke included.
2026-06-15 21:11:27 -04:00
VinPropane
1c3d075d6b
NEO-137: Add implementation plan for FactionGateOperations + TryAccept wiring.
2026-06-15 21:08:26 -04:00
VinPropane
ddaf33ce87
NEO-136: fix rollback applied delta and normalize ids at ops boundary
2026-06-15 20:52:04 -04:00
VinPropane
2117b2f8d3
NEO-136: add code review for ReputationOperations
2026-06-15 20:50:57 -04:00
VinPropane
536f635a11
NEO-136: document ReputationOperations and reconcile plan
2026-06-15 20:48:44 -04:00
VinPropane
e9abc8bf38
NEO-136: add implementation plan for ReputationOperations
2026-06-15 20:45:54 -04:00
VinPropane
d5f16f4cf4
NEO-135: address code review findings
...
Update decomposition docs for E7M3-03, add in-memory read-clamp test via
test seed hook, fix empty factionId deny code, AAA integration test,
Postgres FK orchestration notes, and strike review suggestions Done.
2026-06-15 20:27:36 -04:00
VinPropane
c066121c9d
NEO-135: add code review for faction standing stores
2026-06-15 20:25:35 -04:00
VinPropane
4fca45bf7c
NEO-135: add faction standing and reputation delta audit stores
...
Per-player IFactionStandingStore with clamped reads/writes and fail-closed
unknown-faction deny; append-only IReputationDeltaStore; in-memory plus
Postgres V009/V010 when configured. Tests, Bruno health smoke, README.
2026-06-15 20:23:57 -04:00
VinPropane
08ebfcebcf
NEO-135: add E7M3-03 faction standing store implementation plan
...
Kickoff plan for per-player FactionStanding snapshot and append-only
ReputationDelta audit stores (in-memory + NEO-116-style Postgres).
2026-06-15 20:20:48 -04:00
VinPropane
aa3eb3597c
NEO-134: address code review findings
...
Update decomposition tracking docs, add faction loader integration tests,
reorder standing-band gate before freeze, and guard success logging.
2026-06-15 20:11:55 -04:00
VinPropane
058799a595
NEO-134: add code review for E7M3-02 faction catalog load
2026-06-15 20:10:17 -04:00
VinPropane
48bca98467
NEO-134: fail-fast faction catalog load with E7M3 quest gates
...
Add Game/Factions loader, registry, and CI-parity prototype rules; extend
quest catalog to parse faction gates/rep grants and cross-check at startup.
2026-06-15 20:08:46 -04:00
VinPropane
edb33514c5
NEO-134: add E7M3-02 faction catalog load implementation plan
...
Kickoff plan for fail-fast server faction catalog load with CI-parity
gates, quest faction cross-refs, and registry DI wiring.
2026-06-15 20:03:44 -04:00
VinPropane
6cb7dfbb46
NEO-133: address code review — roster docs, CI cleanup, band gate
...
Cross-link E7.M1 doc to E7M3 five-quest roster; remove dead
_prototype_e7m1_quest_gate; add faction standing-band CI gate;
clarify server roster error strings; grid-contract loader test asserts.
2026-06-15 19:52:42 -04:00
VinPropane
92c078b0e3
NEO-133: Add code review for E7M3-01 catalog branch.
2026-06-15 19:51:42 -04:00
VinPropane
0948d9d4a8
NEO-133: land faction catalog, quest gate/rep schemas, and CI gates
...
Add two prototype factions, extend quest bundles with reputationGrants
and factionGateRules, freeze five-quest roster in validate_content.py,
and sync minimal server quest roster parity for green startup tests.
2026-06-14 14:54:20 -04:00
VinPropane
718346163f
NEO-133: kickoff E7M3-01 — faction catalog schemas + CI plan
...
Land E7.M3 Slice 3 decomposition docs and NEO-133 implementation plan
before content/schema work; blocks NEO-134 server faction load.
2026-06-14 14:51:22 -04:00
VinPropane
acf3d079d2
NEO-132: Move economy refresh into quest HUD controller for lint budget.
...
Pass inventory and skill clients into setup; refresh on completion
transition in quest_hud_controller.gd; fix line-length and file-size
gdlint limits for pre-push.
2026-06-14 14:15:46 -04:00
VinPropane
63156c353f
NEO-132: Ship Slice 2 quest reward capstone docs and economy refresh.
...
Add NEO-132 manual QA extending NEO-123 with reward HUD and economy
verification, README capstone section, E7.M2 Ready alignment, client
completion-transition signal for inventory/skill refresh, and GdUnit
coverage for the new signal.
2026-06-14 14:08:02 -04:00
VinPropane
a1947d8f05
NEO-132: Add kickoff implementation plan for E7M2 capstone.
...
Docs-primary Slice 2 capstone extending NEO-123 flow with reward HUD
and economy verification; conditional client refresh fixes if QA fails.
2026-06-14 14:06:30 -04:00
VinPropane
dc39250e96
NEO-131: Split reward HUD tests to satisfy gdlint limit.
2026-06-07 23:07:18 -04:00
VinPropane
7e3507088b
NEO-131: Fix Bugbot boot-seed and item-defs reward repaint.
...
Track in-session active quests so first successful GET after failed
syncs can paint rewards; repaint reward label on item definitions_ready.
2026-06-07 23:06:39 -04:00
VinPropane
0e13a10b79
NEO-131: Address review — item grant and defs repaint tests.
...
Add operator-chain item display name and definitions_ready reward
label GdUnit cases; add NEO-131 plan link to alignment register.
2026-06-07 23:02:14 -04:00
VinPropane
ca9a3f1b38
NEO-131: Add code review for quest completion reward HUD.
2026-06-07 23:01:27 -04:00
VinPropane
ed7975ca54
NEO-131: Document quest reward HUD and reconcile plan.
2026-06-07 22:59:19 -04:00
VinPropane
5578de9de3
NEO-131: Add kickoff implementation plan for quest reward HUD.
2026-06-07 22:57:23 -04:00
VinPropane
1333da2938
NEO-130: Address review feedback on unlock_granted stub.
...
Document E9.M1 durable-emit gating for rollback paths; reconcile plan
bullet for class summary; strike through resolved review items.
2026-06-07 22:49:00 -04:00
VinPropane
471d4b61a7
NEO-130: add code review for reward telemetry hook sites.
2026-06-07 22:48:12 -04:00
VinPropane
c461a822f1
NEO-130: Add comment-only reward telemetry hook sites.
...
Anchor future E9.M1 reward_delivery and unlock_granted events in
RewardRouterOperations; document hooks in server README and module docs.
2026-06-07 22:46:27 -04:00
VinPropane
7493a6b078
NEO-130: Add kickoff implementation plan for reward telemetry hooks.
2026-06-07 22:45:12 -04:00
VinPropane
9ab3a70796
NEO-129: address review test and Bruno coverage gaps.
2026-06-07 18:48:45 -04:00
VinPropane
185b38b242
NEO-129: add code review for quest-progress completionRewardSummary.
2026-06-07 18:40:05 -04:00
VinPropane
78e805e428
NEO-129: add completionRewardSummary to quest-progress GET.
...
Project IRewardDeliveryStore grant snapshots onto completed quest rows;
extend tests, Bruno gather-intro spine, and docs.
2026-06-07 18:38:37 -04:00
VinPropane
2b06eb2a1e
NEO-129: add implementation plan for quest-progress completionRewardSummary.
2026-06-07 18:37:35 -04:00
VinPropane
28e4a70846
NEO-128: address review — operator-chain delivery and wiring deny tests.
2026-06-07 18:27:10 -04:00
VinPropane
f3b4438968
NEO-128: add code review for quest-complete reward wiring.
2026-06-07 18:25:45 -04:00
VinPropane
da99769ddf
NEO-128: wire quest complete to reward router deliver-then-mark.
...
TryMarkComplete delivers completionRewardBundle before marking complete;
objective wiring and upstream ops thread reward dependencies. Tests cover
bundle delivery, idempotent replay, and inventory-full deny.
2026-06-07 18:24:01 -04:00
VinPropane
7abe7dcafd
NEO-128: add implementation plan for quest-complete reward wiring.
2026-06-07 18:18:58 -04:00
VinPropane
039672cdac
NEO-127: avoid clobbering winner perks on TryRecord race rollback
...
Track perks unlocked per grant and remove only those on race loss instead
of restoring a full pre-apply snapshot; re-run ReevaluateAfterLevelUp at
post-rollback levels so a concurrent winner's path-auto unlocks survive.
2026-06-07 18:10:56 -04:00
VinPropane
be9bb8f961
NEO-127: restore perk state on TryRecord race rollback
...
Capture pre-skill-apply XP and perk snapshots; on TryRecord loss reverse
each applied skill row via negative delta and restore the perk snapshot so
level-up unlocks from the loser call are reverted without clobbering a
concurrent winner's XP.
2026-06-07 18:04:06 -04:00
VinPropane
71fbf3d628
NEO-127: rollback duplicate grants when TryRecord loses race
...
Mirror EncounterCompletionOperations compensating rollback: concurrent
losers undo item and skill XP applies before returning the winner event.
2026-06-07 17:53:20 -04:00
VinPropane
c764f5af6b
NEO-127: update review summary after follow-up tests
2026-06-07 17:49:34 -04:00
VinPropane
65ca11171b
NEO-127: address code review test and backlog doc findings
...
Add null-bundle and invalid-id deny tests, fix replay XP assertion,
align E7M2-04 backlog wording with TryApplyGrant, strike review items done.
2026-06-07 17:49:26 -04:00
VinPropane
581c90ab34
NEO-127: add code review for reward router operations
2026-06-07 17:48:42 -04:00
VinPropane
5b84ffd75a
NEO-127: add RewardRouterOperations for quest completion bundles
...
Apply item grants and mission_reward skill XP with compensating rollback,
idempotent IRewardDeliveryStore recording, and AAA integration tests.
2026-06-07 17:47:32 -04:00
VinPropane
35b8904f15
NEO-127: add E7M2-04 reward router operations implementation plan
...
Kickoff plan for RewardRouterOperations apply path building on NEO-125
catalog bundles and NEO-126 delivery store idempotency.
2026-06-07 17:45:01 -04:00
VinPropane
35fa4ad192
NEO-126: address code review — module anchor and casing test
...
Add E7.M2 implementation anchor for the delivery store and assert
mixed-case TryRecord replays are rejected at the store layer.
2026-06-07 17:33:07 -04:00