don
/
neon-sprawl
mirror of https://github.com/ViPro-Technologies/neon-sprawl
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
1,180 Commits
3 Branches
0 Tags
322 MiB
Commit Graph

257 Commits (89affe2b320b3116f5c9bbbf72ac35e99593bb64)

Author SHA1 Message Date
VinPropane 89affe2b32 NEO-121: Add code review for quest telemetry hook sites. 2026-06-07 12:32:35 -04:00
VinPropane ea3b7cceb5 NEO-120: Address code review test coverage gaps. 
Add HTTP tests for already_completed deny snapshot and empty {} body;
tighten already_active AAA arrange. Strike through resolved review items.
 2026-06-07 12:21:19 -04:00
VinPropane 14bdec367c NEO-120: Add code review for quest accept POST branch. 2026-06-07 12:19:56 -04:00
VinPropane ad906fec40 NEO-119: Tighten quest-progress order and side-effect test coverage. 2026-06-07 12:10:55 -04:00
VinPropane 1565d2cde7 NEO-119: Add code review for quest-progress GET branch. 2026-06-07 12:09:57 -04:00
VinPropane 540257d12d NEO-117: Fix Bugbot deny-code misclassification on quest accept. 
Add CanWritePlayer to IPlayerQuestStateStore and check before
prerequisite gate; map TryActivate/TryAdvanceStep store failures
from progress snapshots instead of always unknown_player.
 2026-06-06 19:36:41 -04:00
VinPropane 025c3250d2 NEO-117: Address code review findings for QuestStateOperations. 
Align test DI resolution with encounter pattern, add unknown_quest
advance/complete tests, catalog quest id constants, refactor
TryMarkComplete readability, and update decomposition docs.
 2026-06-06 19:30:21 -04:00
VinPropane 84847e20f0 NEO-117: Add code review for QuestStateOperations branch. 2026-06-06 19:29:10 -04:00
VinPropane de611ac294 NEO-116: Address code review findings for quest state store. 
Fix persistence test AAA layout, empty-id denial theory, frozen id constants,
Postgres rollback/JSONB read, XML doc cref, README Bruno link, and review doc.
 2026-06-03 23:19:52 -04:00
VinPropane af87b5d12c NEO-116: Add code review for player quest state store. 2026-06-03 23:16:48 -04:00
VinPropane ab315f326b NEO-115: address code review findings for quest definitions GET. 
Derive expected quest id order from PrototypeE7M1QuestCatalogRules,
assert refine craft_recipe objective in integration test, and update
module dependency register plus review doc strikethroughs.
 2026-06-03 22:22:44 -04:00
VinPropane 31ffee1f7a NEO-115: add code review for quest definitions GET API. 2026-06-03 22:16:48 -04:00
VinPropane 5d302742f7 NEO-114: Address code review — backlog wording and empty-id test. 2026-06-01 21:49:57 -04:00
VinPropane b4e5e612d4 NEO-114: Add code review for quest definition registry. 2026-06-01 21:49:16 -04:00
VinPropane 9c2ab5ae4d NEO-113: address code review — docs, schema and chain terminal tests. 2026-05-31 22:36:26 -04:00
VinPropane 38310d6ed3 NEO-113: add code review for quest catalog load branch. 2026-05-31 22:35:26 -04:00
VinPropane a4ed4abadb NEO-112: enforce objective id uniqueness per quest in CI 
Move obj_ids_seen to quest scope so duplicate objective ids are
rejected across steps, matching CT.M1 documentation and E7M1-04
HTTP projection expectations (Bugbot PR #151).
 2026-05-31 21:23:45 -04:00
VinPropane 50956bac11 NEO-112: address code review doc alignment findings 2026-05-31 21:17:37 -04:00
VinPropane c55c373f7f NEO-112: add code review for QuestDef catalog + CI gates 2026-05-31 21:16:56 -04:00
VinPropane c8d475670c NEO-110: address review — loot label helper, defs re-paint, tests. 2026-05-31 19:38:07 -04:00
VinPropane 3ce645a0f0 NEO-110: code review — request changes for loot label helper. 2026-05-31 19:37:21 -04:00
VinPropane df248308c7 NEO-109: Restore early return on completion failure guard. 
Bugbot PR #148: keep consistent guard-clause pattern in
EncounterCombatWiring.TryProcessCastOutcome.
 2026-05-31 19:25:33 -04:00
VinPropane c40bcd3ffe NEO-109: Address code review hook-anchor findings. 
Move encounter_start comments after successful TryActivate; clarify
encounter_complete_denied caller context; strike through review items.
 2026-05-31 19:06:01 -04:00
VinPropane d1a67a89bd NEO-109: Add code review for encounter telemetry hook sites. 2026-05-31 19:04:55 -04:00
VinPropane 25f3714554 NEO-108: Address code review findings for encounter-progress GET. 
Add BuildSnapshot invariant tests, whitespace 404, idempotent second GET,
grant-order assertions; dedupe MapRow progress lookup; strike review items.
 2026-05-31 18:39:52 -04:00
VinPropane ebb27aed2d NEO-108: Add code review for encounter-progress GET. 2026-05-31 18:38:31 -04:00
VinPropane f51617f8b5 NEO-107: Address code review findings for event store persistence. 
Update E5.M3 module summary and NEO-105 snapshot, fix store test AAA
layout, add empty encounter id fail-closed test, strike through review items.
 2026-05-31 18:27:28 -04:00
VinPropane 29217c0fa0 NEO-107: Add code review for EncounterCompleteEvent persistence. 2026-05-31 18:26:51 -04:00
VinPropane 9c74933e6e NEO-106: Address code review findings for combat encounter wiring. 2026-05-31 18:10:41 -04:00
VinPropane a7b835290c NEO-106: Add code review for combat encounter wiring. 2026-05-31 18:09:20 -04:00
VinPropane cbb6f137fd NEO-105: Address code review findings for encounter completion. 
Add apply-phase rollback test, E9.M1 deny hook comment, inventory
reason passthrough, and tighten idempotent replay assertions.
 2026-05-31 17:02:32 -04:00
VinPropane 1a74fbda54 NEO-105: Add code review for encounter completion grants. 2026-05-31 16:59:46 -04:00
VinPropane 91f74b7d6e NEO-104: Address code review findings for encounter stores. 
Normalize encounter ids in IsAllRequiredTargetsDefeated, document TryActivate
completion gating, lock IsCompleted reads, add operations tests, and update
plan and review doc.
 2026-05-31 16:37:22 -04:00
VinPropane 87dff6e3f4 NEO-104: Add code review for encounter progress stores. 2026-05-31 16:36:42 -04:00
VinPropane e4e75f5dc7 NEO-103: Address code review follow-ups. 
Mark E5M3-04 landed in module Summary, assert fixedGrants order in
C# test, add Bruno ordinal comment, strike through review items.
 2026-05-31 15:43:37 -04:00
VinPropane 573c42add7 NEO-103: Add code review for encounter-definitions GET. 2026-05-31 15:41:49 -04:00
VinPropane ca0b1f8e30 NEO-102: tidy review doc documentation-checked row after follow-up 2026-05-31 00:40:39 -04:00
VinPropane 5229c17598 NEO-102: address code review — sync module register + README id lookup note 2026-05-31 00:40:37 -04:00
VinPropane fa31154d4c NEO-102: Add code review for encounter/reward registries + DI. 2026-05-31 00:39:18 -04:00
VinPropane 21749e7977 NEO-101: Address code review — schema tests, module snapshot, host boot. 
Adds row-level JsonSchema violation tests for both loaders, symmetric empty reward-tables host boot test, and E5.M3 implementation snapshot; review doc marked Done.
 2026-05-31 00:08:41 -04:00
VinPropane 5e26143fbd NEO-101: Add code review for encounter/reward catalog load. 2026-05-31 00:08:01 -04:00
VinPropane ebf385d658 NEO-100: Address code review — register sync and grant dedupe 
Update E5.M3 dependency register note for landed catalog, reject duplicate
fixedGrants itemId in CI, add uniqueItems on requiredNpcInstanceIds, and
record review follow-ups as Done.
 2026-05-30 19:38:33 -04:00
VinPropane 01b7e23c5e NEO-100: Add code review for encounter + reward catalog CI 2026-05-30 19:36:14 -04:00
VinPropane d7c3ede5a7 chore: Epic 5 stable slice anchors and doc cluster alignment 
Add explicit HTML slice anchors to epic_05, restore deep links across E5
backlogs and plans, fix E5M2 NEO-98 resolve vocabulary and E5.M3 Linear row,
and record review follow-up as Done.
 2026-05-30 19:25:56 -04:00
VinPropane b77b7f8fbb NEO-98: Address follow-up review doc findings. 
Update E5.M2 module freeze, plan scope reconciliation, alignment
register, client README melee row, and strike-through follow-up review.
 2026-05-30 18:02:55 -04:00
VinPropane bc1357cf94 NEO-98: add follow-up code review for capstone integration fixes 2026-05-30 18:01:52 -04:00
VinPropane b03128a3b0 NEO-98: address code review — Esc regression step and AC parity 2026-05-30 17:05:30 -04:00
VinPropane 817ed26304 NEO-98: add code review for E5M2-12 capstone docs 2026-05-30 17:04:18 -04:00
VinPropane fd0b6d3db8 NEO-97: address code review — helpers, tests, doc fixes 
Extract npc_combat_hud_helpers.gd for shared HUD formatters; hide telegraph
at zero windup; surface runtime sync errors; npc_row last-snapshot fallback;
expand GdUnit coverage; align E5.M2 module docs and strike review findings.
 2026-05-29 21:07:02 -04:00
VinPropane 39ec50efa2 NEO-97: add code review for E5M2-11 client telegraph HUD 2026-05-29 21:00:55 -04:00