VinPropane
28fcd52c8c
NEO-36: add curl example to manual QA checklist
2026-05-04 20:37:20 -04:00
VinPropane
ab597ff350
NEO-36: expose GET /game/world/skill-definitions with tests, Bruno, QA doc
2026-05-04 20:36:06 -04:00
VinPropane
044b4f823c
NEO-36: add implementation plan for skill catalog HTTP API
2026-05-04 20:33:53 -04:00
VinPropane
a5f7f1b4ae
Merge pull request #65 from ViPro-Technologies/chore/dotnet-workflow-all-prs-to-main
...
chore: Run .NET workflow on every PR to main
2026-05-04 20:27:27 -04:00
VinPropane
6b75fbdbd0
chore: grant pull-requests read for paths-filter API
2026-05-04 20:24:35 -04:00
VinPropane
0fd2dfe780
chore: skip .NET steps on PR when server paths unchanged
2026-05-04 20:21:18 -04:00
VinPropane
7b6d106240
chore: run .NET workflow on all PRs to main
2026-05-04 20:16:08 -04:00
VinPropane
efad0e51b2
Merge pull request #64 from ViPro-Technologies/NEO-35-e2m1-skilldefinition-registry
...
NEO-35: SkillDefinitionRegistry service + lookup tests
2026-05-04 19:55:09 -04:00
VinPropane
035e915934
NEO-35: address NEO-35 code review (AAA, docs, null id, cleanup)
2026-05-04 19:53:53 -04:00
VinPropane
fb863a457b
NEO-35: add ISkillDefinitionRegistry and lookup tests
2026-05-04 19:50:49 -04:00
VinPropane
c2ca511a35
NEO-35: add implementation plan for skill definition registry
2026-05-04 19:48:34 -04:00
VinPropane
ef745ae6a7
Merge pull request #63 from ViPro-Technologies/NEO-34-e2m1-skill-catalog-startup
...
NEO-34: Fail-fast skill catalog load at server startup
2026-05-02 19:54:23 -04:00
VinPropane
9da5e7dbf5
NEO-34: address code review follow-ups (docs, appsettings, AAA)
...
Update E2.M1 alignment table for landed catalog load; add Content placeholders
to appsettings.json; align implementation plan tests/appsettings notes; expand
manual QA header to project standard; strike review suggestions; tighten host
catalog test Arrange/Act/Assert.
2026-05-02 19:50:02 -04:00
VinPropane
922e81eb0f
NEO-34: add code review for skill catalog startup branch
2026-05-02 19:47:45 -04:00
VinPropane
1a9088c77c
NEO-34: fail-fast skill catalog load at server startup
...
Register SkillDefinitionCatalog from content/skills with JsonSchema.Net validation
mirroring validate_content.py and the prototype Slice 1 gate. Resolve paths via
Content:SkillsDirectory or discovery from AppContext.BaseDirectory. Eager-load
after WebApplication build so bad catalogs block startup. Add unit and host
tests, pin test factories to repo skills, document config in server/README, add
manual QA checklist, and extend Bruno GET /health smoke tests.
2026-05-02 19:44:10 -04:00
VinPropane
6344858541
NEO-34: add implementation plan for skill catalog startup load
2026-05-02 19:35:57 -04:00
VinPropane
7b307e503c
Merge pull request #62 from ViPro-Technologies/NEO-33-e2m1-lock-prototype-skilldef-trio-ci-catalog-contract
...
NEO-33: Lock prototype SkillDef trio + CI catalog contract
2026-05-02 19:32:06 -04:00
VinPropane
9afaad71ca
NEO-33: Apply code review feedback (validate_content, E2.M1)
2026-05-02 19:27:28 -04:00
VinPropane
02cb4d8556
NEO-33: Add code review document (2026-05-02)
2026-05-02 19:25:46 -04:00
VinPropane
583201cc7c
NEO-33: Freeze prototype SkillDef trio in CI and docs
2026-05-02 19:23:47 -04:00
VinPropane
66150ea224
NEO-33: Add implementation plan after kickoff clarifications
2026-05-02 19:21:20 -04:00
VinPropane
807812148f
Merge pull request #61 from ViPro-Technologies/chore/e2m1-decomposition-linear-docs
...
chore: Document E2.M1 module Linear backlog in decomposition
2026-04-30 22:42:45 -04:00
VinPropane
753f622602
chore: Document E2.M1 module Linear backlog in decomposition
2026-04-30 22:40:11 -04:00
VinPropane
ed89f8b1b1
Merge pull request #59 from ViPro-Technologies/NEO-32-cooldown-snapshot-sync-slot-presentation
...
NEO-32: CooldownSnapshot sync, cast guard, and optional API stdout
2026-04-30 22:06:48 -04:00
VinPropane
76fd1cc70a
NEO-32: gdformat main.gd; touch cooldown state tests
2026-04-30 22:06:15 -04:00
VinPropane
75eec11f0d
NEO-32: shorten test suite doc line for gdlint
2026-04-30 22:05:29 -04:00
VinPropane
ee953cbdfd
NEO-32: gdformat-style cast accept cooldown refresh
2026-04-30 22:05:22 -04:00
VinPropane
c83d8c8ed2
NEO-32: satisfy gdlint line length (pre-push)
2026-04-30 22:05:01 -04:00
VinPropane
cdf7c61ce4
NEO-32: defer review suggestion #1 (integration test AAA)
2026-04-30 22:04:11 -04:00
VinPropane
27daef70a7
NEO-32: commit Godot .uid companions; document convention for agents
2026-04-30 22:02:29 -04:00
VinPropane
7d64ed2adc
NEO-32: prune expired cooldown entries on TryGetCooldownEndUtc
2026-04-30 21:58:40 -04:00
VinPropane
7ddfb53219
NEO-32: add pre-merge code review (docs/reviews/2026-04-30-NEO-32.md)
2026-04-30 21:52:14 -04:00
VinPropane
56f7ae8a81
NEO-32: fix cooldown HUD anchor when serverTimeUtc parse fails
2026-04-30 21:45:25 -04:00
VinPropane
f4ba4cdd92
NEO-32: optional NEON_SPRAWL_API_LOG stdout for ability-cast
2026-04-30 21:37:03 -04:00
VinPropane
ae74f570dc
NEO-32: manual QA step 3 without server console logging
2026-04-30 21:33:08 -04:00
VinPropane
361a6800d2
NEO-32: cooldown snapshot API, on_cooldown deny, client HUD sync
2026-04-30 21:19:32 -04:00
VinPropane
b4b67bccfd
NEO-32: add implementation plan for cooldown snapshot sync
2026-04-30 21:13:17 -04:00
VinPropane
0790a3398d
Merge pull request #58 from ViPro-Technologies/NEO-30-cast-funnel-telemetry-hooks
...
NEO-30: Slice 3 cast funnel telemetry hook sites and docs
2026-04-30 21:09:28 -04:00
VinPropane
94cec78053
NEO-30: wrap telemetry doc comments for gdlint
2026-04-30 21:05:42 -04:00
VinPropane
8a9a9bcf78
NEO-30: address code review follow-ups
2026-04-30 21:04:31 -04:00
VinPropane
deec789af3
NEO-30: add code review for cast funnel telemetry hooks branch
2026-04-30 21:02:49 -04:00
VinPropane
b5478782a8
NEO-30: cast funnel telemetry hook sites and docs
2026-04-30 20:59:47 -04:00
VinPropane
0e95918b56
NEO-30: add implementation plan for cast funnel telemetry hooks
2026-04-30 20:53:47 -04:00
VinPropane
b91d0c8b65
Merge pull request #57 from ViPro-Technologies/NEO-28-combat-accept-deny-reason-ux
...
NEO-28: Cast accept/deny, target authority, client HUD, tests and docs
2026-04-27 22:21:27 -04:00
VinPropane
bbfa761aee
NEO-28: gdformat ability_cast_client_test.gd after connect() wrap.
2026-04-27 22:15:00 -04:00
VinPropane
0bce6ed74c
NEO-28: Wrap long lines for gdlint (ability cast + tests).
2026-04-27 22:14:47 -04:00
VinPropane
c3acbdb373
NEO-28: Add reviewability guideline; mark NEO-28 review suggestions done.
...
Document preferring separate branches/commits for mechanical test-only
churn vs ticket-scoped changes. Strike through resolved bullets in the
saved review file per project convention.
2026-04-27 22:13:11 -04:00
VinPropane
e6ccc4453c
chore: Apply Arrange/Act/Assert across server and client tests.
...
Split HTTP verification reads into Assert in C# API and integration tests.
Add # Arrange/# Act/# Assert to GdUnit suites and keep Act free of assertions
where casts and busy guards are under test.
2026-04-27 22:09:35 -04:00
VinPropane
7050bc12da
chore: AAA rules — no required blank line after phase comments
2026-04-27 21:54:02 -04:00
VinPropane
31f9b74d3f
chore: make AAA test layout mandatory in style rules and snippets
2026-04-27 21:52:39 -04:00
VinPropane