don
/
neon-sprawl
mirror of https://github.com/ViPro-Technologies/neon-sprawl
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
1,253 Commits
3 Branches
0 Tags
322 MiB
Commit Graph

283 Commits (1333da29384ed12eec6f5bcd586f3a6d6080086c)

Author SHA1 Message Date
VinPropane 1333da2938 NEO-130: Address review feedback on unlock_granted stub. 
Document E9.M1 durable-emit gating for rollback paths; reconcile plan
bullet for class summary; strike through resolved review items.
 2026-06-07 22:49:00 -04:00
VinPropane 471d4b61a7 NEO-130: add code review for reward telemetry hook sites. 2026-06-07 22:48:12 -04:00
VinPropane 9ab3a70796 NEO-129: address review test and Bruno coverage gaps. 2026-06-07 18:48:45 -04:00
VinPropane 185b38b242 NEO-129: add code review for quest-progress completionRewardSummary. 2026-06-07 18:40:05 -04:00
VinPropane 28e4a70846 NEO-128: address review — operator-chain delivery and wiring deny tests. 2026-06-07 18:27:10 -04:00
VinPropane f3b4438968 NEO-128: add code review for quest-complete reward wiring. 2026-06-07 18:25:45 -04:00
VinPropane 039672cdac NEO-127: avoid clobbering winner perks on TryRecord race rollback 
Track perks unlocked per grant and remove only those on race loss instead
of restoring a full pre-apply snapshot; re-run ReevaluateAfterLevelUp at
post-rollback levels so a concurrent winner's path-auto unlocks survive.
 2026-06-07 18:10:56 -04:00
VinPropane be9bb8f961 NEO-127: restore perk state on TryRecord race rollback 
Capture pre-skill-apply XP and perk snapshots; on TryRecord loss reverse
each applied skill row via negative delta and restore the perk snapshot so
level-up unlocks from the loser call are reverted without clobbering a
concurrent winner's XP.
 2026-06-07 18:04:06 -04:00
VinPropane c764f5af6b NEO-127: update review summary after follow-up tests 2026-06-07 17:49:34 -04:00
VinPropane 65ca11171b NEO-127: address code review test and backlog doc findings 
Add null-bundle and invalid-id deny tests, fix replay XP assertion,
align E7M2-04 backlog wording with TryApplyGrant, strike review items done.
 2026-06-07 17:49:26 -04:00
VinPropane 581c90ab34 NEO-127: add code review for reward router operations 2026-06-07 17:48:42 -04:00
VinPropane 35fa4ad192 NEO-126: address code review — module anchor and casing test 
Add E7.M2 implementation anchor for the delivery store and assert
mixed-case TryRecord replays are rejected at the store layer.
 2026-06-07 17:33:07 -04:00
VinPropane 3d8df939b6 NEO-126: add code review for reward delivery store 2026-06-07 17:32:37 -04:00
VinPropane 766837d7e8 NEO-125: address code review findings for bundle validation 
Rename freeze-first loader tests, add PrototypeE7M2QuestCatalogRulesTests
for cross-ref paths, align missing skill-def error with Python, and
document bundle schema path resolution in server README.
 2026-06-07 15:27:55 -04:00
VinPropane ad80ed8760 NEO-125: add code review for quest bundle catalog load 2026-06-07 15:26:51 -04:00
VinPropane d3c7dbb1ad NEO-124: Fix E7.M2 alignment register row and close review follow-up. 
Repair corrupted References column; document negative CI spot-check results in review.
 2026-06-07 15:17:24 -04:00
VinPropane fdd1fe1536 NEO-124: Add code review for quest completion bundle CI slice. 2026-06-07 15:16:34 -04:00
VinPropane bada3024c2 NEO-122: Repaint quest HUD when definitions load. 
Definitions ready now re-renders progress rows when a snapshot exists
even after a progress sync error, so display names replace raw ids.
 2026-06-07 14:52:01 -04:00
VinPropane c663721d34 NEO-122: Harden quest HUD error/accept rendering. 
Keep accept merge visible after sync failure, clear stale progress
error on successful accept, show sync banner with rows, and block
Shift+Q when definitions failed to load.
 2026-06-07 14:49:12 -04:00
VinPropane 91bdb18357 NEO-122: Keep quest HUD fresh after accept. 
Merge accept-response quest row into the HUD snapshot immediately,
re-apply when a stale GET returns not_started, and queue pending sync
when progress GET is already in flight.
 2026-06-07 14:45:56 -04:00
VinPropane 46e24d35d6 NEO-122: Fix bugbot items and GdUnit orphan leaks. 
Block Shift+Q when progress sync failed; remove HudRootScroll 80px min
that overlapped the economy panel; rewrite quest_hud_controller tests
with HTTP mocks and auto_free for CI exit 0.
 2026-06-07 14:42:18 -04:00
VinPropane ba75aeed79 NEO-122: Address follow-up review doc drift and QA numbering. 
Reconcile plan with economy HUD layout refactor, fix manual QA steps,
update regression notes for NEO-74/75/110, and strike through resolved
review suggestions.
 2026-06-07 13:36:21 -04:00
VinPropane 64da7611d9 NEO-122: Add follow-up code review for economy HUD layout. 2026-06-07 13:35:06 -04:00
VinPropane b36fe6d863 NEO-122: Address code review HUD error and test gaps. 
Surface quest-definitions sync failures on QuestProgressLabel, add accept
failure and busy-guard GdUnit coverage, inline render helper, and reconcile
review doc with strikethroughs.
 2026-06-07 12:45:47 -04:00
VinPropane 4e75ec6493 NEO-122: Add code review for quest progress HUD. 2026-06-07 12:44:35 -04:00
VinPropane 88d01778a1 NEO-121: Address review nits for quest telemetry hook sites. 
Add schemaVersion to quest_start comment, thread playerId/questId into
DenyAccept, and merge duplicate deny snapshot helpers.
 2026-06-07 12:33:34 -04:00
VinPropane 89affe2b32 NEO-121: Add code review for quest telemetry hook sites. 2026-06-07 12:32:35 -04:00
VinPropane ea3b7cceb5 NEO-120: Address code review test coverage gaps. 
Add HTTP tests for already_completed deny snapshot and empty {} body;
tighten already_active AAA arrange. Strike through resolved review items.
 2026-06-07 12:21:19 -04:00
VinPropane 14bdec367c NEO-120: Add code review for quest accept POST branch. 2026-06-07 12:19:56 -04:00
VinPropane ad906fec40 NEO-119: Tighten quest-progress order and side-effect test coverage. 2026-06-07 12:10:55 -04:00
VinPropane 1565d2cde7 NEO-119: Add code review for quest-progress GET branch. 2026-06-07 12:09:57 -04:00
VinPropane 540257d12d NEO-117: Fix Bugbot deny-code misclassification on quest accept. 
Add CanWritePlayer to IPlayerQuestStateStore and check before
prerequisite gate; map TryActivate/TryAdvanceStep store failures
from progress snapshots instead of always unknown_player.
 2026-06-06 19:36:41 -04:00
VinPropane 025c3250d2 NEO-117: Address code review findings for QuestStateOperations. 
Align test DI resolution with encounter pattern, add unknown_quest
advance/complete tests, catalog quest id constants, refactor
TryMarkComplete readability, and update decomposition docs.
 2026-06-06 19:30:21 -04:00
VinPropane 84847e20f0 NEO-117: Add code review for QuestStateOperations branch. 2026-06-06 19:29:10 -04:00
VinPropane de611ac294 NEO-116: Address code review findings for quest state store. 
Fix persistence test AAA layout, empty-id denial theory, frozen id constants,
Postgres rollback/JSONB read, XML doc cref, README Bruno link, and review doc.
 2026-06-03 23:19:52 -04:00
VinPropane af87b5d12c NEO-116: Add code review for player quest state store. 2026-06-03 23:16:48 -04:00
VinPropane ab315f326b NEO-115: address code review findings for quest definitions GET. 
Derive expected quest id order from PrototypeE7M1QuestCatalogRules,
assert refine craft_recipe objective in integration test, and update
module dependency register plus review doc strikethroughs.
 2026-06-03 22:22:44 -04:00
VinPropane 31ffee1f7a NEO-115: add code review for quest definitions GET API. 2026-06-03 22:16:48 -04:00
VinPropane 5d302742f7 NEO-114: Address code review — backlog wording and empty-id test. 2026-06-01 21:49:57 -04:00
VinPropane b4e5e612d4 NEO-114: Add code review for quest definition registry. 2026-06-01 21:49:16 -04:00
VinPropane 9c2ab5ae4d NEO-113: address code review — docs, schema and chain terminal tests. 2026-05-31 22:36:26 -04:00
VinPropane 38310d6ed3 NEO-113: add code review for quest catalog load branch. 2026-05-31 22:35:26 -04:00
VinPropane a4ed4abadb NEO-112: enforce objective id uniqueness per quest in CI 
Move obj_ids_seen to quest scope so duplicate objective ids are
rejected across steps, matching CT.M1 documentation and E7M1-04
HTTP projection expectations (Bugbot PR #151).
 2026-05-31 21:23:45 -04:00
VinPropane 50956bac11 NEO-112: address code review doc alignment findings 2026-05-31 21:17:37 -04:00
VinPropane c55c373f7f NEO-112: add code review for QuestDef catalog + CI gates 2026-05-31 21:16:56 -04:00
VinPropane c8d475670c NEO-110: address review — loot label helper, defs re-paint, tests. 2026-05-31 19:38:07 -04:00
VinPropane 3ce645a0f0 NEO-110: code review — request changes for loot label helper. 2026-05-31 19:37:21 -04:00
VinPropane df248308c7 NEO-109: Restore early return on completion failure guard. 
Bugbot PR #148: keep consistent guard-clause pattern in
EncounterCombatWiring.TryProcessCastOutcome.
 2026-05-31 19:25:33 -04:00
VinPropane c40bcd3ffe NEO-109: Address code review hook-anchor findings. 
Move encounter_start comments after successful TryActivate; clarify
encounter_complete_denied caller context; strike through review items.
 2026-05-31 19:06:01 -04:00
VinPropane d1a67a89bd NEO-109: Add code review for encounter telemetry hook sites. 2026-05-31 19:04:55 -04:00