don
/
neon-sprawl
mirror of https://github.com/ViPro-Technologies/neon-sprawl
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
1,438 Commits
3 Branches
0 Tags
322 MiB
Commit Graph

335 Commits (main)

Author SHA1 Message Date
VinPropane d96a83b6ef NEO-152: Address code review doc and alignment register nits. 
Add NEO-152 plan link to alignment footer; reconcile plan with
method-level CompensatingRevertAll anchor; strike review suggestions.
 2026-06-28 12:46:32 -04:00
VinPropane f665841ba2 NEO-152: Add code review for contract telemetry hook sites. 2026-06-28 12:39:25 -04:00
VinPropane d6ebc767e6 NEO-151: Fix Postgres ListForPlayer read race with single CTE query 
Bugbot: active and completed rows now load in one statement snapshot so
GET /contracts cannot return the same instance twice after completion.
 2026-06-28 11:17:21 -04:00
VinPropane 50df06a3f9 NEO-151: Fix Bruno helper path for collection-root scripts resolution 
Move reset-contract-instances-helper.js to neon-sprawl-server/scripts/
and fix encounter-clear bru requires so CI can resolve modules.
 2026-06-28 11:16:13 -04:00
VinPropane 5f2ab34fa2 NEO-151: Loop contract reset helper until capped GET is empty 
Bugbot: Bruno pre-request cleanup now clears all contract instances,
not just the first active + 10 completed page from GET /contracts.
 2026-06-28 11:07:47 -04:00
VinPropane 0888262f13 NEO-151: Address code review findings for contract HTTP API 
Return 404 for whitespace path on issue POST, add seed-field validation
tests, inline Postgres ListForPlayer active query, Postgres list test,
Bruno whitespace-path 404 check, and strike through resolved review items.
 2026-06-28 10:25:58 -04:00
VinPropane f6ef0a6227 NEO-151: Add code review for contract issue and list HTTP API 2026-06-28 10:23:31 -04:00
VinPropane 70e3e9a17d NEO-150: Address code review findings 
Extract ContractPrototypeTestFixtures, add skill XP over-cap test,
null-guard template, validation-order comment, and NEO-151 handoff note.
 2026-06-28 10:01:08 -04:00
VinPropane e3d8458a66 NEO-150: Add code review for economy validation at issue 2026-06-28 09:56:37 -04:00
VinPropane 299de3c796 chore: address cleanup review follow-ups and Postgres test flake 
Fix gig persistence integration flake with FakeTimeProvider on the Postgres
host, restore StringComparer.Ordinal on quest counter copies, remove the Bruno
docs block, and record resolved review items.
 2026-06-27 23:24:18 -04:00
VinPropane c5b8b7a726 NEO-149: re-review after code review follow-ups 2026-06-27 21:58:26 -04:00
VinPropane 68ba26724b NEO-149: address code review follow-ups 
Update E7.M4 alignment register, add quest-fixture contract reset
API test, align mark-complete deny codes with instance reason codes,
refactor idempotent replay test AAA, strike review findings done.
 2026-06-27 21:51:17 -04:00
VinPropane d1df940084 NEO-149: add code review for contract completion wiring 2026-06-27 21:50:13 -04:00
VinPropane 7268935bc7 NEO-148: address code review doc follow-ups 
Add E7.M4 alignment register entry, E7.M2 cross-ref, Postgres store-key
migration note, and defer contract fixture reset to NEO-149.
 2026-06-27 21:24:12 -04:00
VinPropane e75ac3932f NEO-148: add code review for contract reward router 2026-06-27 19:59:31 -04:00
VinPropane fbb248770f NEO-147: update decomposition tracking and strike review findings 2026-06-27 19:23:17 -04:00
VinPropane be0525b152 NEO-147: add code review for contract generator TryIssue 2026-06-27 19:21:24 -04:00
VinPropane b087c03a47 NEO-146: address re-review in-memory outcome guard parity 
InMemoryContractOutcomeStore checks IContractInstanceStore.TryGet before
append; add unit test, README/plan updates, and close r2 review items.
 2026-06-24 20:52:49 -04:00
VinPropane a9bc1acaa8 NEO-146: add re-review after cleanup and review follow-up 2026-06-24 20:51:04 -04:00
VinPropane 1922900477 NEO-146: address code review findings for contract stores 
Add Postgres race/deny tests, duplicate instance id coverage, FK-safe
outcome append, MakeInstanceKey locking, decomposition alignment updates,
and strike-through review doc.
 2026-06-24 20:37:16 -04:00
VinPropane be53d80705 NEO-146: add code review for contract instance and outcome stores 2026-06-24 20:35:16 -04:00
VinPropane 56bc22c70d NEO-145: address review findings — tests and decomposition docs. 
Rename cross-ref unit test; add loader freeze-overflow and missing-schema
negatives; update E7.M4/CT.M1 alignment tables and strike through review.
 2026-06-20 19:36:25 -04:00
VinPropane 1b904b594d NEO-145: add code review for contract catalog load branch. 2026-06-20 19:34:37 -04:00
VinPropane 9cfbf43936 NEO-144: reconcile plan and strike through review follow-ups 
Document band-cap constant naming, NEO-145 C# port note, and mark review items done.
 2026-06-20 19:22:02 -04:00
VinPropane fe9b706092 NEO-144: add code review for contract catalog CI slice 2026-06-20 19:21:01 -04:00
VinPropane ee918c5412 NEO-142: reconcile docs and close out code review findings 
Check off AC in plan/backlog; update E7.M3 module + alignment register;
strike through addressed review suggestions and nits.
 2026-06-17 21:16:17 -04:00
VinPropane 187ecc9c0d NEO-142: add code review for faction standing HUD branch 2026-06-17 21:14:49 -04:00
VinPropane b4d48f6e36 NEO-141: remove server-only manual QA doc after story end 
Comment-only infrastructure story — acceptance fully covered by dotnet
test; align with NEO-140 and planning-implementation-docs skip rule.
 2026-06-17 19:36:33 -04:00
VinPropane 0a4450a199 NEO-141: address review — backlog wording and class summary 
Align E7M3-09 in-scope bullet with ops-only hook anchors; pluralize
FactionGateOperations telemetry remark; mark review findings done.
 2026-06-17 19:27:27 -04:00
VinPropane cbd8444da3 NEO-141: add code review for faction telemetry hook sites 2026-06-17 19:26:54 -04:00
VinPropane ef75111b2a NEO-140: remove server-only manual QA doc after story end 
Manual QA checklists are for client-facing stories; Bruno and dotnet
test cover this HTTP projection slice.
 2026-06-17 19:21:48 -04:00
VinPropane 7011a56755 NEO-140: address code review — grid-contract rep and wire-level gate test 
Add integration coverage for +10 Rust Collective reputationGrants,
JsonDocument omission test for factionGateRules, extend accept Bruno,
fix manual QA link, strike through review findings.
 2026-06-17 19:12:33 -04:00
VinPropane 3ba2fd100c NEO-140: add code review for quest HTTP rep + gate projections 2026-06-17 19:11:03 -04:00
VinPropane 0fe182565e NEO-139: address review — trim-path tests and Bruno folder note. 
Add whitespace-only 404 and padded-path playerId echo tests; document seq 4 standing side effect in faction-standing folder docs.
 2026-06-16 17:26:40 -04:00
VinPropane cc7786ba3a NEO-139: add code review for faction-standing GET API. 2026-06-16 17:22:40 -04:00
VinPropane 6999eb3303 NEO-138: clear delivery and audit on quest fixture reset. 
resetQuestIds now clears IRewardDeliveryStore rows and quest-completion
audit deltas so Bruno re-runs re-apply rep grants after standing reset.
 2026-06-15 23:10:58 -04:00
VinPropane 57215d401a NEO-138: re-review confirms follow-ups addressed. 2026-06-15 22:31:29 -04:00
VinPropane 69c3ad4915 NEO-138: address code review follow-ups. 
Fix Bruno grid-contract status expectation, add race rep rollback and
multi-row audit-failure tests, audit-row assertion, and doc comments.
 2026-06-15 22:29:36 -04:00
VinPropane 245f0a84ed NEO-138: add code review for reward router reputation grants. 2026-06-15 22:22:06 -04:00
VinPropane 64920792ee chore: address Bruno self-reset review — README, Postgres test, nits. 
Document resetQuestIds, resource-node fixture, and cooldown clear in server README; add TryClearProgress Postgres integration test; sync-review doc and Bruno require paths.
 2026-06-15 21:53:44 -04:00
VinPropane a36e7b56b5 NEO-137: Address review — quest fixture for Bruno CI and test/docs nits. 
Add POST …/__dev/quest-fixture to mark quests completed without reward
delivery; wire Bruno pre-request and CI flag. Multi-rule AND unit test,
README notes, gate deny comment, review strikethroughs.
 2026-06-15 21:24:21 -04:00
VinPropane 4ffc60f226 NEO-137: Add code review for faction gate operations branch. 2026-06-15 21:21:23 -04:00
VinPropane ddaf33ce87 NEO-136: fix rollback applied delta and normalize ids at ops boundary 2026-06-15 20:52:04 -04:00
VinPropane 2117b2f8d3 NEO-136: add code review for ReputationOperations 2026-06-15 20:50:57 -04:00
VinPropane d5f16f4cf4 NEO-135: address code review findings 
Update decomposition docs for E7M3-03, add in-memory read-clamp test via
test seed hook, fix empty factionId deny code, AAA integration test,
Postgres FK orchestration notes, and strike review suggestions Done.
 2026-06-15 20:27:36 -04:00
VinPropane c066121c9d NEO-135: add code review for faction standing stores 2026-06-15 20:25:35 -04:00
VinPropane aa3eb3597c NEO-134: address code review findings 
Update decomposition tracking docs, add faction loader integration tests,
reorder standing-band gate before freeze, and guard success logging.
 2026-06-15 20:11:55 -04:00
VinPropane 058799a595 NEO-134: add code review for E7M3-02 faction catalog load 2026-06-15 20:10:17 -04:00
VinPropane 6cb7dfbb46 NEO-133: address code review — roster docs, CI cleanup, band gate 
Cross-link E7.M1 doc to E7M3 five-quest roster; remove dead
_prototype_e7m1_quest_gate; add faction standing-band CI gate;
clarify server roster error strings; grid-contract loader test asserts.
 2026-06-15 19:52:42 -04:00
VinPropane 92c078b0e3 NEO-133: Add code review for E7M3-01 catalog branch. 2026-06-15 19:51:42 -04:00