VinPropane
7466f2bcba
NEO-85: Add code review for client combat HUD.
2026-05-25 13:16:56 -04:00
VinPropane
faf3fe1139
NEO-85: Add manual QA, README, and module doc reconciliation.
...
Mark E5M1-11 acceptance complete in backlog and alignment register.
2026-05-25 13:15:59 -04:00
VinPropane
f03e689ce9
NEO-85: Add kickoff implementation plan for client combat HUD.
...
Documents event-driven combat-target refresh, CastFeedbackLabel resolution
copy, and dedicated CombatTargetHpLabel per kickoff clarifications.
2026-05-25 13:13:53 -04:00
VinPropane
3cbbcb6c2f
NEO-84: Address code review — register sync and hook comment parity.
...
Append NEO-44/NEO-84 to E5.M1 dependency register note, fix E2.M2 NEO-44
status, and add playerId correlation hint on damage-path ability_used hook.
2026-05-25 13:06:04 -04:00
VinPropane
e61ee333ee
NEO-84: Add code review for combat telemetry hook sites.
2026-05-25 13:05:08 -04:00
VinPropane
667a1a960a
NEO-84: Add combat telemetry hook sites in CombatOperations.
...
Comment-only ability_used, enemy_defeat, and reserved encounter_start/player_death
markers; README and module docs updated. All 407 server tests pass.
2026-05-25 13:04:11 -04:00
VinPropane
fb2bfe5614
NEO-84: Add kickoff implementation plan for combat telemetry hooks.
...
Documents engine-only comment hook sites in CombatOperations per kickoff clarifications.
2026-05-25 12:45:32 -04:00
VinPropane
32fbcec766
NEO-44: Fix Bruno defeat spine for CI collection order.
...
Reset prototype target HP before cast chain, use slot 2 to avoid
cooldown pollution, and assert +25 gig XP delta from baseline.
2026-05-25 12:14:29 -04:00
VinPropane
9d9b53332f
NEO-44: Address code review — docs, debug log, Bruno playerId.
...
Update E5.M1/E2.M2 module docs for gig XP path; LogDebug on failed
gig store write; Bruno defeat spine uses {{playerId}}; strike review items.
2026-05-25 12:08:21 -04:00
VinPropane
1e06b7174d
NEO-44: Add code review for gig XP on combat defeat.
2026-05-25 12:06:46 -04:00
VinPropane
71a6761f3c
NEO-44: Grant gig XP on combat defeat via dedicated store.
...
Add IPlayerGigProgressionStore (in-memory + Postgres V007), GET
/gig-progression snapshot, and CombatDefeatGigXpGrant on cast accept
when targetDefeated — 25 XP to breach, outside E2.M2 skill XP.
Includes tests, Bruno, README, manual QA, and plan reconciliation.
2026-05-25 12:04:40 -04:00
VinPropane
30d379c98c
NEO-44: Add kickoff implementation plan for gig XP on combat defeat.
...
Documents E5M1-10 scope: breach main gig, 25 XP per targetDefeated,
GET gig-progression snapshot, Postgres+in-memory store, and cast hook
after NEO-82 combat resolution — outside E2.M2 skill XP.
2026-05-25 12:01:48 -04:00
VinPropane
24eb355a26
NEO-83: Reconcile plan with code review Bruno follow-up.
...
Document one-pulse cast→GET smoke request and review-driven handler/test changes.
2026-05-25 11:23:41 -04:00
VinPropane
50a2c9ca9d
NEO-83: Address code review follow-ups for combat-targets GET.
...
Fail fast on health store TryGet miss, tighten one-pulse integration test assertions, add fast Bruno cast→GET smoke, update review doc.
2026-05-25 11:23:32 -04:00
VinPropane
aafa5e472a
NEO-83: Add code review for combat-targets GET snapshot.
2026-05-25 11:22:13 -04:00
VinPropane
52b1d4d206
NEO-83: Add GET /game/world/combat-targets HP snapshot.
...
Wire CombatTargetsWorldApi backed by ICombatEntityHealthStore, Bruno happy + cast defeat spine, integration tests, README and module tracking docs.
2026-05-25 11:20:13 -04:00
VinPropane
902e03848c
NEO-83: Add implementation plan for combat-targets GET snapshot.
...
Kickoff clarifications recorded; server-only scope with Bruno and API test coverage for authoritative HP reads.
2026-05-25 11:18:41 -04:00
VinPropane
71d93ee1fd
NEO-82: Note Bugbot fix in code review follow-up.
2026-05-25 11:05:02 -04:00
VinPropane
52bf9fc4bf
NEO-82: Fix cast definition lookup order and Bruno target isolation.
...
Load ability definition before TryResolve so cooldown lookup cannot deny
after HP mutation (Bugbot). Happy Bruno cast uses beta; defeat spine keeps
alpha; bump spine seq and cooldown sleep margin for CI.
2026-05-25 11:04:55 -04:00
VinPropane
322798b2ef
NEO-82: Address code review doc sync and test AAA follow-ups.
...
Update E5.M1 module doc, dependency register, and alignment table for
NEO-82 landed; Bruno defeat spine HP stepping; refactor four-pulse cast
test Arrange/Act/Assert; strike through resolved review items.
2026-05-25 10:45:31 -04:00
VinPropane
0b40ae3598
NEO-82: Add code review for cast combat wiring.
2026-05-25 10:44:02 -04:00
VinPropane
e8be100f80
NEO-82: Wire cast POST into combat engine and cast response.
...
Invoke CombatOperations.TryResolve after E1 gates; nested combatResolution
on accept; per-ability catalog cooldown; target_defeated deny without
cooldown. Tests, Bruno defeat spine, README and module docs updated.
2026-05-25 10:36:42 -04:00
VinPropane
4126ac9bcc
NEO-82: Add implementation plan for cast combat wiring.
...
Kickoff clarifications: nested combatResolution on accept, per-ability
cooldown on successful resolve only, no manual QA doc (server-only).
2026-05-25 10:32:33 -04:00
VinPropane
c7aa75ebc5
NEO-81: Address code review doc sync and test follow-ups.
...
Update module tracking and E5M1 backlog for NEO-81 landed; tighten AAA
in four-pulse test, add guard/dash deny parity and dash smoke test.
2026-05-25 10:20:09 -04:00
VinPropane
d63e448a08
NEO-81: Add code review for CombatOperations.TryResolve.
2026-05-25 10:18:28 -04:00
VinPropane
ca15e7a689
NEO-81: Add CombatOperations.TryResolve and CombatResult.
...
Pure server combat resolution applies catalog damage via the health store,
denies re-hits on defeated targets, and validates unknown ability/target ids.
2026-05-25 10:16:24 -04:00
VinPropane
849c34f460
NEO-81: Add implementation plan for CombatOperations.TryResolve.
2026-05-25 10:14:53 -04:00
VinPropane
bfb0eb9306
NEO-80: Address code review follow-ups for health store.
2026-05-24 22:42:33 -04:00
VinPropane
c3df7fc8d0
NEO-80: Add code review for combat entity health store.
2026-05-24 22:40:26 -04:00
VinPropane
b060b9dffd
NEO-80: add combat entity health store for prototype dummies.
...
Server-owned in-memory HP for prototype_target_alpha/beta with lazy
init at 100 HP, damage floor at zero, defeated flag, and DI registration.
2026-05-24 22:37:57 -04:00
VinPropane
e729996f47
NEO-80: add implementation plan for combat entity health store.
2026-05-24 22:35:37 -04:00
VinPropane
94b6c67b07
NEO-78: Address code review follow-ups for ability-definitions GET.
...
Update dependency register and E5M1 backlog, tighten tests and Bruno
spot-checks, strike through resolved review items.
2026-05-24 22:26:54 -04:00
VinPropane
8397e74ec1
NEO-78: Add code review for ability-definitions GET story.
2026-05-24 22:24:33 -04:00
VinPropane
44e0056b37
NEO-78: Add GET /game/world/ability-definitions HTTP projection.
...
Expose versioned read-only ability catalog via IAbilityDefinitionRegistry,
with integration tests, Bruno folder, and docs alignment.
2026-05-24 22:22:48 -04:00
VinPropane
374b4b5a53
NEO-78: Add kickoff implementation plan for ability-definitions GET.
2026-05-24 22:20:39 -04:00
VinPropane
0e5bbbff2e
NEO-79: Address code review — docs alignment, null-safe TryNormalizeKnown.
...
Update E5.M1 module page, dependency register, and alignment table for
NEO-79 landed; reconcile plan Bruno note; strike through review findings.
2026-05-24 22:07:37 -04:00
VinPropane
73d7708c7c
NEO-79: Add code review for ability registry DI story.
2026-05-24 22:06:26 -04:00
VinPropane
b9644a0453
NEO-79: Reconcile plan and E5M1 backlog for ability registry DI.
2026-05-24 22:05:27 -04:00
VinPropane
8bafec9d79
NEO-79: Add kickoff implementation plan for ability registry + DI.
2026-05-24 22:03:12 -04:00
VinPropane
fd2ffee089
NEO-77: Address code review — Bruno folder, E5M1 gate test, docs.
...
Add ability-catalog folder.bru, extra-id E5M1 gate AAA test, dependency
register NEO-77 note, and strike through resolved review suggestions.
2026-05-24 21:44:02 -04:00
VinPropane
42ea2598c3
NEO-77: Add code review for E5M1-02 server ability catalog load.
2026-05-24 21:42:44 -04:00
VinPropane
7c2697e4cc
NEO-77: Reconcile plan and module docs for E5M1-02 server load.
2026-05-24 21:40:58 -04:00
VinPropane
07444e45ce
NEO-77: Add E5M1-02 server ability catalog load kickoff plan.
2026-05-24 21:34:36 -04:00
VinPropane
866f962583
NEO-76: Fix review findings — duplicate ability row and docs.
...
Remove stray prototype_pulse from catalog; restore Epic 5 table layout,
align E5.M1 In Progress status, and close out code review doc.
2026-05-24 21:17:07 -04:00
VinPropane
6a71e9b6aa
NEO-76: add code review for ability catalog + CI branch.
2026-05-24 21:09:42 -04:00
VinPropane
9b11a521d8
NEO-76: Add prototype ability catalog, schema, and CI gates.
...
Freeze four AbilityDef rows in content with validate_content E5M1
allowlist; document freeze in E5.M1, content README, and CT.M1.
2026-05-24 21:08:16 -04:00
VinPropane
bafaacb963
NEO-76: Add E5M1-01 implementation plan for ability catalog + CI.
...
Lock four frozen AbilityDef rows, schema shape, validate_content gates,
and adopted prototype stat freeze before NEO-77 server load.
2026-05-24 21:06:32 -04:00
VinPropane
510d71113b
NEO-76: decompose E5.M1 prototype backlog (NEO-76–NEO-86, NEO-44).
...
Add full-stack Epic 5 Slice 1 story backlog with Linear issues, blockedBy
graph, and module/epic register cross-links.
2026-05-24 21:02:07 -04:00
VinPropane
7695527a79
NEO-75: address code review doc consistency findings
...
Update E3.M1/M3 status rows, epic Slice 5 completion note, README HUD
paths, E3S5-04 collapse AC, and strike through resolved review items.
2026-05-24 20:35:32 -04:00
VinPropane
cf0ef2d23e
NEO-75: add code review for capstone integration branch
2026-05-24 20:34:36 -04:00
VinPropane
977bcc3b27
NEO-75: capstone manual QA, README loop docs, alignment
...
Add zero-Bruno gather→refine→make checklist, end-to-end README section,
and mark Epic 3 Slice 5 client capstone complete in module docs.
2026-05-24 20:33:51 -04:00
VinPropane
fbae3148d2
NEO-75: add capstone implementation plan (kickoff)
...
Document gather→refine→make capstone scope, HUD collapse, manual QA
script, and module alignment per kickoff clarifications.
2026-05-24 20:32:18 -04:00
VinPropane
2fec42f8f6
NEO-74: Address code review — recipe sync HUD and test uids.
...
Wire recipes_sync_failed to CraftFeedbackLabel, remove unused _scroll
binding, add GdUnit .uid companions, extend recipe client HTTP error
test, strike through review items.
2026-05-24 19:59:00 -04:00
VinPropane
9b6abf093b
NEO-74: add code review for client craft UI branch.
2026-05-24 19:57:28 -04:00
VinPropane
c16b610468
NEO-74: Implement client craft UI, recipe list, and tests.
...
Add recipe-definitions and craft HTTP clients, scrollable recipe panel with
Craft buttons, CraftFeedbackLabel, refine skill HUD row, GdUnit coverage,
manual QA, and plan/module doc reconciliation.
2026-05-24 19:56:38 -04:00
VinPropane
dff58adfe8
NEO-74: Add kickoff implementation plan for client craft UI.
...
Documents E3S5-03 scope, kickoff HUD decisions, and file/test targets
for recipe list, craft POST client, and refine XP visibility.
2026-05-24 19:54:10 -04:00
VinPropane
07ca427f2f
NEO-73: preserve gather finalize across coalesced terminal POST.
...
Use awaiting-inventory flag so R-then-E still paints GatherFeedbackLabel
after inventory sync; only clear session on true orphans (Bugbot #107 ).
2026-05-24 19:42:39 -04:00
VinPropane
d0622701eb
NEO-73: clear orphaned gather pending on coalesced interact.
...
Track pending gather interactable id; drop flag when a different
interact completes (Bugbot PR #107 ). Add GdUnit coalescing test.
2026-05-24 19:24:00 -04:00
VinPropane
d6a80ed775
NEO-73: note review follow-up commit hash in review doc.
2026-05-24 19:09:38 -04:00
VinPropane
434226a069
NEO-73: address code review follow-ups.
...
Emit interaction_request_failed to clear stale gather pending flag;
add deny/HTTP failure tests; update alignment docs and review file.
2026-05-24 19:09:36 -04:00
VinPropane
6cd2c0cdda
NEO-73: add code review for client gather feedback branch.
2026-05-24 19:08:26 -04:00
VinPropane
adca7befe0
NEO-73: add manual QA and reconcile implementation plan.
...
Document gather HUD behavior in client README; mark E3S5-02 AC complete.
2026-05-24 19:07:22 -04:00
VinPropane
4682db48c4
NEO-73: add implementation plan for client gather feedback.
...
Kickoff clarifications: nearest in-range resource node on R, inventory
delta on GatherFeedbackLabel, SkillProgressionLabel for salvage XP.
2026-05-24 19:05:23 -04:00
VinPropane
ab670d0e26
NEO-72: mark review findings addressed in code review doc.
...
Strike through resolved blocking issue, suggestions, and consolidated nit.
2026-05-24 18:43:49 -04:00
VinPropane
e7a61a1b3f
NEO-72: fix HTTP client header types and strengthen tests.
...
Use PackedStringArray for request_completed headers so handlers run;
assert inventory payload shape and display_name_for after sync per review.
2026-05-24 18:43:39 -04:00
VinPropane
15fcc09493
NEO-72: Add code review for client inventory snapshot HUD.
2026-05-24 18:42:40 -04:00
VinPropane
8e44d81537
NEO-72: reconcile plan, E3S5 backlog, and module alignment docs.
...
Mark acceptance criteria complete and document landed client inventory HUD.
2026-05-24 18:41:24 -04:00
VinPropane
751fea3db4
NEO-72: add client inventory snapshot HUD and HTTP clients.
...
Wire GET inventory + item-definitions into InventoryLabel with I-key refresh,
displayName labels, and GdUnit coverage for happy/error paths.
2026-05-24 18:41:24 -04:00
VinPropane
1273296c73
NEO-72: add client inventory snapshot HUD implementation plan.
...
Kickoff clarifications locked displayName lookup, HUD+push_warning errors, and I-key refresh.
2026-05-24 18:37:44 -04:00
VinPropane
5f0f703555
NEO-71: address code review — CraftResult tense and README bullets
2026-05-24 18:32:08 -04:00
VinPropane
2be35c1640
NEO-71: Add code review for craft telemetry hook sites.
2026-05-24 18:30:46 -04:00
VinPropane
2d4751021b
NEO-71: add craft telemetry hook comment sites and docs
...
Place item_crafted and craft_failed TODO(E9.M1) anchors in
CraftOperations.TryCraft; document in server README and mark E3.M2
Slice 3 server backlog complete.
2026-05-24 18:23:35 -04:00
VinPropane
194078dd3b
NEO-71: add implementation plan for craft telemetry hook sites
2026-05-24 18:22:10 -04:00
VinPropane
5a3904c6bc
NEO-70: Address code review findings for craft HTTP.
...
Rename wire DTO to PlayerCraftRequest, add store-missing and default-quantity
API tests, improve Bruno deny isolation, README success sample, and doc nits.
2026-05-24 18:00:26 -04:00
VinPropane
9d6d358956
NEO-70: Add code review for craft HTTP + Bruno spine.
2026-05-24 17:59:04 -04:00
VinPropane
46393b8ca5
NEO-70: Add craft POST HTTP, Bruno spine, and docs.
...
Wire POST /game/players/{id}/craft to CraftOperations with CraftResponse DTOs,
integration tests, gather→refine→make Bruno folder, and module/README updates.
2026-05-24 17:57:55 -04:00
VinPropane
b148db8a61
NEO-70: Add implementation plan for craft HTTP + Bruno spine.
...
Kickoff clarifications: CraftResult-only wire response; no manual QA doc (Bruno + README).
2026-05-24 17:56:01 -04:00
VinPropane
c5115a3a13
NEO-69: Fix output-deny rollback order to prevent item loss.
...
Remove partial outputs before restoring inputs when output grant is
denied, matching StoreMissing and XP-failure compensating paths.
2026-05-24 17:33:27 -04:00
VinPropane
36adfd1897
NEO-69: Fix Bugbot pre-flight and output rollback issues.
...
Simulate input removal before output capacity checks, roll back partial
outputs on store-missing, and add tests for slot-freeing craft success.
2026-05-24 17:28:43 -04:00
VinPropane
51e9f1f5d0
NEO-69: Address code review findings for craft engine.
...
Fix AAA test layout, add batch quantity and simulate-add tests, restore
partial input rollback, and bump E3.M2 register status to In Progress.
2026-05-24 17:18:52 -04:00
VinPropane
b381cadf23
NEO-69: Add code review for craft engine implementation.
2026-05-24 17:17:48 -04:00
VinPropane
308de6b50d
NEO-69: Document craft engine and mark E3M2-05 acceptance complete.
...
Updates server README, module snapshot, alignment register, and backlog
after CraftOperations lands with full automated test coverage.
2026-05-24 17:17:01 -04:00
VinPropane
bba1415d54
NEO-69: Add craft engine implementation plan.
...
Kickoff plan for CraftOperations/CraftResult with pre-flight output
checks, refine XP grant, and unit test coverage before NEO-70 HTTP.
2026-05-24 17:14:44 -04:00
VinPropane
529cb616f5
NEO-68: Update docs and strike through code review findings.
...
Mark E3M2-04 landed, refresh alignment register and README, reconcile plan AC.
2026-05-24 17:08:18 -04:00
VinPropane
1636fdc2cb
NEO-68: Add GET /game/world/recipe-definitions HTTP projection.
...
Wire RecipeDefinitionsWorldApi over IRecipeDefinitionRegistry with schema v1
DTOs, Bruno folder, manual QA, and FrozenEightInIdOrder integration test.
2026-05-24 17:08:15 -04:00
VinPropane
8eccb14898
NEO-68: Add code review for kickoff implementation plan.
2026-05-24 17:06:38 -04:00
VinPropane
6de6a1781f
NEO-68: Add kickoff implementation plan for recipe-definitions GET.
...
Documents scope, DTO shape, tests, Bruno, and manual QA after kickoff clarifications.
2026-05-24 17:05:34 -04:00
VinPropane
95d42803e1
NEO-67: address code review nits on recipe registry
...
Delegate TryGetDefinition to catalog.TryGetRecipe, cache ordered defs at
construction, and assert unknown recipeId in host DI test.
2026-05-24 16:58:38 -04:00
VinPropane
2fc3b8f750
NEO-67: Add code review for recipe definition registry + DI.
2026-05-24 16:58:00 -04:00
VinPropane
81b0e3fc4b
NEO-67: add IRecipeDefinitionRegistry and DI adapter
...
Thin registry over RecipeDefinitionCatalog mirrors NEO-52/59: TryGetDefinition,
GetDefinitionsInIdOrder, AAA unit/host tests, README and alignment doc updates.
2026-05-24 16:57:17 -04:00
VinPropane
7188c5b558
NEO-67: add implementation plan for recipe definition registry
2026-05-24 16:56:06 -04:00
VinPropane
1fb4368a2c
NEO-66: Address code review follow-ups for recipe catalog load.
...
Pin Content:RecipesDirectory in all host test factories, add loader tests
for empty dir/invalid JSON/unknown output itemId, document manual QA skip.
2026-05-24 16:45:36 -04:00
VinPropane
c279eed572
NEO-66: Add code review for recipe catalog fail-fast load.
2026-05-24 16:43:49 -04:00
VinPropane
f209636e7e
NEO-66: Fail-fast server recipe catalog load at startup.
...
Add Game/Crafting loader, Slice 3 gate rules, DI registration, and AAA tests
mirroring item/resource-node catalog patterns; cross-check item and skill ids.
2026-05-24 16:41:48 -04:00
VinPropane
ccf4cf8e5c
NEO-66: Add implementation plan for recipe catalog load.
...
Kickoff plan for fail-fast server startup load of content/recipes with
CI-parity validation; strict split defers IRecipeDefinitionRegistry to NEO-67.
2026-05-24 16:38:40 -04:00
VinPropane
d4a4795eb1
NEO-65: Address code review doc alignment and NEO-66 sync note.
...
Bump E3.M2 module status to In Progress with NEO-65 snapshot; add
PROTOTYPE_SLICE3_RECIPE_IDS kickoff reminder for E3M2-02; strike through
resolved review suggestions.
2026-05-24 16:25:49 -04:00
VinPropane
966c54ac74
NEO-65: Add code review for RecipeDef catalog + CI.
2026-05-24 16:23:25 -04:00
VinPropane
b4f27b4a18
NEO-65: Document recipe catalog CI and mark E3M2-01 complete.
...
Update CT.M1 PR gate, E3.M2 freeze rules, alignment register, and backlog
checkboxes after prototype recipe validation lands.
2026-05-24 16:21:46 -04:00
VinPropane
b4b8536081
chore: codify full-stack epic decomposition policy
...
Add alwaysApply rule, prototype backlog template, epic template updates,
and review/kickoff gates so player-visible slices require client Linear
issues and Godot verification—not Bruno-only deferrals.
2026-05-24 16:19:32 -04:00
VinPropane
2cd17e293a
chore: Epic 3 Slice 5 client backlog and full-stack epic policy
...
Add E3S5-client-prototype-backlog (NEO-72–NEO-75), epic_03 Slice 5,
full-stack epics rule in decomposition README, and cross-links from
E3 module docs and prototype backlogs.
2026-05-24 16:16:51 -04:00