don
/
neon-sprawl
mirror of https://github.com/ViPro-Technologies/neon-sprawl
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
999 Commits
3 Branches
0 Tags
322 MiB
Commit Graph

205 Commits (fa3d48a6aab7b54bf1cbd202a2cd2ebc56174c19)

Author SHA1 Message Date
VinPropane 07ca427f2f NEO-73: preserve gather finalize across coalesced terminal POST. 
Use awaiting-inventory flag so R-then-E still paints GatherFeedbackLabel
after inventory sync; only clear session on true orphans (Bugbot #107).
 2026-05-24 19:42:39 -04:00
VinPropane d0622701eb NEO-73: clear orphaned gather pending on coalesced interact. 
Track pending gather interactable id; drop flag when a different
interact completes (Bugbot PR #107). Add GdUnit coalescing test.
 2026-05-24 19:24:00 -04:00
VinPropane d6a80ed775 NEO-73: note review follow-up commit hash in review doc. 2026-05-24 19:09:38 -04:00
VinPropane 434226a069 NEO-73: address code review follow-ups. 
Emit interaction_request_failed to clear stale gather pending flag;
add deny/HTTP failure tests; update alignment docs and review file.
 2026-05-24 19:09:36 -04:00
VinPropane 6cd2c0cdda NEO-73: add code review for client gather feedback branch. 2026-05-24 19:08:26 -04:00
VinPropane ab670d0e26 NEO-72: mark review findings addressed in code review doc. 
Strike through resolved blocking issue, suggestions, and consolidated nit.
 2026-05-24 18:43:49 -04:00
VinPropane 15fcc09493 NEO-72: Add code review for client inventory snapshot HUD. 2026-05-24 18:42:40 -04:00
VinPropane 5f0f703555 NEO-71: address code review — CraftResult tense and README bullets 2026-05-24 18:32:08 -04:00
VinPropane 2be35c1640 NEO-71: Add code review for craft telemetry hook sites. 2026-05-24 18:30:46 -04:00
VinPropane 5a3904c6bc NEO-70: Address code review findings for craft HTTP. 
Rename wire DTO to PlayerCraftRequest, add store-missing and default-quantity
API tests, improve Bruno deny isolation, README success sample, and doc nits.
 2026-05-24 18:00:26 -04:00
VinPropane 9d6d358956 NEO-70: Add code review for craft HTTP + Bruno spine. 2026-05-24 17:59:04 -04:00
VinPropane c5115a3a13 NEO-69: Fix output-deny rollback order to prevent item loss. 
Remove partial outputs before restoring inputs when output grant is
denied, matching StoreMissing and XP-failure compensating paths.
 2026-05-24 17:33:27 -04:00
VinPropane 36adfd1897 NEO-69: Fix Bugbot pre-flight and output rollback issues. 
Simulate input removal before output capacity checks, roll back partial
outputs on store-missing, and add tests for slot-freeing craft success.
 2026-05-24 17:28:43 -04:00
VinPropane 51e9f1f5d0 NEO-69: Address code review findings for craft engine. 
Fix AAA test layout, add batch quantity and simulate-add tests, restore
partial input rollback, and bump E3.M2 register status to In Progress.
 2026-05-24 17:18:52 -04:00
VinPropane b381cadf23 NEO-69: Add code review for craft engine implementation. 2026-05-24 17:17:48 -04:00
VinPropane 529cb616f5 NEO-68: Update docs and strike through code review findings. 
Mark E3M2-04 landed, refresh alignment register and README, reconcile plan AC.
 2026-05-24 17:08:18 -04:00
VinPropane 8eccb14898 NEO-68: Add code review for kickoff implementation plan. 2026-05-24 17:06:38 -04:00
VinPropane 95d42803e1 NEO-67: address code review nits on recipe registry 
Delegate TryGetDefinition to catalog.TryGetRecipe, cache ordered defs at
construction, and assert unknown recipeId in host DI test.
 2026-05-24 16:58:38 -04:00
VinPropane 2fc3b8f750 NEO-67: Add code review for recipe definition registry + DI. 2026-05-24 16:58:00 -04:00
VinPropane 1fb4368a2c NEO-66: Address code review follow-ups for recipe catalog load. 
Pin Content:RecipesDirectory in all host test factories, add loader tests
for empty dir/invalid JSON/unknown output itemId, document manual QA skip.
 2026-05-24 16:45:36 -04:00
VinPropane c279eed572 NEO-66: Add code review for recipe catalog fail-fast load. 2026-05-24 16:43:49 -04:00
VinPropane d4a4795eb1 NEO-65: Address code review doc alignment and NEO-66 sync note. 
Bump E3.M2 module status to In Progress with NEO-65 snapshot; add
PROTOTYPE_SLICE3_RECIPE_IDS kickoff reminder for E3M2-02; strike through
resolved review suggestions.
 2026-05-24 16:25:49 -04:00
VinPropane 966c54ac74 NEO-65: Add code review for RecipeDef catalog + CI. 2026-05-24 16:23:25 -04:00
VinPropane a578d9b684 NEO-64: address code review follow-ups. 
Nest gather_node_depleted hook in remainingGathers == 0 guard,
add E3M1-08 deny-branch out-of-scope note, and give README NEO-64
its own subsection anchor.
 2026-05-24 16:00:02 -04:00
VinPropane 1bcaa1b350 NEO-64: add code review document. 2026-05-24 15:59:16 -04:00
VinPropane 3834b2316a NEO-63: address code review follow-ups. 
AAA depletion test layout, source_kind_not_allowed assertion,
HTTP inventory_full deny test, trim duplicate XP test, doc comments.
 2026-05-24 15:46:20 -04:00
VinPropane 35381ad749 NEO-63: add code review document. 2026-05-24 15:45:13 -04:00
VinPropane 0cc5bb8925 NEO-61: address code review follow-ups. 
Fix AAA layout in depletion tests, add ResourceNodeInstanceIds.Normalize,
throw on failed lazy-init after catalog hit, and update dependency register
footnote plus review doc strikethroughs.
 2026-05-24 15:15:25 -04:00
VinPropane 0dfbe769e7 NEO-61: add code review document. 2026-05-24 15:13:51 -04:00
VinPropane 2b66df86b8 NEO-60: address code review — register footnote and Bruno comment 
Extend E3.M1 dependency register note with NEO-57–NEO-60 landed slices;
add StringComparer.Ordinal comment to Bruno ordinal test for parity.
 2026-05-24 14:49:15 -04:00
VinPropane b60920b2e2 NEO-60: add code review document 2026-05-24 14:48:16 -04:00
VinPropane 1e1ca5519c NEO-59: address code review follow-ups 
Simplify GetDefinitionsInIdOrder to iterate key-value pairs directly,
avoiding the intermediate sorted-keys array and second dictionary lookup.
 2026-05-24 14:31:20 -04:00
VinPropane dc66b5cef4 NEO-59: add code review document 2026-05-24 14:29:46 -04:00
VinPropane 44fc8d7b62 NEO-58: address code review follow-ups 
Document optional Bruno smoke in plan; add empty-catalog file loader tests;
tighten host DI test AAA; strike through resolved review items.
 2026-05-24 14:04:42 -04:00
VinPropane 6656853473 NEO-58: add code review for resource-node catalog load 2026-05-24 14:03:19 -04:00
VinPropane f0a4183598 NEO-57: close review follow-ups on E3M1 backlog and review doc 
Clarify two-file yield layout in backlog; mark review suggestions
resolved and verdict Approve.
 2026-05-24 13:54:36 -04:00
VinPropane ca1a15fce1 NEO-57: align E3M1 backlog with landed content + review follow-ups 
Mark E3M1-01 acceptance complete, document resource-yield-row schema
choice, and strike through resolved review suggestions.
 2026-05-24 13:53:25 -04:00
VinPropane 2584947953 NEO-57: add code review for resource node content + CI 2026-05-24 13:53:04 -04:00
VinPropane deed0c4314 NEO-56: address code review follow-ups 
Extend E3.M3 dependency register footnote; expand post-mutation deny hook
comments; clarify Deny payload at call sites; strike review items Done.
 2026-05-24 13:40:12 -04:00
VinPropane b8e0cce582 NEO-56: add code review for inventory telemetry hook sites 2026-05-24 13:33:39 -04:00
VinPropane fddbb95a45 NEO-55: address code review suggestions for inventory HTTP 
Add remove round-trip and invalid_quantity API tests, Bruno remove request,
dependency register NEO-55 footnote, and strike-through review follow-ups.
 2026-05-23 22:51:59 -04:00
VinPropane d127de7bbb NEO-55: add code review for inventory GET/POST HTTP and Bruno. 2026-05-23 22:49:31 -04:00
VinPropane ac3900c194 NEO-54: address code review suggestions for inventory tests and docs 2026-05-23 19:31:26 -04:00
VinPropane 362608ed5f NEO-54: add code review for inventory store and rules engine. 2026-05-23 19:29:37 -04:00
VinPropane 52590fa749 NEO-53: address code review suggestions 
Register footnote NEO-53, Bruno exact id-order test, test indent fix,
review doc strikethroughs.
 2026-05-23 19:12:20 -04:00
VinPropane 68c4980e42 NEO-53: Add code review for item-definitions HTTP + Bruno. 2026-05-23 19:11:28 -04:00
VinPropane 0d904527ac NEO-52: address code review doc suggestions for registry 
Add NEO-52 registry bullet to E3.M3 module doc, extend dependency
register footnote, and mark review suggestions done.
 2026-05-23 18:17:27 -04:00
VinPropane 7bd4064b93 NEO-52: Add code review for item definition registry + DI. 2026-05-23 18:16:17 -04:00
VinPropane 38f0c56711 NEO-51: Address code review — tests, docs, review strikethroughs. 
Add Slice 1 role/stackMax and missing-path loader tests; E3.M3 server
load bullet; register footnote; host test temp-dir cleanup.
 2026-05-17 22:04:03 -04:00
VinPropane 1c9c93513e NEO-51: Add code review for item catalog fail-fast load. 2026-05-17 22:01:47 -04:00
VinPropane 0ce952131a NEO-50: Address review — equip_stub gate by role, backlog sync. 2026-05-17 21:29:32 -04:00
VinPropane 8fa828daa0 NEO-50: Add code review — Approve for prototype item catalog + CI. 2026-05-17 21:27:59 -04:00
VinPropane e9c02eded7 NEO-48: mark review items resolved — Approve verdict 2026-05-17 20:38:02 -04:00
VinPropane aba26446d3 NEO-48: address r2 review — atomic fixture, tests, docs 
Batch skillXp then resetPerkState with XP rollback; 400 for invalid skillXp;
MasteryFixtureApi gate tests; README fixture vs grant semantics; Bruno GET playerId.
 2026-05-17 20:37:00 -04:00
VinPropane 2bb02d76e9 NEO-48: add re-review for mastery fixture testing refactor 2026-05-17 20:34:36 -04:00
VinPropane 3ba8300652 NEO-48: address code review — Bruno deny, API deny tests 
Add self-contained branch_already_chosen Bruno request, HTTP deny smoke
for unknown track/tier/branch and null-body 400, folder docs for level_too_low.
 2026-05-17 20:21:42 -04:00
VinPropane 0838e661c9 NEO-48: add code review for perk-state HTTP 2026-05-17 20:16:46 -04:00
VinPropane 5058bc1963 NEO-49: address code review follow-ups for telemetry hooks 2026-05-17 19:21:21 -04:00
VinPropane 7ce9dc172c NEO-49: add code review for perk_unlock telemetry hooks 2026-05-17 19:15:17 -04:00
VinPropane 76e710b491 NEO-47: re-review — follow-ups verified, approve for merge 2026-05-17 18:46:25 -04:00
VinPropane 0a2a6fe45b NEO-47: address code review follow-ups for perk unlock engine 
Retroactive path-auto unlock on branch pick, unlock rollback, CanWritePlayer
gate, expanded deny tests, gather-hook smoke, decomposition docs, review strikethroughs.
 2026-05-17 18:45:11 -04:00
VinPropane 2520a80b6e NEO-47: add code review for perk unlock engine 2026-05-17 18:42:28 -04:00
VinPropane 07fc566e2c NEO-46: address code review follow-up. 
Add loader deny-path and registry enumeration tests, tierIndex 1..N gate
in validate_content.py, E2.M3 handoff doc update, and review strikethroughs.
 2026-05-17 18:12:39 -04:00
VinPropane 594287c199 NEO-45: address docs review suggestions for E2.M3 Slice 4. 
Expand data contract and NEO-46 handoff, gigs.md gig-mastery clarification,
acceptance footnote, and mark docs review items Done.
 2026-05-17 13:16:49 -04:00
VinPropane 4a9730c577 NEO-45: address code review doc alignment and CI nits. 
Align E2.M3 In Progress status, backlog checkboxes, perks map doc;
reject unreferenced PerkDef rows; tier-2 branch displayNames; review Done.
 2026-05-16 20:05:51 -04:00
VinPropane f5f04d8258 NEO-45: lock prototype salvage mastery catalog, schemas, and CI. 
Add mastery JSON schema and salvage-only Slice 4 catalog with tier/branch
freeze; extend validate_content.py for skillId, perkId, and branch gates;
update E2.M3 decomposition, content README, and implementation plan.
 2026-05-16 19:50:09 -04:00
VinPropane 0b16de6d6f NEO-43: close code review doc follow-ups (alignment + E7 status) 2026-05-15 20:36:08 -04:00
VinPropane caa400f43d NEO-42: address review — decomposition docs, plan AC, grant helper, test assert 2026-05-10 19:46:49 -04:00
VinPropane 29a6c6d1a7 NEO-41: address code review (E3.M1 status, deny-path test) 2026-05-10 19:13:56 -04:00
VinPropane 05abc47111 NEO-41: add code review for gather XP branch 2026-05-10 19:11:56 -04:00
VinPropane 35b666ed60 NEO-40: sync E2.M2 alignment doc; close review feedback 2026-05-10 18:54:17 -04:00
VinPropane aaffaa7f1d NEO-40: add code review for telemetry hook sites branch 2026-05-10 18:52:33 -04:00
VinPropane 236040a5c2 NEO-39: add data-driven level curve with startup schema validation 
Replace placeholder XP level math with content-backed thresholds validated in CI and at server boot, and update docs/manual QA/review artifacts to reflect NEO-39 delivery and follow-up fixes.
 2026-05-06 23:10:06 -04:00
VinPropane b2999f3ed9 NEO-38: address review — docs alignment, Bruno deny, README levelUps trim 2026-05-06 22:26:23 -04:00
VinPropane 9ed4034140 NEO-38: add code review (2026-05-06) 2026-05-06 22:24:17 -04:00
VinPropane c58e716669 chore: smoke-test path-filtered CI skip (docs-only whitespace) 2026-05-06 22:04:39 -04:00
VinPropane a89aadbb43 NEO-37: re-review notes for unordered skills contract update 2026-05-06 21:54:13 -04:00
VinPropane a3cbef063c NEO-37: treat skill progression JSON array order as non-contractual 2026-05-06 21:53:24 -04:00
VinPropane 295eb34c68 NEO-37: reconcile decomposition docs + review feedback 2026-05-06 21:51:44 -04:00
VinPropane 5e180f3aa0 NEO-37: code review snapshot for skill progression API branch 2026-05-06 21:50:37 -04:00
VinPropane e2e413f42c docs: address 2026-04-30 documentation review suggestions 2026-05-04 21:09:05 -04:00
VinPropane f67bae79d8 chore: add 2026-05-04 documentation review 2026-05-04 21:06:51 -04:00
VinPropane a0c3599525 NEO-36: address code review (manual QA header, alignment, README, Bruno) 2026-05-04 20:44:52 -04:00
VinPropane 035e915934 NEO-35: address NEO-35 code review (AAA, docs, null id, cleanup) 2026-05-04 19:53:53 -04:00
VinPropane 9da5e7dbf5 NEO-34: address code review follow-ups (docs, appsettings, AAA) 
Update E2.M1 alignment table for landed catalog load; add Content placeholders
to appsettings.json; align implementation plan tests/appsettings notes; expand
manual QA header to project standard; strike review suggestions; tighten host
catalog test Arrange/Act/Assert.
 2026-05-02 19:50:02 -04:00
VinPropane 922e81eb0f NEO-34: add code review for skill catalog startup branch 2026-05-02 19:47:45 -04:00
VinPropane 9afaad71ca NEO-33: Apply code review feedback (validate_content, E2.M1) 2026-05-02 19:27:28 -04:00
VinPropane 02cb4d8556 NEO-33: Add code review document (2026-05-02) 2026-05-02 19:25:46 -04:00
VinPropane cdf7c61ce4 NEO-32: defer review suggestion #1 (integration test AAA) 2026-04-30 22:04:11 -04:00
VinPropane 27daef70a7 NEO-32: commit Godot .uid companions; document convention for agents 2026-04-30 22:02:29 -04:00
VinPropane 7d64ed2adc NEO-32: prune expired cooldown entries on TryGetCooldownEndUtc 2026-04-30 21:58:40 -04:00
VinPropane 7ddfb53219 NEO-32: add pre-merge code review (docs/reviews/2026-04-30-NEO-32.md) 2026-04-30 21:52:14 -04:00
VinPropane 8a9a9bcf78 NEO-30: address code review follow-ups 2026-04-30 21:04:31 -04:00
VinPropane deec789af3 NEO-30: add code review for cast funnel telemetry hooks branch 2026-04-30 21:02:49 -04:00
VinPropane c3acbdb373 NEO-28: Add reviewability guideline; mark NEO-28 review suggestions done. 
Document preferring separate branches/commits for mechanical test-only
churn vs ticket-scoped changes. Strike through resolved bullets in the
saved review file per project convention.
 2026-04-27 22:13:11 -04:00
VinPropane 479d1e1806 NEO-31: Bruno collection metadata, cast script UIDs, review verification notes 2026-04-27 20:50:53 -04:00
VinPropane af1fdef816 NEO-31: single authority mirror for hotbar and ability cast clients 2026-04-27 20:45:48 -04:00
VinPropane cc1c6f711e NEO-31: request_cast bool for telemetry hook; document cast API in server README 2026-04-27 20:44:40 -04:00
VinPropane e88e59f3a6 NEO-31: hotbar cast resolver tests, doc alignment, review follow-up 2026-04-27 20:42:36 -04:00
VinPropane 9ac4f27ea2 NEO-29: resolve follow-up review regressions 
Fix the hotbar client test transport body construction so the suite parses and runs again, and normalize AAA marker ordering in the flagged C# tests to restore readability consistency with the test template.
 2026-04-25 23:26:25 -04:00