VinPropane
a578d9b684
NEO-64: address code review follow-ups.
...
Nest gather_node_depleted hook in remainingGathers == 0 guard,
add E3M1-08 deny-branch out-of-scope note, and give README NEO-64
its own subsection anchor.
2026-05-24 16:00:02 -04:00
VinPropane
847cda97a3
NEO-64: add gather telemetry hook sites and doc updates.
...
Comment-only resource_gathered and gather_node_depleted anchors in
GatherOperations.TryGather; README, module docs, manual QA, and E3.M1
backlog marked complete.
2026-05-24 15:58:29 -04:00
VinPropane
3834b2316a
NEO-63: address code review follow-ups.
...
AAA depletion test layout, source_kind_not_allowed assertion,
HTTP inventory_full deny test, trim duplicate XP test, doc comments.
2026-05-24 15:46:20 -04:00
VinPropane
f23af01687
NEO-62: add GatherOperations engine and tests.
...
Orchestrates inventory grant, salvage XP, and depletion commit
with compensating rollback on XP failure.
2026-05-24 15:41:26 -04:00
VinPropane
5dac6b2825
NEO-61: fix null snapshot on depletion deny path.
...
Check TryGetRemainingGathers return before using the out snapshot;
default struct had null InteractableId and threw on .Length.
2026-05-24 15:21:37 -04:00
VinPropane
0cc5bb8925
NEO-61: address code review follow-ups.
...
Fix AAA layout in depletion tests, add ResourceNodeInstanceIds.Normalize,
throw on failed lazy-init after catalog hit, and update dependency register
footnote plus review doc strikethroughs.
2026-05-24 15:15:25 -04:00
VinPropane
6d2d3c040a
NEO-61: add world node instance depletion store.
...
Split IResourceNodeInstanceStore + ResourceNodeInstanceOperations with
lazy init from catalog maxGathers, atomic decrement, node_depleted and
unknown_node reason codes, V006 Postgres migration, and parity tests.
2026-05-24 15:03:05 -04:00
VinPropane
97f8f31682
NEO-60: add GET /game/world/resource-node-definitions endpoint
...
Versioned read-only projection backed by IResourceNodeDefinitionRegistry
with nested yield DTOs, integration test, Bruno, manual QA, and docs.
2026-05-24 14:47:23 -04:00
VinPropane
1e1ca5519c
NEO-59: address code review follow-ups
...
Simplify GetDefinitionsInIdOrder to iterate key-value pairs directly,
avoiding the intermediate sorted-keys array and second dictionary lookup.
2026-05-24 14:31:20 -04:00
VinPropane
bd43951f80
NEO-59: add IResourceNodeDefinitionRegistry and DI adapter
...
Thin registry over ResourceNodeCatalog with node/yield lookup,
enumeration, and AAA unit + host DI tests mirroring NEO-52.
2026-05-24 14:26:23 -04:00
VinPropane
0384b63046
NEO-58: add fail-fast resource-node catalog load at startup
...
Loader, Slice 2 gates, DI registration, AAA tests, README and plan updates.
Cross-checks yield itemIds against ItemDefinitionCatalog loaded first.
2026-05-24 14:01:29 -04:00
VinPropane