VinPropane
ba776b9b33
NEO-88: Address code review doc gaps for E5.M2 tracking.
...
Extend module register E5.M2 note and freeze Rules with NEO-88 server
startup enforcement; strike through resolved review suggestions.
2026-05-25 17:11:22 -04:00
VinPropane
3ad8581411
NEO-88: Add code review for NPC behavior catalog load branch.
2026-05-25 17:10:31 -04:00
VinPropane
ba31d8c420
NEO-87: note review follow-up commit SHA on blocking fix.
2026-05-25 16:56:16 -04:00
VinPropane
24cbd9baa8
NEO-87: restore elite NPC behavior row and close review findings.
...
Add missing prototype_elite_mini_boss catalog entry so the E5M2
three-id CI gate passes; strike through resolved review items.
2026-05-25 16:56:12 -04:00
VinPropane
033d8f6cfa
NEO-87: Add code review for NPC behavior catalog branch.
2026-05-25 16:54:43 -04:00
VinPropane
8d4c048bbe
NEO-86: Address code review test gaps and doc alignment.
...
Promote E5.M1 to Ready in alignment register, fix NEO-85 README link,
add schema-mismatch and deny-path GdUnit cases; strike review suggestions.
2026-05-25 14:01:54 -04:00
VinPropane
d5fc648dd6
NEO-86: Add code review for combat capstone branch.
2026-05-25 14:00:53 -04:00
VinPropane
504d3228dd
NEO-85: Address code review doc sync and 404 test gap.
...
Update module dependency register and E5.M1 related-slices entry for
NEO-85 landed; add combat-targets HTTP 404 GdUnit case; strike review suggestions.
2026-05-25 13:17:47 -04:00
VinPropane
7466f2bcba
NEO-85: Add code review for client combat HUD.
2026-05-25 13:16:56 -04:00
VinPropane
3cbbcb6c2f
NEO-84: Address code review — register sync and hook comment parity.
...
Append NEO-44/NEO-84 to E5.M1 dependency register note, fix E2.M2 NEO-44
status, and add playerId correlation hint on damage-path ability_used hook.
2026-05-25 13:06:04 -04:00
VinPropane
e61ee333ee
NEO-84: Add code review for combat telemetry hook sites.
2026-05-25 13:05:08 -04:00
VinPropane
9d9b53332f
NEO-44: Address code review — docs, debug log, Bruno playerId.
...
Update E5.M1/E2.M2 module docs for gig XP path; LogDebug on failed
gig store write; Bruno defeat spine uses {{playerId}}; strike review items.
2026-05-25 12:08:21 -04:00
VinPropane
1e06b7174d
NEO-44: Add code review for gig XP on combat defeat.
2026-05-25 12:06:46 -04:00
VinPropane
50a2c9ca9d
NEO-83: Address code review follow-ups for combat-targets GET.
...
Fail fast on health store TryGet miss, tighten one-pulse integration test assertions, add fast Bruno cast→GET smoke, update review doc.
2026-05-25 11:23:32 -04:00
VinPropane
aafa5e472a
NEO-83: Add code review for combat-targets GET snapshot.
2026-05-25 11:22:13 -04:00
VinPropane
71d93ee1fd
NEO-82: Note Bugbot fix in code review follow-up.
2026-05-25 11:05:02 -04:00
VinPropane
52bf9fc4bf
NEO-82: Fix cast definition lookup order and Bruno target isolation.
...
Load ability definition before TryResolve so cooldown lookup cannot deny
after HP mutation (Bugbot). Happy Bruno cast uses beta; defeat spine keeps
alpha; bump spine seq and cooldown sleep margin for CI.
2026-05-25 11:04:55 -04:00
VinPropane
322798b2ef
NEO-82: Address code review doc sync and test AAA follow-ups.
...
Update E5.M1 module doc, dependency register, and alignment table for
NEO-82 landed; Bruno defeat spine HP stepping; refactor four-pulse cast
test Arrange/Act/Assert; strike through resolved review items.
2026-05-25 10:45:31 -04:00
VinPropane
0b40ae3598
NEO-82: Add code review for cast combat wiring.
2026-05-25 10:44:02 -04:00
VinPropane
c7aa75ebc5
NEO-81: Address code review doc sync and test follow-ups.
...
Update module tracking and E5M1 backlog for NEO-81 landed; tighten AAA
in four-pulse test, add guard/dash deny parity and dash smoke test.
2026-05-25 10:20:09 -04:00
VinPropane
d63e448a08
NEO-81: Add code review for CombatOperations.TryResolve.
2026-05-25 10:18:28 -04:00
VinPropane
bfb0eb9306
NEO-80: Address code review follow-ups for health store.
2026-05-24 22:42:33 -04:00
VinPropane
c3df7fc8d0
NEO-80: Add code review for combat entity health store.
2026-05-24 22:40:26 -04:00
VinPropane
94b6c67b07
NEO-78: Address code review follow-ups for ability-definitions GET.
...
Update dependency register and E5M1 backlog, tighten tests and Bruno
spot-checks, strike through resolved review items.
2026-05-24 22:26:54 -04:00
VinPropane
8397e74ec1
NEO-78: Add code review for ability-definitions GET story.
2026-05-24 22:24:33 -04:00
VinPropane
0e5bbbff2e
NEO-79: Address code review — docs alignment, null-safe TryNormalizeKnown.
...
Update E5.M1 module page, dependency register, and alignment table for
NEO-79 landed; reconcile plan Bruno note; strike through review findings.
2026-05-24 22:07:37 -04:00
VinPropane
73d7708c7c
NEO-79: Add code review for ability registry DI story.
2026-05-24 22:06:26 -04:00
VinPropane
fd2ffee089
NEO-77: Address code review — Bruno folder, E5M1 gate test, docs.
...
Add ability-catalog folder.bru, extra-id E5M1 gate AAA test, dependency
register NEO-77 note, and strike through resolved review suggestions.
2026-05-24 21:44:02 -04:00
VinPropane
42ea2598c3
NEO-77: Add code review for E5M1-02 server ability catalog load.
2026-05-24 21:42:44 -04:00
VinPropane
866f962583
NEO-76: Fix review findings — duplicate ability row and docs.
...
Remove stray prototype_pulse from catalog; restore Epic 5 table layout,
align E5.M1 In Progress status, and close out code review doc.
2026-05-24 21:17:07 -04:00
VinPropane
6a71e9b6aa
NEO-76: add code review for ability catalog + CI branch.
2026-05-24 21:09:42 -04:00
VinPropane
7695527a79
NEO-75: address code review doc consistency findings
...
Update E3.M1/M3 status rows, epic Slice 5 completion note, README HUD
paths, E3S5-04 collapse AC, and strike through resolved review items.
2026-05-24 20:35:32 -04:00
VinPropane
cf0ef2d23e
NEO-75: add code review for capstone integration branch
2026-05-24 20:34:36 -04:00
VinPropane
2fec42f8f6
NEO-74: Address code review — recipe sync HUD and test uids.
...
Wire recipes_sync_failed to CraftFeedbackLabel, remove unused _scroll
binding, add GdUnit .uid companions, extend recipe client HTTP error
test, strike through review items.
2026-05-24 19:59:00 -04:00
VinPropane
9b6abf093b
NEO-74: add code review for client craft UI branch.
2026-05-24 19:57:28 -04:00
VinPropane
07ca427f2f
NEO-73: preserve gather finalize across coalesced terminal POST.
...
Use awaiting-inventory flag so R-then-E still paints GatherFeedbackLabel
after inventory sync; only clear session on true orphans (Bugbot #107 ).
2026-05-24 19:42:39 -04:00
VinPropane
d0622701eb
NEO-73: clear orphaned gather pending on coalesced interact.
...
Track pending gather interactable id; drop flag when a different
interact completes (Bugbot PR #107 ). Add GdUnit coalescing test.
2026-05-24 19:24:00 -04:00
VinPropane
d6a80ed775
NEO-73: note review follow-up commit hash in review doc.
2026-05-24 19:09:38 -04:00
VinPropane
434226a069
NEO-73: address code review follow-ups.
...
Emit interaction_request_failed to clear stale gather pending flag;
add deny/HTTP failure tests; update alignment docs and review file.
2026-05-24 19:09:36 -04:00
VinPropane
6cd2c0cdda
NEO-73: add code review for client gather feedback branch.
2026-05-24 19:08:26 -04:00
VinPropane
ab670d0e26
NEO-72: mark review findings addressed in code review doc.
...
Strike through resolved blocking issue, suggestions, and consolidated nit.
2026-05-24 18:43:49 -04:00
VinPropane
15fcc09493
NEO-72: Add code review for client inventory snapshot HUD.
2026-05-24 18:42:40 -04:00
VinPropane
5f0f703555
NEO-71: address code review — CraftResult tense and README bullets
2026-05-24 18:32:08 -04:00
VinPropane
2be35c1640
NEO-71: Add code review for craft telemetry hook sites.
2026-05-24 18:30:46 -04:00
VinPropane
5a3904c6bc
NEO-70: Address code review findings for craft HTTP.
...
Rename wire DTO to PlayerCraftRequest, add store-missing and default-quantity
API tests, improve Bruno deny isolation, README success sample, and doc nits.
2026-05-24 18:00:26 -04:00
VinPropane
9d6d358956
NEO-70: Add code review for craft HTTP + Bruno spine.
2026-05-24 17:59:04 -04:00
VinPropane
c5115a3a13
NEO-69: Fix output-deny rollback order to prevent item loss.
...
Remove partial outputs before restoring inputs when output grant is
denied, matching StoreMissing and XP-failure compensating paths.
2026-05-24 17:33:27 -04:00
VinPropane
36adfd1897
NEO-69: Fix Bugbot pre-flight and output rollback issues.
...
Simulate input removal before output capacity checks, roll back partial
outputs on store-missing, and add tests for slot-freeing craft success.
2026-05-24 17:28:43 -04:00
VinPropane
51e9f1f5d0
NEO-69: Address code review findings for craft engine.
...
Fix AAA test layout, add batch quantity and simulate-add tests, restore
partial input rollback, and bump E3.M2 register status to In Progress.
2026-05-24 17:18:52 -04:00
VinPropane
b381cadf23
NEO-69: Add code review for craft engine implementation.
2026-05-24 17:17:48 -04:00