don
/
neon-sprawl
mirror of https://github.com/ViPro-Technologies/neon-sprawl
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
779 Commits
3 Branches
0 Tags
322 MiB
Commit Graph

140 Commits (529cb616f571684bee3b2a024100276db12aa2e2)

Author SHA1 Message Date
VinPropane 529cb616f5 NEO-68: Update docs and strike through code review findings. 
Mark E3M2-04 landed, refresh alignment register and README, reconcile plan AC.
 2026-05-24 17:08:18 -04:00
VinPropane 8eccb14898 NEO-68: Add code review for kickoff implementation plan. 2026-05-24 17:06:38 -04:00
VinPropane 95d42803e1 NEO-67: address code review nits on recipe registry 
Delegate TryGetDefinition to catalog.TryGetRecipe, cache ordered defs at
construction, and assert unknown recipeId in host DI test.
 2026-05-24 16:58:38 -04:00
VinPropane 2fc3b8f750 NEO-67: Add code review for recipe definition registry + DI. 2026-05-24 16:58:00 -04:00
VinPropane 1fb4368a2c NEO-66: Address code review follow-ups for recipe catalog load. 
Pin Content:RecipesDirectory in all host test factories, add loader tests
for empty dir/invalid JSON/unknown output itemId, document manual QA skip.
 2026-05-24 16:45:36 -04:00
VinPropane c279eed572 NEO-66: Add code review for recipe catalog fail-fast load. 2026-05-24 16:43:49 -04:00
VinPropane d4a4795eb1 NEO-65: Address code review doc alignment and NEO-66 sync note. 
Bump E3.M2 module status to In Progress with NEO-65 snapshot; add
PROTOTYPE_SLICE3_RECIPE_IDS kickoff reminder for E3M2-02; strike through
resolved review suggestions.
 2026-05-24 16:25:49 -04:00
VinPropane 966c54ac74 NEO-65: Add code review for RecipeDef catalog + CI. 2026-05-24 16:23:25 -04:00
VinPropane a578d9b684 NEO-64: address code review follow-ups. 
Nest gather_node_depleted hook in remainingGathers == 0 guard,
add E3M1-08 deny-branch out-of-scope note, and give README NEO-64
its own subsection anchor.
 2026-05-24 16:00:02 -04:00
VinPropane 1bcaa1b350 NEO-64: add code review document. 2026-05-24 15:59:16 -04:00
VinPropane 3834b2316a NEO-63: address code review follow-ups. 
AAA depletion test layout, source_kind_not_allowed assertion,
HTTP inventory_full deny test, trim duplicate XP test, doc comments.
 2026-05-24 15:46:20 -04:00
VinPropane 35381ad749 NEO-63: add code review document. 2026-05-24 15:45:13 -04:00
VinPropane 0cc5bb8925 NEO-61: address code review follow-ups. 
Fix AAA layout in depletion tests, add ResourceNodeInstanceIds.Normalize,
throw on failed lazy-init after catalog hit, and update dependency register
footnote plus review doc strikethroughs.
 2026-05-24 15:15:25 -04:00
VinPropane 0dfbe769e7 NEO-61: add code review document. 2026-05-24 15:13:51 -04:00
VinPropane 2b66df86b8 NEO-60: address code review — register footnote and Bruno comment 
Extend E3.M1 dependency register note with NEO-57–NEO-60 landed slices;
add StringComparer.Ordinal comment to Bruno ordinal test for parity.
 2026-05-24 14:49:15 -04:00
VinPropane b60920b2e2 NEO-60: add code review document 2026-05-24 14:48:16 -04:00
VinPropane 1e1ca5519c NEO-59: address code review follow-ups 
Simplify GetDefinitionsInIdOrder to iterate key-value pairs directly,
avoiding the intermediate sorted-keys array and second dictionary lookup.
 2026-05-24 14:31:20 -04:00
VinPropane dc66b5cef4 NEO-59: add code review document 2026-05-24 14:29:46 -04:00
VinPropane 44fc8d7b62 NEO-58: address code review follow-ups 
Document optional Bruno smoke in plan; add empty-catalog file loader tests;
tighten host DI test AAA; strike through resolved review items.
 2026-05-24 14:04:42 -04:00
VinPropane 6656853473 NEO-58: add code review for resource-node catalog load 2026-05-24 14:03:19 -04:00
VinPropane f0a4183598 NEO-57: close review follow-ups on E3M1 backlog and review doc 
Clarify two-file yield layout in backlog; mark review suggestions
resolved and verdict Approve.
 2026-05-24 13:54:36 -04:00
VinPropane ca1a15fce1 NEO-57: align E3M1 backlog with landed content + review follow-ups 
Mark E3M1-01 acceptance complete, document resource-yield-row schema
choice, and strike through resolved review suggestions.
 2026-05-24 13:53:25 -04:00
VinPropane 2584947953 NEO-57: add code review for resource node content + CI 2026-05-24 13:53:04 -04:00
VinPropane deed0c4314 NEO-56: address code review follow-ups 
Extend E3.M3 dependency register footnote; expand post-mutation deny hook
comments; clarify Deny payload at call sites; strike review items Done.
 2026-05-24 13:40:12 -04:00
VinPropane b8e0cce582 NEO-56: add code review for inventory telemetry hook sites 2026-05-24 13:33:39 -04:00
VinPropane fddbb95a45 NEO-55: address code review suggestions for inventory HTTP 
Add remove round-trip and invalid_quantity API tests, Bruno remove request,
dependency register NEO-55 footnote, and strike-through review follow-ups.
 2026-05-23 22:51:59 -04:00
VinPropane d127de7bbb NEO-55: add code review for inventory GET/POST HTTP and Bruno. 2026-05-23 22:49:31 -04:00
VinPropane ac3900c194 NEO-54: address code review suggestions for inventory tests and docs 2026-05-23 19:31:26 -04:00
VinPropane 362608ed5f NEO-54: add code review for inventory store and rules engine. 2026-05-23 19:29:37 -04:00
VinPropane 52590fa749 NEO-53: address code review suggestions 
Register footnote NEO-53, Bruno exact id-order test, test indent fix,
review doc strikethroughs.
 2026-05-23 19:12:20 -04:00
VinPropane 68c4980e42 NEO-53: Add code review for item-definitions HTTP + Bruno. 2026-05-23 19:11:28 -04:00
VinPropane 0d904527ac NEO-52: address code review doc suggestions for registry 
Add NEO-52 registry bullet to E3.M3 module doc, extend dependency
register footnote, and mark review suggestions done.
 2026-05-23 18:17:27 -04:00
VinPropane 7bd4064b93 NEO-52: Add code review for item definition registry + DI. 2026-05-23 18:16:17 -04:00
VinPropane 38f0c56711 NEO-51: Address code review — tests, docs, review strikethroughs. 
Add Slice 1 role/stackMax and missing-path loader tests; E3.M3 server
load bullet; register footnote; host test temp-dir cleanup.
 2026-05-17 22:04:03 -04:00
VinPropane 1c9c93513e NEO-51: Add code review for item catalog fail-fast load. 2026-05-17 22:01:47 -04:00
VinPropane 0ce952131a NEO-50: Address review — equip_stub gate by role, backlog sync. 2026-05-17 21:29:32 -04:00
VinPropane 8fa828daa0 NEO-50: Add code review — Approve for prototype item catalog + CI. 2026-05-17 21:27:59 -04:00
VinPropane e9c02eded7 NEO-48: mark review items resolved — Approve verdict 2026-05-17 20:38:02 -04:00
VinPropane aba26446d3 NEO-48: address r2 review — atomic fixture, tests, docs 
Batch skillXp then resetPerkState with XP rollback; 400 for invalid skillXp;
MasteryFixtureApi gate tests; README fixture vs grant semantics; Bruno GET playerId.
 2026-05-17 20:37:00 -04:00
VinPropane 2bb02d76e9 NEO-48: add re-review for mastery fixture testing refactor 2026-05-17 20:34:36 -04:00
VinPropane 3ba8300652 NEO-48: address code review — Bruno deny, API deny tests 
Add self-contained branch_already_chosen Bruno request, HTTP deny smoke
for unknown track/tier/branch and null-body 400, folder docs for level_too_low.
 2026-05-17 20:21:42 -04:00
VinPropane 0838e661c9 NEO-48: add code review for perk-state HTTP 2026-05-17 20:16:46 -04:00
VinPropane 5058bc1963 NEO-49: address code review follow-ups for telemetry hooks 2026-05-17 19:21:21 -04:00
VinPropane 7ce9dc172c NEO-49: add code review for perk_unlock telemetry hooks 2026-05-17 19:15:17 -04:00
VinPropane 76e710b491 NEO-47: re-review — follow-ups verified, approve for merge 2026-05-17 18:46:25 -04:00
VinPropane 0a2a6fe45b NEO-47: address code review follow-ups for perk unlock engine 
Retroactive path-auto unlock on branch pick, unlock rollback, CanWritePlayer
gate, expanded deny tests, gather-hook smoke, decomposition docs, review strikethroughs.
 2026-05-17 18:45:11 -04:00
VinPropane 2520a80b6e NEO-47: add code review for perk unlock engine 2026-05-17 18:42:28 -04:00
VinPropane 07fc566e2c NEO-46: address code review follow-up. 
Add loader deny-path and registry enumeration tests, tierIndex 1..N gate
in validate_content.py, E2.M3 handoff doc update, and review strikethroughs.
 2026-05-17 18:12:39 -04:00
VinPropane 594287c199 NEO-45: address docs review suggestions for E2.M3 Slice 4. 
Expand data contract and NEO-46 handoff, gigs.md gig-mastery clarification,
acceptance footnote, and mark docs review items Done.
 2026-05-17 13:16:49 -04:00
VinPropane 4a9730c577 NEO-45: address code review doc alignment and CI nits. 
Align E2.M3 In Progress status, backlog checkboxes, perks map doc;
reject unreferenced PerkDef rows; tier-2 branch displayNames; review Done.
 2026-05-16 20:05:51 -04:00