Commit Graph

67 Commits (29bc2423b53ba7cb4afc6abd3bcd17b6afe88c8c)

Author SHA1 Message Date
VinPropane 01e82f38f6 NEO-146: fix record struct docs and collection spread in tests
Replace param XML on record struct mutation outcomes with summary cref
docs to avoid Roslynator RCS1263 false positives; apply IDE0305 in
RewardRouterOperationsTests and update style guide guidance.
2026-06-24 20:47:40 -04:00
VinPropane a4f37db594 NEO-146: restore test layout section in csharp-style guide
Fix IDE0270 section that accidentally overwrote the test project layout heading.
2026-06-24 20:46:27 -04:00
VinPropane b519f4e9eb NEO-146: fix mutation outcome docs and null-check style
Add summary and Kind param XML docs on mutation outcome records, simplify
PostgresDockerHelper null guard with ?? throw, and document RCS1139/IDE0270.
2026-06-24 20:46:23 -04:00
VinPropane b6b0b87534 NEO-146: fix remaining C# analyzer style warnings
Apply using simplification, inline declarations, const locals, and
Lock in PostgresDockerHelper; document RCS1118 and IDE0018 in style guide.
2026-06-24 20:44:30 -04:00
VinPropane b455ff5ad5 NEO-146: apply C# collection and using style fixes
Replace .ToArray() with collection spread, simplify single-statement
await using blocks, use Lock for Postgres schema gates, and document
IDE0063/IDE0305/IDE0330/CA1859 conventions in csharp-style.md.
2026-06-24 20:41:25 -04:00
VinPropane 24d598e0a2 chore: run gdlint/gdformat on pre-push only when client .gd changes. 2026-05-31 19:42:23 -04:00
VinPropane b4b8536081 chore: codify full-stack epic decomposition policy
Add alwaysApply rule, prototype backlog template, epic template updates,
and review/kickoff gates so player-visible slices require client Linear
issues and Godot verification—not Bruno-only deferrals.
2026-05-24 16:19:32 -04:00
VinPropane 3d43b00fa9 chore: harden kickoff AskQuestion + recommendation rule
Require Recommend preamble in chat before AskQuestion, mark recommended
options in labels, and call out AskQuestion-only turns as violations.
2026-05-24 13:30:20 -04:00
VinPropane 37761a4a32 NEO-51: Require agent recommendation in kickoff clarifications.
Story kickoff and planning docs now mandate a stated recommendation
(with rationale) for every clarification question and open-question row.
2026-05-17 21:49:46 -04:00
VinPropane 28bafaf77d chore: enforce commit-as-you-go via rule, AGENTS.md, and stop hook.
Add alwaysApply commit-as-you-go checklist, Critical git commits in AGENTS.md,
and a stop hook that follow-ups when NEO-* branches end with a dirty tree.
2026-05-17 18:22:46 -04:00
VinPropane 1f6fe86a1c chore: require commit-as-you-go on story work in agent rules.
Override ambiguous global guidance; AGENTS.md, commit-and-review, and
git-workflow now tell agents to commit on the story branch without waiting
for an explicit "commit" request.
2026-05-16 20:02:08 -04:00
VinPropane 27daef70a7 NEO-32: commit Godot .uid companions; document convention for agents 2026-04-30 22:02:29 -04:00
VinPropane c3acbdb373 NEO-28: Add reviewability guideline; mark NEO-28 review suggestions done.
Document preferring separate branches/commits for mechanical test-only
churn vs ticket-scoped changes. Strike through resolved bullets in the
saved review file per project convention.
2026-04-27 22:13:11 -04:00
VinPropane 7050bc12da chore: AAA rules — no required blank line after phase comments 2026-04-27 21:54:02 -04:00
VinPropane 31f9b74d3f chore: make AAA test layout mandatory in style rules and snippets 2026-04-27 21:52:39 -04:00
VinPropane eac95f0c27 chore: group Bruno hotbar-loadout and ability-cast under subfolders 2026-04-27 20:27:53 -04:00
VinPropane b34f7365b8 chore: make C# AAA test layout visible in AGENTS and review checklist 2026-04-27 20:24:20 -04:00
VinPropane 1900a6fb69 NEO-29: require pulling main before branching
Add an explicit git-workflow rule to fetch and pull main before creating new story branches, preventing stale-base branch creation.
2026-04-25 23:51:32 -04:00
VinPropane 01b627cc8a NEO-29: enforce MCP-only GitHub workflow in rules
Strengthen project guidance to require user-github MCP tools for GitHub operations and explicitly prohibit gh CLI fallback in repo-level agent rules.
2026-04-25 23:32:44 -04:00
VinPropane e6f3d63318 NEO-29: move AAA enforcement to test authoring time
Remove the AAA pre-commit gate and instead provide write-time scaffolding via C# snippets and a test template, then document those defaults in the C# style and testing expectations rules.
2026-04-25 22:50:03 -04:00
VinPropane 9894ce0d59 chore: enforce kickoff clarifications gate in story rule
Require clarification questions before plan updates/commits, require AskQuestion for blocking decisions, and mandate a Kickoff clarifications section in plan docs.
2026-04-25 21:56:23 -04:00
VinPropane 84f053d671 chore: document opening PRs via GitHub MCP instead of gh CLI
commit-and-review: primary path is user-github create_pull_request; owner/repo
from origin; fallback URL + optional gh for humans. Cross-link AGENTS, kickoff,
story-end, linear-git-naming, git-workflow.
2026-04-25 19:46:31 -04:00
VinPropane 9415ea0a0a chore: AskQuestion multiple choice for end-story Linear state 2026-04-24 21:50:05 -04:00
VinPropane 8226d00130 chore: story-end — require prominent Linear state ask after end story 2026-04-24 21:47:17 -04:00
VinPropane 8be7618e22 chore: story workflow — gh pr create with NEO-* title when user opens PR 2026-04-24 20:59:44 -04:00
VinPropane f87ff2c99a chore: require manual QA checklist per story in planning-implementation-docs rule
Add docs/manual-qa/{LINEAR_ISSUE_ID}.md as a required implementation-time
artifact for stories with user-visible behavior. Documents the when-to-
create / skip criteria, required header, section structure, coverage cues,
and that the agent generates but does not tick the boxes. Cross-references
from AGENTS.md alongside plans and reviews.
2026-04-21 22:21:44 -04:00
VinPropane c5cdf05392 chore: add Bruno API collection and testing-expectations for HTTP 2026-04-18 19:49:22 -04:00
VinPropane aed600abd2 chore: story kickoff — ask user when unclear or decision needed 2026-04-17 21:19:40 -04:00
VinPropane a4095cb9bf NEO-22: Remove click-to-move client and legacy move POST/verify
Delete ground_pick and GroundPick wiring; PositionAuthorityClient now only
boot GET and move-stream POST. main.gd snaps on authoritative position only.
Update client/server READMEs, cursor rule example, NEO-22 plan note, and
GdUnit authority tests (stream 400 + boot resync).
2026-04-17 20:06:46 -04:00
VinPropane 7e17ff563b chore: point docs and rules at Linear NEO issue ids
Migrate Jira NEON-* references to Linear NEO-* and linear.app links in
docs, Cursor rules, READMEs, and traceability comments. Renamed
implementation plans and dated reviews to NEO filenames.

Branch is based on origin/main with this commit only (no NEON-29
gameplay chain). client/README follows main’s district/map copy;
player.gd matches main aside from NEO-14 debug trace prefixes.
2026-04-13 13:15:32 -04:00
VinPropane 98a22a2d90 docs: Require explicit Jira status before story-end transition
- story-end.md: do not call transitionJiraIssue until user chooses In Test/Done (or states it in the same message); note MCP server plugin-atlassian-atlassian.

- AGENTS.md: story lifecycle line matches.
2026-04-11 00:06:23 -04:00
VinPropane 8c23feb7cf chore: require Jira transition choice in story-end rule 2026-04-08 23:15:58 -04:00
VinPropane cdf9d59bd9 NEON-26: add pre-push GDScript lint hook
Document the repo's enforced GDScript lint rules and add a local pre-push hook so gdlint/gdformat failures are caught before CI.
2026-04-08 23:10:40 -04:00
VinPropane adde98e4a8 chore: review follow-up uses strikethrough on suggestions, not extra section 2026-04-08 22:06:17 -04:00
VinPropane 6bc8014adf chore: require updating docs/reviews when review suggestions resolve 2026-04-08 22:03:44 -04:00
VinPropane 62ff210830 NEON-15: log plan decisions; require docs sync for planning/implementation 2026-04-08 21:49:56 -04:00
VinPropane 175c6e0500 chore: document Jira epic→story + labels (no Feature issues)
Module/slice grouping below epics is labels on stories only; Feature
work items are not used. Cross-link from jira-git-naming, story kickoff,
and documentation alignment table.
2026-04-07 00:20:01 -04:00
VinPropane fa19ab7337 chore: migrate Jira references from NS-* to NEON-* in docs and rules
Rename implementation plans and dated reviews to NEON issue numbers per
Atlassian project re-key. Update browse URLs, cross-links, module docs,
client/server READMEs, and Cursor rules (project key NEON).
2026-04-07 00:15:06 -04:00
VinPropane 8113e48cc8 NS-21: add GdUnit4, client tests, and CI headless run
- Vendor gdUnit4 v6.1.2 under client/addons; enable plugin in project.godot
- Tests: player.gd API, position authority HTTP flow (Node transport double),
  ground_pick walkable ancestry; test double script for injection
- position_authority_client: _create_http_request factory, Node-typed _http,
  emit move_rejected unknown for empty/missing reasonCode strings
- gdscript workflow: lint scripts+test, format check, cache Godot 4.6, GdUnit CLI
- README testing section; gitignore client/reports; testing-expectations Godot harness
2026-04-06 22:08:37 -04:00
VinPropane a02e54da2d NS-21: fold test CI into gdscript.yml; document test-with-scripts policy 2026-04-05 21:21:58 -04:00
VinPropane c09ea77815 chore: document protected main and -D in story-end rule 2026-04-05 00:06:29 -04:00
VinPropane ced9936414 chore: add story-end rule (main, pull, delete local branch) 2026-04-05 00:05:56 -04:00
VinPropane 018d43b08c chore: require files/tests lists in every story implementation plan 2026-04-04 23:14:48 -04:00
VinPropane a9d418d9c6 chore: allow agent commits at discretion; prohibit git push 2026-04-04 23:11:48 -04:00
VinPropane 0dea48e9fa chore: add zones game-design doc and cross-links
Add docs/game-design/zones.md for place identity (tone, economy, faction
hooks) on the E4.M1 graph, distinct from risk-security-bands tier rules.
Link from overview, README, related vision docs, brainstorm table, and
docs-review-agent; anchor Epic 4 slice 1 for deep links.
2026-04-03 22:47:05 -04:00
VinPropane d192567f57 chore: add game-design risk-security-bands doc
- Add risk-security-bands.md (E4.M4 tiers, E6.M1/M2 PvP + consent, tier gates)
- epic_04: anchor epic-4-slice-2 for security tier slice
- Cross-link death, items, economy, gathering; overview combat stub + index
- Extend docs-review-agent ground truth
2026-04-03 22:35:03 -04:00
VinPropane 6602f78b4b chore: add game-design death-loss-recovery doc
- Add death-loss-recovery.md (E5.M1, E3.M4, E6.M3, recovery, PvE vs PvP)
- Cross-link from overview (incl. combat stub), progression, skills, gigs, items, economy, gathering, crafting, abilities, README
- Extend docs-review-agent ground truth for death/loss
2026-04-03 22:30:11 -04:00
VinPropane 81695f93e4 chore: add game-design economy doc and cross-links
- Add economy.md (faucets, sinks, trade, E3.M5/E8.M3/E6.M4, mission vs loot)
- epic_03: anchor epic-3-slice-4 for stable deep links
- Wire overview, progression, skills, gigs, items, crafting, gathering, abilities, README
- Extend docs-review-agent hybrid ground truth for economy.md
2026-04-03 22:20:39 -04:00
VinPropane 277c25fdd0 chore: add game-design crafting & recipes doc
- Add crafting.md (pipeline, E3.M2 contracts, bench vs gig, module map)
- Cross-link from overview, progression, skills, gigs, items, gathering, abilities, README
- gathering.md: point pipeline follow-up to crafting.md; where-next row
- Extend docs-review-agent hybrid progression list
2026-04-03 21:51:25 -04:00
VinPropane 8d560e0df8 chore: add game-design gathering & resources doc
- Add gathering.md (nodes, Gather skills, gig vs skill XP, E3.M1/E4.M2)
- Cross-link from overview, progression, skills, gigs, items, abilities, README
- Extend docs-review-agent hybrid progression ground truth
2026-04-03 21:47:59 -04:00