From f0a41835985d987c43f5a7311dab294dc1271705 Mon Sep 17 00:00:00 2001 From: VinPropane Date: Sun, 24 May 2026 13:54:36 -0400 Subject: [PATCH] NEO-57: close review follow-ups on E3M1 backlog and review doc Clarify two-file yield layout in backlog; mark review suggestions resolved and verdict Approve. --- docs/plans/E3M1-prototype-backlog.md | 2 +- docs/reviews/2026-05-24-NEO-57.md | 8 ++++++-- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/docs/plans/E3M1-prototype-backlog.md b/docs/plans/E3M1-prototype-backlog.md index 23439c0..0884101 100644 --- a/docs/plans/E3M1-prototype-backlog.md +++ b/docs/plans/E3M1-prototype-backlog.md @@ -65,7 +65,7 @@ Working backlog for **Epic 3 — Slice 2** ([gather nodes and outputs](../decomp - `content/schemas/resource-node-def.schema.json` and `content/schemas/resource-yield-row.schema.json` (two row schemas; catalogs in `prototype_resource_nodes.json` + `prototype_resource_yields.json` — [NEO-57](NEO-57-implementation-plan.md)). - `content/resource-nodes/prototype_resource_nodes.json` with stable **`nodeDefId`** values aligned to interactable ids (see module doc freeze table). -- `content/resource-nodes/prototype_resource_yields.json` (or embedded yields — plan decides) referencing only **`scrap_metal_bulk`** from the E3.M3 freeze. +- `content/resource-nodes/prototype_resource_yields.json` — one yield row per `nodeDefId`, referencing only **`scrap_metal_bulk`** from the E3.M3 freeze. - `scripts/validate_content.py`: schema validation, duplicate ids, exact four-node allowlist, **`gatherLens`** coverage, cross-check that every yield **`itemId`** exists in `content/items/`. - Designer note in [E3_M1](../decomposition/modules/E3_M1_ResourceNodeAndGatherLoop.md) + `content/README.md`. diff --git a/docs/reviews/2026-05-24-NEO-57.md b/docs/reviews/2026-05-24-NEO-57.md index 0135714..bc2baf2 100644 --- a/docs/reviews/2026-05-24-NEO-57.md +++ b/docs/reviews/2026-05-24-NEO-57.md @@ -1,12 +1,12 @@ # Code review — NEO-57 prototype resource node catalogs + CI **Date:** 2026-05-24 -**Scope:** Branch `NEO-57-e3m1-prototype-resourcenodedef-yield-schemas-ci` · commits `17daf9a`–`b68d74b` vs `origin/main` (decomposition merge + plan + implementation) +**Scope:** Branch `NEO-57-e3m1-prototype-resourcenodedef-yield-schemas-ci` · commits `17daf9a`–`ca1a15f` vs `origin/main` (decomposition merge + plan + implementation + review follow-ups) **Base:** `origin/main` ## Verdict -**Approve with nits** +**Approve** ## Summary @@ -33,10 +33,14 @@ None. ## Suggestions +None (resolved in `ca1a15f` and follow-up backlog edit). + 1. ~~**E3M1 backlog checkboxes** — In [`E3M1-prototype-backlog.md`](../plans/E3M1-prototype-backlog.md) § E3M1-01, flip acceptance criteria to `[x]` (or add a “NEO-57 landed” note) so the backlog matches [`NEO-57-implementation-plan.md`](../plans/NEO-57-implementation-plan.md).~~ **Done.** 2. ~~**Backlog schema name** — Update E3M1-01 bullet from `resource-yield-table.schema.json` to **`resource-yield-row.schema.json`** (kickoff chose row schema + `prototype_resource_yields.json`).~~ **Done.** +3. ~~**Backlog yield file wording** — Remove “or embedded yields — plan decides” from E3M1-01 in-scope list; two-file layout is landed.~~ **Done.** + ## Nits - Nit: `_prototype_slice2_resource_node_gate` enforces lens **set** equality, not a per-lens duplicate error message; duplicate `gatherLens` on two nodes still fails with a clear set-mismatch line — acceptable for prototype.