From d4388e25aae4e094b47e930cb384a3350e4fd0dc Mon Sep 17 00:00:00 2001 From: VinPropane Date: Wed, 17 Jun 2026 21:24:30 -0400 Subject: [PATCH] NEO-142: rename shadowed name variable in quest defs tests Avoid SHADOWED_VARIABLE_BASE_CLASS warnings against Node.name. --- client/test/quest_definitions_client_test.gd | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/client/test/quest_definitions_client_test.gd b/client/test/quest_definitions_client_test.gd index b82fb45..e7a5dd3 100644 --- a/client/test/quest_definitions_client_test.gd +++ b/client/test/quest_definitions_client_test.gd @@ -105,9 +105,9 @@ func test_display_name_for_returns_catalog_display_name() -> void: c.call("request_sync_from_server") await get_tree().process_frame # Act - var name: String = str(c.call("display_name_for", "prototype_quest_gather_intro")) + var display_name: String = str(c.call("display_name_for", "prototype_quest_gather_intro")) # Assert - assert_that(name).is_equal("Intro: Salvage Run") + assert_that(display_name).is_equal("Intro: Salvage Run") func test_display_name_for_falls_back_to_raw_id() -> void: @@ -118,9 +118,9 @@ func test_display_name_for_falls_back_to_raw_id() -> void: c.call("request_sync_from_server") await get_tree().process_frame # Act - var name: String = str(c.call("display_name_for", "unknown_quest_id")) + var display_name: String = str(c.call("display_name_for", "unknown_quest_id")) # Assert - assert_that(name).is_equal("unknown_quest_id") + assert_that(display_name).is_equal("unknown_quest_id") func test_faction_gate_rules_for_returns_cached_gate_rows() -> void: