don
/
neon-sprawl
mirror of https://github.com/ViPro-Technologies/neon-sprawl
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

NEO-142: fix GdUnit HTTPClient method enum in faction tests 

Use METHOD_GET default params matching existing client test mocks; auto_free
progress client stub to avoid orphan exit code.
pull/182/head
VinPropane 2026-06-17 21:11:27 -04:00
parent 84bd46635d
commit be7878a199
2 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
client/test/faction_standing_client_test.gd
View File

@ -23,7 +23,7 @@ class MockHttpTransport:
func request( func request(
url: String, url: String,
_custom_headers: PackedStringArray = PackedStringArray(), _custom_headers: PackedStringArray = PackedStringArray(),
_method: HTTPClient.Method = HTTPClient.Method.GET, _method: HTTPClient.Method = HTTPClient.METHOD_GET,
_request_data: String = "" _request_data: String = ""
) -> Error: ) -> Error:
last_url = url last_url = url
@ -48,7 +48,7 @@ class PendingSyncHttpTransport:
func request( func request(
_url: String, _url: String,
_custom_headers: PackedStringArray = PackedStringArray(), _custom_headers: PackedStringArray = PackedStringArray(),
_method: HTTPClient.Method = HTTPClient.Method.GET, _method: HTTPClient.Method = HTTPClient.METHOD_GET,
_request_data: String = "" _request_data: String = ""
) -> Error: ) -> Error:
request_count += 1 request_count += 1

6
client/test/faction_standing_hud_test.gd
View File

@ -19,7 +19,7 @@ class MockHttpTransport:
func request( func request(
_url: String, _url: String,
_custom_headers: PackedStringArray = PackedStringArray(), _custom_headers: PackedStringArray = PackedStringArray(),
_method: HTTPClient.Method = HTTPClient.Method.GET, _method: HTTPClient.Method = HTTPClient.METHOD_GET,
_request_data: String = "" _request_data: String = ""
) -> Error: ) -> Error:
request_completed.emit( request_completed.emit(
@ -147,12 +147,14 @@ func test_accept_result_received_paints_readable_faction_gate_blocked() -> void:
defs_client.call("request_sync_from_server") defs_client.call("request_sync_from_server")
var controller: Node = QuestHudController.new() var controller: Node = QuestHudController.new()
var accept_label := Label.new() var accept_label := Label.new()
var progress_client := Node.new()
auto_free(controller) auto_free(controller)
auto_free(accept_label) auto_free(accept_label)
auto_free(progress_client)
add_child(controller) add_child(controller)
controller.set("_defs_client", defs_client) controller.set("_defs_client", defs_client)
controller.set("_accept_label", accept_label) controller.set("_accept_label", accept_label)
controller.set("_progress_client", Node.new()) controller.set("_progress_client", progress_client)
controller.call( controller.call(
"_on_faction_standing_received", {"schemaVersion": 1, "playerId": "dev-local-1", "factions": []} "_on_faction_standing_received", {"schemaVersion": 1, "playerId": "dev-local-1", "factions": []}
) )