From ae643bc81c876093d0bd05a560c8723d9e69ce00 Mon Sep 17 00:00:00 2001 From: VinPropane Date: Wed, 8 Apr 2026 23:00:10 -0400 Subject: [PATCH] NEON-26: refresh review after follow-up fixes --- docs/reviews/2026-04-08-NEON-26.md | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/docs/reviews/2026-04-08-NEON-26.md b/docs/reviews/2026-04-08-NEON-26.md index d2e0bcd..76b3369 100644 --- a/docs/reviews/2026-04-08-NEON-26.md +++ b/docs/reviews/2026-04-08-NEON-26.md @@ -3,7 +3,7 @@ **Date:** 2026-04-08 **Scope:** Branch `NEON-26-zoom-band-config-discrete-input` vs `origin/main` (NEON-26 zoom bands + follow-up `.tres` tuning commits). Issue **NEON-26**; no PR URL supplied. **Base:** `origin/main` @ `88653292104eddfc1db702f97b02a088fb80c1c7` (merge-base with HEAD at review time). -**Follow-up:** Suggestions and nits below were implemented in-repo (README, plan typing note, positive-distance validation, `_sync_camera_state(effective_distance)`, telemetry TODO wording). +**Follow-up:** Suggestions and nits below were implemented in-repo (README, plan typing note, positive-distance validation, `_sync_camera_state(effective_distance)`, telemetry TODO wording) and re-reviewed after `ff83081`. ## Verdict @@ -11,7 +11,7 @@ ## Summary -The branch delivers **data-driven discrete zoom** via `ZoomBandConfig`, **InputMap** actions, **`_unhandled_input`** on the follow rig, and **`CameraState`** updates for effective distance and band index, with **clamp** semantics and **`follow_distance`** fallback when config is missing or empty. **GdUnit** coverage was added for the resource and **`effective_follow_distance`**. Module and dependency-register docs were updated. Overall risk is **low**: client-local camera only, no server coupling; logic is straightforward. Follow-up tuning of **`isometric_zoom_bands.tres`** (band count and distances) is data-only and acceptable on the same story. +The branch delivers **data-driven discrete zoom** via `ZoomBandConfig`, **InputMap** actions, **`_unhandled_input`** on the follow rig, and **`CameraState`** updates for effective distance and band index, with **clamp** semantics and **`follow_distance`** fallback when config is missing, empty, or invalid. **GdUnit** coverage was added for the resource and **`effective_follow_distance`**. Module and dependency-register docs were updated. Overall risk is **low**: client-local camera only, no server coupling; logic is straightforward. Re-review after the follow-up commit found **no additional issues**. ## Documentation checked @@ -48,4 +48,5 @@ None. - From `client/`: Godot **4.6** headless import (if needed) then GdUnit: `godot --headless --import --path . --quit-after 8` `godot --headless --path . -s res://addons/gdUnit4/bin/GdUnitCmdTool.gd --ignoreHeadlessMode -a res://test` +- **Observed on re-review:** GdUnit passed locally: **28 test cases, 0 failures**. - **Manual:** F5, cycle zoom (wheel, `=`, `-`, keypad), confirm framing and that **`CameraState`**-consumers (if any) see band index + distance; confirm **`zoom_band_config` cleared** falls back to **`follow_distance`**.