don
/
neon-sprawl
mirror of https://github.com/ViPro-Technologies/neon-sprawl
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

chore: dedupe faction id constants in gate operation tests

pull/188/head
VinPropane 2026-06-27 19:30:28 -04:00
parent 39805ef8e6
commit 58a188eac0
1 changed files with 5 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
server/NeonSprawl.Server.Tests/Game/Factions/FactionGateOperationsTests.cs
View File

@ -12,6 +12,7 @@ public sealed class FactionGateOperationsTests
{ {
private const string PlayerId = "dev-local-1"; private const string PlayerId = "dev-local-1";
private const string GridFactionId = PrototypeE7M3QuestFactionRules.GridContractGateFactionId; private const string GridFactionId = PrototypeE7M3QuestFactionRules.GridContractGateFactionId;
private const string RustCollectiveFactionId = "prototype_faction_rust_collective";
private const int GridMinStanding = PrototypeE7M3QuestFactionRules.GridContractMinStanding; private const int GridMinStanding = PrototypeE7M3QuestFactionRules.GridContractMinStanding;
[Fact] [Fact]
@ -63,19 +64,18 @@ public sealed class FactionGateOperationsTests
{ {
// Arrange // Arrange
var standingStore = CreateStandingStore(); var standingStore = CreateStandingStore();
const string rustFactionId = "prototype_faction_rust_collective";
Assert.True(standingStore.TryApplyStandingDelta(PlayerId, GridFactionId, GridMinStanding).Success); Assert.True(standingStore.TryApplyStandingDelta(PlayerId, GridFactionId, GridMinStanding).Success);
var rules = new[] var rules = new[]
{ {
new FactionGateRuleRow(GridFactionId, GridMinStanding), new FactionGateRuleRow(GridFactionId, GridMinStanding),
new FactionGateRuleRow(rustFactionId, 1), new FactionGateRuleRow(RustCollectiveFactionId, 1),
}; };
// Act // Act
var outcome = FactionGateOperations.TryEvaluate(PlayerId, rules, standingStore); var outcome = FactionGateOperations.TryEvaluate(PlayerId, rules, standingStore);
// Assert // Assert
Assert.False(outcome.Success); Assert.False(outcome.Success);
Assert.Equal(FactionGateEvaluateReasonCodes.GateBlocked, outcome.ReasonCode); Assert.Equal(FactionGateEvaluateReasonCodes.GateBlocked, outcome.ReasonCode);
Assert.Equal(rustFactionId, outcome.FailingFactionId); Assert.Equal(RustCollectiveFactionId, outcome.FailingFactionId);
Assert.Equal(1, outcome.RequiredMinStanding); Assert.Equal(1, outcome.RequiredMinStanding);
Assert.Equal(0, outcome.CurrentStanding); Assert.Equal(0, outcome.CurrentStanding);
} }
@ -120,12 +120,10 @@ public sealed class FactionGateOperationsTests
private static FactionDefinitionRegistry CreatePrototypeRegistry() private static FactionDefinitionRegistry CreatePrototypeRegistry()
{ {
var gridFactionId = PrototypeE7M3QuestFactionRules.GridContractGateFactionId;
var rustFactionId = "prototype_faction_rust_collective";
var byId = new Dictionary<string, FactionDefRow>(StringComparer.Ordinal) var byId = new Dictionary<string, FactionDefRow>(StringComparer.Ordinal)
{ {
[gridFactionId] = PrototypeE7M3FactionCatalogRules.ExpectedFactionFreeze[gridFactionId], [GridFactionId] = PrototypeE7M3FactionCatalogRules.ExpectedFactionFreeze[GridFactionId],
[rustFactionId] = PrototypeE7M3FactionCatalogRules.ExpectedFactionFreeze[rustFactionId], [RustCollectiveFactionId] = PrototypeE7M3FactionCatalogRules.ExpectedFactionFreeze[RustCollectiveFactionId],
}; };
var catalog = new FactionDefinitionCatalog("/tmp/catalog", byId, catalogJsonFileCount: 1); var catalog = new FactionDefinitionCatalog("/tmp/catalog", byId, catalogJsonFileCount: 1);
return new FactionDefinitionRegistry(catalog); return new FactionDefinitionRegistry(catalog);