don
/
neon-sprawl
mirror of https://github.com/ViPro-Technologies/neon-sprawl
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

NEO-151: Fix Bruno helper path for collection-root scripts resolution 

Move reset-contract-instances-helper.js to neon-sprawl-server/scripts/
and fix encounter-clear bru requires so CI can resolve modules.
pull/193/head
VinPropane 2026-06-28 11:16:13 -04:00
parent 5f2ab34fa2
commit 50df06a3f9
6 changed files with 8 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
bruno/neon-sprawl-server/contracts/Get contracts after encounter clear.bru
View File

@ -10,14 +10,14 @@ docs {
script:pre-request { script:pre-request {
const axios = require("axios"); const axios = require("axios");
const { resetAllContractInstances } = require("./scripts/reset-contract-instances-helper"); const { resetAllContractInstances } = require("./scripts/reset-contract-instances-helper.js");
const { resetPrototypeCombatTargets } = require("../encounter-progress/scripts/combat-targets-reset-helper.js"); const { resetPrototypeCombatTargets } = require("./scripts/combat-targets-reset-helper.js");
const { const {
moveNearPrototypeNpc, moveNearPrototypeNpc,
PULSE_COOLDOWN_MS, PULSE_COOLDOWN_MS,
MAX_PULSE_DEFEAT_ATTEMPTS, MAX_PULSE_DEFEAT_ATTEMPTS,
sleep, sleep,
} = require("../encounter-progress/scripts/prototype-npc-bruno-helper.js"); } = require("./scripts/prototype-npc-bruno-helper.js");
const baseUrl = bru.getEnvVar("baseUrl") || bru.getVar("baseUrl"); const baseUrl = bru.getEnvVar("baseUrl") || bru.getVar("baseUrl");
const playerId = bru.getEnvVar("playerId") || bru.getVar("playerId"); const playerId = bru.getEnvVar("playerId") || bru.getVar("playerId");
const jsonHeaders = { headers: { "Content-Type": "application/json" } }; const jsonHeaders = { headers: { "Content-Type": "application/json" } };

2
bruno/neon-sprawl-server/contracts/Get contracts default.bru
View File

@ -10,7 +10,7 @@ docs {
} }
script:pre-request { script:pre-request {
const { resetAllContractInstances } = require("./scripts/reset-contract-instances-helper"); const { resetAllContractInstances } = require("./scripts/reset-contract-instances-helper.js");
await resetAllContractInstances(bru); await resetAllContractInstances(bru);
} }

2
bruno/neon-sprawl-server/contracts/Issue prototype contract.bru
View File

@ -9,7 +9,7 @@ docs {
} }
script:pre-request { script:pre-request {
const { resetAllContractInstances } = require("./scripts/reset-contract-instances-helper"); const { resetAllContractInstances } = require("./scripts/reset-contract-instances-helper.js");
await resetAllContractInstances(bru); await resetAllContractInstances(bru);
} }

0
bruno/neon-sprawl-server/contracts/scripts/reset-contract-instances-helper.js → bruno/neon-sprawl-server/scripts/reset-contract-instances-helper.js
View File

3
docs/reviews/2026-06-28-NEO-151.md
View File

@ -51,7 +51,8 @@ None.
| Severity | Location | Finding | Status | | Severity | Location | Finding | Status |
|----------|----------|---------|--------| |----------|----------|---------|--------|
| Low | `reset-contract-instances-helper.js:27` | Reset helper only cleared one capped GET page (active + 10 completed); older rows could survive pre-request cleanup | **Done.** — loop GET → reset until list empty (max 100 passes) | | Low | `scripts/reset-contract-instances-helper.js` | Reset helper only cleared one capped GET page (active + 10 completed); older rows could survive pre-request cleanup | **Done.** — loop GET → reset until list empty (max 100 passes) |
| Low | `contracts/scripts/` helper path | Bruno resolves `./scripts/` from collection root, not per-folder — CI module not found | **Done.** — moved helper to `neon-sprawl-server/scripts/`; `.js` suffix on requires |
## Verification ## Verification

2
server/README.md
View File

@ -152,7 +152,7 @@ Plan: [NEO-141 implementation plan](../../docs/plans/NEO-141-implementation-plan
**400** for bad schema; **404** when disabled, player unknown, unknown quest/faction id, or store write fails. Not for production. Bruno: `quest-progress/Accept grid contract faction gate deny.bru` uses **`resetQuestIds`**, **`resetFactionIds`**, and **`completedQuestIds`**; order-independent accept/gather tests use **`resetQuestIds`** via **`scripts/bruno-dev-fixture-helper.js`**. **400** for bad schema; **404** when disabled, player unknown, unknown quest/faction id, or store write fails. Not for production. Bruno: `quest-progress/Accept grid contract faction gate deny.bru` uses **`resetQuestIds`**, **`resetFactionIds`**, and **`completedQuestIds`**; order-independent accept/gather tests use **`resetQuestIds`** via **`scripts/bruno-dev-fixture-helper.js`**.
**Bruno self-reset helpers:** `bruno/neon-sprawl-server/scripts/bruno-dev-fixture-helper.js` centralizes quest progress reset, resource-node restore, inventory clear, and post-reset verification (`resetAllPrototypeQuestProgress`, `resetGatherIntroSpine`, `resetPrototypeResourceNodes`, `clearInventory`). Combat HP/encounter reset remains **`scripts/combat-targets-reset-helper.js`**. **Bruno self-reset helpers:** `bruno/neon-sprawl-server/scripts/bruno-dev-fixture-helper.js` centralizes quest progress reset, resource-node restore, inventory clear, and post-reset verification (`resetAllPrototypeQuestProgress`, `resetGatherIntroSpine`, `resetPrototypeResourceNodes`, `clearInventory`). **`scripts/reset-contract-instances-helper.js`** clears all contract instances via capped GET loop + quest-fixture reset (NEO-151). Combat HP/encounter reset remains **`scripts/combat-targets-reset-helper.js`**.
## Resource-node catalog (`content/resource-nodes`, NEO-58) ## Resource-node catalog (`content/resource-nodes`, NEO-58)