don
/
neon-sprawl
mirror of https://github.com/ViPro-Technologies/neon-sprawl
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

NEO-131: gdformat quest HUD scripts after Bugbot fixes.

pull/170/head
VinPropane 2026-06-07 23:07:32 -04:00
parent dc39250e96
commit 3c3170c731
2 changed files with 3 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
client/scripts/quest_hud_controller.gd
View File

@ -60,9 +60,7 @@ func setup(
"definitions_sync_failed", Callable(self, "_on_definitions_sync_failed")
)
if is_instance_valid(_item_defs_client) and _item_defs_client.has_signal("definitions_ready"):
_item_defs_client.connect(
"definitions_ready", Callable(self, "_on_item_definitions_ready")
)
_item_defs_client.connect("definitions_ready", Callable(self, "_on_item_definitions_ready"))
_render_progress_label()
_render_accept_feedback_label()
_render_reward_label()
@ -177,9 +175,7 @@ func _detect_and_apply_completion_transitions(snapshot: Dictionary) -> void:
if new_status == "active":
_mark_quest_active_in_session(qid)
var prev_status := str(_previous_status_by_quest.get(qid, "not_started"))
var can_detect := (
not boot_seed or bool(_quest_was_active_in_session.get(qid, false))
)
var can_detect := not boot_seed or bool(_quest_was_active_in_session.get(qid, false))
if can_detect and prev_status != "completed" and new_status == "completed":
var summary := QuestProgressClient.completion_reward_summary(qid, snapshot)
if not summary.is_empty():

5
client/test/quest_reward_hud_test.gd
View File

@ -23,10 +23,7 @@ class MockHttpTransport:
_request_data: String = ""
) -> Error:
request_completed.emit(
HTTPRequest.RESULT_SUCCESS,
200,
PackedStringArray(),
body_json.to_utf8_buffer()
HTTPRequest.RESULT_SUCCESS, 200, PackedStringArray(), body_json.to_utf8_buffer()
)
return OK