From 3a509d560e57a8f00bd1cbb24e9b5f88dd68e0c4 Mon Sep 17 00:00:00 2001 From: VinPropane Date: Wed, 17 Jun 2026 21:19:27 -0400 Subject: [PATCH] chore: silence IDE0301 and redundant await linter warnings Use static empty bundle grant lists in RewardRouterOperations; drop redundant await on synchronous GdUnit assert_signal in quest defs test. --- client/test/quest_definitions_client_test.gd | 2 +- .../Game/Rewards/RewardRouterOperations.cs | 9 ++++++--- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/client/test/quest_definitions_client_test.gd b/client/test/quest_definitions_client_test.gd index 47ffce5..b82fb45 100644 --- a/client/test/quest_definitions_client_test.gd +++ b/client/test/quest_definitions_client_test.gd @@ -92,7 +92,7 @@ func test_request_sync_emits_definitions_ready() -> void: # Act c.call("request_sync_from_server") # Assert - await assert_signal(c).is_emitted("definitions_ready", any()) + assert_signal(c).is_emitted("definitions_ready", any()) assert_that(_quests_capture.size()).is_equal(4) assert_that(transport.last_url).contains("/quest-definitions") diff --git a/server/NeonSprawl.Server/Game/Rewards/RewardRouterOperations.cs b/server/NeonSprawl.Server/Game/Rewards/RewardRouterOperations.cs index bdfe747..c2f989b 100644 --- a/server/NeonSprawl.Server/Game/Rewards/RewardRouterOperations.cs +++ b/server/NeonSprawl.Server/Game/Rewards/RewardRouterOperations.cs @@ -18,6 +18,9 @@ public static class RewardRouterOperations private static readonly RewardItemGrantApplied[] EmptyItemGrants = []; private static readonly RewardSkillXpGrantApplied[] EmptySkillXpGrants = []; private static readonly RewardReputationGrantApplied[] EmptyReputationGrants = []; + private static readonly IReadOnlyList EmptyBundleItemGrantRows = []; + private static readonly IReadOnlyList EmptyBundleSkillXpGrantRows = []; + private static readonly IReadOnlyList EmptyBundleReputationGrantRows = []; /// /// Applies item, skill XP, and reputation rows for a quest completion and records @@ -56,9 +59,9 @@ public static class RewardRouterOperations return SuccessFromEvent(existingEvent, RewardDeliveryReasonCodes.AlreadyDelivered); } - var itemGrants = bundle?.ItemGrants ?? []; - var skillGrants = bundle?.SkillXpGrants ?? []; - var reputationGrants = bundle?.ReputationGrants ?? []; + var itemGrants = bundle?.ItemGrants ?? EmptyBundleItemGrantRows; + var skillGrants = bundle?.SkillXpGrants ?? EmptyBundleSkillXpGrantRows; + var reputationGrants = bundle?.ReputationGrants ?? EmptyBundleReputationGrantRows; var idempotencyKey = RewardDeliveryIds.MakeIdempotencyKey(normalizedPlayerId, normalizedQuestId); if (itemGrants.Count > 0)