don
/
neon-sprawl
mirror of https://github.com/ViPro-Technologies/neon-sprawl
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

NEO-146: simplify using declarations in outcome persistence tests 

Apply IDE0063 where braced scopes have no name clashes with later blocks.
pull/187/head
VinPropane 2026-06-24 21:11:53 -04:00
parent 6c4221072a
commit 237e39c8ca
1 changed files with 36 additions and 42 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
server/NeonSprawl.Server.Tests/Game/Contracts/ContractOutcomePersistenceIntegrationTests.cs
View File

@ -39,8 +39,7 @@ public sealed class ContractOutcomePersistenceIntegrationTests(PostgresIntegrati
RecordedAt); RecordedAt);
// Act — write through first host // Act — write through first host
using (var firstScope = Factory.Services.CreateScope()) using var firstScope = Factory.Services.CreateScope();
{
var instanceStore = firstScope.ServiceProvider.GetRequiredService<IContractInstanceStore>(); var instanceStore = firstScope.ServiceProvider.GetRequiredService<IContractInstanceStore>();
var outcomeStore = firstScope.ServiceProvider.GetRequiredService<IContractOutcomeStore>(); var outcomeStore = firstScope.ServiceProvider.GetRequiredService<IContractOutcomeStore>();
Assert.True(instanceStore.TryCreateActive( Assert.True(instanceStore.TryCreateActive(
@ -51,7 +50,6 @@ public sealed class ContractOutcomePersistenceIntegrationTests(PostgresIntegrati
IssuedAt, IssuedAt,
out _)); out _));
Assert.True(outcomeStore.TryAppend(outcomeRow)); Assert.True(outcomeStore.TryAppend(outcomeRow));
}
ContractOutcomeRow readBack; ContractOutcomeRow readBack;
await using var secondFactory = new PostgresWebApplicationFactory(); await using var secondFactory = new PostgresWebApplicationFactory();
@ -145,8 +143,7 @@ public sealed class ContractOutcomePersistenceIntegrationTests(PostgresIntegrati
[], [],
[], [],
RecordedAt); RecordedAt);
using (var scope = Factory.Services.CreateScope()) using var scope = Factory.Services.CreateScope();
{
var instanceStore = scope.ServiceProvider.GetRequiredService<IContractInstanceStore>(); var instanceStore = scope.ServiceProvider.GetRequiredService<IContractInstanceStore>();
var outcomeStore = scope.ServiceProvider.GetRequiredService<IContractOutcomeStore>(); var outcomeStore = scope.ServiceProvider.GetRequiredService<IContractOutcomeStore>();
Assert.True(instanceStore.TryCreateActive( Assert.True(instanceStore.TryCreateActive(
@ -163,7 +160,6 @@ public sealed class ContractOutcomePersistenceIntegrationTests(PostgresIntegrati
Assert.False(appended); Assert.False(appended);
Assert.Empty(outcomeStore.GetOutcomesForInstance(InstanceId)); Assert.Empty(outcomeStore.GetOutcomesForInstance(InstanceId));
} }
}
[RequirePostgresFact] [RequirePostgresFact]
public async Task TryAppend_ShouldAllowOnlyOneSuccess_WhenConcurrentDuplicateRowsRace() public async Task TryAppend_ShouldAllowOnlyOneSuccess_WhenConcurrentDuplicateRowsRace()
@ -180,9 +176,8 @@ public sealed class ContractOutcomePersistenceIntegrationTests(PostgresIntegrati
[], [],
[], [],
RecordedAt); RecordedAt);
using (var scope = Factory.Services.CreateScope()) using var seedScope = Factory.Services.CreateScope();
{ var instanceStore = seedScope.ServiceProvider.GetRequiredService<IContractInstanceStore>();
var instanceStore = scope.ServiceProvider.GetRequiredService<IContractInstanceStore>();
Assert.True(instanceStore.TryCreateActive( Assert.True(instanceStore.TryCreateActive(
PlayerId, PlayerId,
InstanceId, InstanceId,
@ -190,7 +185,6 @@ public sealed class ContractOutcomePersistenceIntegrationTests(PostgresIntegrati
SeedBucket, SeedBucket,
IssuedAt, IssuedAt,
out _)); out _));
}
// Act // Act
var results = await Task.WhenAll( var results = await Task.WhenAll(