From 0a4450a199c00ec63ab5d34b6cbf7fda5e0d9c6b Mon Sep 17 00:00:00 2001 From: VinPropane Date: Wed, 17 Jun 2026 19:27:27 -0400 Subject: [PATCH] =?UTF-8?q?NEO-141:=20address=20review=20=E2=80=94=20backl?= =?UTF-8?q?og=20wording=20and=20class=20summary?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Align E7M3-09 in-scope bullet with ops-only hook anchors; pluralize FactionGateOperations telemetry remark; mark review findings done. --- docs/plans/E7M3-pre-production-backlog.md | 2 +- docs/reviews/2026-06-17-NEO-141.md | 6 +++--- .../Game/Factions/FactionGateOperations.cs | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/docs/plans/E7M3-pre-production-backlog.md b/docs/plans/E7M3-pre-production-backlog.md index ef89cea..f812a2f 100644 --- a/docs/plans/E7M3-pre-production-backlog.md +++ b/docs/plans/E7M3-pre-production-backlog.md @@ -296,7 +296,7 @@ Accepting **`prototype_quest_grid_contract`** before operator-chain completion o **In scope** - Comment-only **`reputation_delta`** in **`ReputationOperations`** (successful apply). -- Comment-only **`faction_gate_blocked`** in **`FactionGateOperations`** / **`TryAccept`** deny path. +- Comment-only **`faction_gate_blocked`** in **`FactionGateOperations.TryEvaluate`** (threshold + standing read failure deny paths). - `server/README.md` hook list. **Out of scope** diff --git a/docs/reviews/2026-06-17-NEO-141.md b/docs/reviews/2026-06-17-NEO-141.md index 1487939..38a0517 100644 --- a/docs/reviews/2026-06-17-NEO-141.md +++ b/docs/reviews/2026-06-17-NEO-141.md @@ -17,7 +17,7 @@ This branch lands **E7M3-09**: comment-only telemetry anchor sites for future E9 | Path | Result | |------|--------| | `docs/plans/NEO-141-implementation-plan.md` | **Matches** — kickoff decisions, AC checklist, reconciliation section, and file list align with the shipped diff. | -| `docs/plans/E7M3-pre-production-backlog.md` | **Partially matches** — E7M3-09 AC checked and landed note correct; in-scope bullet still mentions **`TryAccept`** deny path while implementation (correctly) anchors only **`FactionGateOperations`** per adopted plan decision. | +| `docs/plans/E7M3-pre-production-backlog.md` | **Matches** — E7M3-09 AC checked and landed note correct; in-scope bullets align with ops-only anchors. | | `docs/decomposition/modules/E7_M3_FactionReputationLedger.md` | **Matches** — Status line notes E7M3-09 landed (NEO-141); Responsibilities “Emit telemetry hook sites” satisfied at comment layer. | | `docs/decomposition/modules/documentation_and_implementation_alignment.md` | **Matches** — E7.M3 row updated with NEO-141 telemetry + README link. | | `docs/decomposition/modules/module_dependency_register.md` | **N/A change** — no register row edit required beyond module doc / alignment table. | @@ -31,11 +31,11 @@ None. ## Suggestions -1. **Align E7M3-09 backlog in-scope bullet with shipped anchor.** [E7M3-pre-production-backlog.md](../plans/E7M3-pre-production-backlog.md) §E7M3-09 still lists “`**TryAccept`** deny path” alongside **`FactionGateOperations`**, but the adopted plan and code place **`faction_gate_blocked`** only in **`FactionGateOperations.TryEvaluate`** (quest layer maps HTTP reason without duplicating the hook). Update the in-scope bullet to ops-only wording so future readers do not expect a **`QuestStateOperations`** comment block. +1. ~~**Align E7M3-09 backlog in-scope bullet with shipped anchor.** [E7M3-pre-production-backlog.md](../plans/E7M3-pre-production-backlog.md) §E7M3-09 still lists “`**TryAccept`** deny path” alongside **`FactionGateOperations`**, but the adopted plan and code place **`faction_gate_blocked`** only in **`FactionGateOperations.TryEvaluate`** (quest layer maps HTTP reason without duplicating the hook). Update the in-scope bullet to ops-only wording so future readers do not expect a **`QuestStateOperations`** comment block.~~ **Done.** In-scope bullet now reads **`FactionGateOperations.TryEvaluate`** (threshold + standing read failure deny paths). ## Nits -- Nit: **`FactionGateOperations`** class summary says “deny return path below” (singular) while two deny branches now carry hooks — consider “deny return paths” for accuracy. +- ~~Nit: **`FactionGateOperations`** class summary says “deny return path below” (singular) while two deny branches now carry hooks — consider “deny return paths” for accuracy.~~ **Done.** - Nit: Branch bundles **NEO-140** manual QA removal (`ef75111`) with **NEO-141** work — acceptable hygiene; PR description should mention both if opened as one branch. ## Verification diff --git a/server/NeonSprawl.Server/Game/Factions/FactionGateOperations.cs b/server/NeonSprawl.Server/Game/Factions/FactionGateOperations.cs index 9752814..59f91b8 100644 --- a/server/NeonSprawl.Server/Game/Factions/FactionGateOperations.cs +++ b/server/NeonSprawl.Server/Game/Factions/FactionGateOperations.cs @@ -5,7 +5,7 @@ namespace NeonSprawl.Server.Game.Factions; /// /// Evaluates minimum-standing gates (NEO-137). /// Quest accept wiring: . -/// NEO-141 telemetry hook site: deny return path below. +/// NEO-141 telemetry hook site: deny return paths below. /// public static class FactionGateOperations {