diff --git a/bruno/neon-sprawl-server/quest-progress/Accept grid contract faction gate deny.bru b/bruno/neon-sprawl-server/quest-progress/Accept grid contract faction gate deny.bru new file mode 100644 index 0000000..13261b7 --- /dev/null +++ b/bruno/neon-sprawl-server/quest-progress/Accept grid contract faction gate deny.bru @@ -0,0 +1,35 @@ +meta { + name: Accept grid contract faction gate deny + type: http + seq: 10 +} + +docs { + NEO-137: prototype_quest_grid_contract requires completed operator chain and Grid Operators standing >= 15. + Prerequisite setup: mark prototype_quest_operator_chain completed (store seed or full chain playthrough). + Fresh dev player with chain completed but standing 0 denies faction_gate_blocked before activation. + Success Bruno deferred to NEO-138 when operator-chain rep grants land. +} + +post { + url: {{baseUrl}}/game/players/{{playerId}}/quests/prototype_quest_grid_contract/accept + body: json + auth: none +} + +body:json { + { + "schemaVersion": 1 + } +} + +tests { + test("denies accept with faction_gate_blocked when standing below minStanding", function () { + expect(res.getStatus()).to.equal(200); + const body = res.getBody(); + expect(body.schemaVersion).to.equal(1); + expect(body.accepted).to.equal(false); + expect(body.reasonCode).to.equal("faction_gate_blocked"); + expect(body.quest).to.equal(undefined); + }); +} diff --git a/docs/decomposition/modules/E7_M3_FactionReputationLedger.md b/docs/decomposition/modules/E7_M3_FactionReputationLedger.md index 0723166..21f35aa 100644 --- a/docs/decomposition/modules/E7_M3_FactionReputationLedger.md +++ b/docs/decomposition/modules/E7_M3_FactionReputationLedger.md @@ -7,7 +7,7 @@ | **Module ID** | E7.M3 | | **Epic** | [Epic 7 — Quest / Faction](../epics/epic_07_quest_faction.md) | | **Stage target** | Pre-production | -| **Status** | In Progress — **E7M3-01 catalog landed** ([NEO-133](https://linear.app/neon-sprawl/issue/NEO-133)); **E7M3-02 server faction catalog load landed** ([NEO-134](https://linear.app/neon-sprawl/issue/NEO-134)): fail-fast `content/factions/*_factions.json`, `IFactionDefinitionRegistry`, quest faction cross-ref + E7M3 bundle/grid gates; **E7M3-03 faction standing + reputation delta stores landed** ([NEO-135](https://linear.app/neon-sprawl/issue/NEO-135)): `IFactionStandingStore`, `IReputationDeltaStore`, in-memory + Postgres `V009`/`V010`; **E7M3-04 `ReputationOperations` landed** ([NEO-136](https://linear.app/neon-sprawl/issue/NEO-136)): auditable `TryApplyDelta` orchestration ([NEO-136 plan](../../plans/NEO-136-implementation-plan.md)). Slice 3 backlog [E7M3-pre-production-backlog.md](../../plans/E7M3-pre-production-backlog.md): **E7M3-05** [NEO-137](https://linear.app/neon-sprawl/issue/NEO-137) → **E7M3-11** [NEO-143](https://linear.app/neon-sprawl/issue/NEO-143). Upstream: E7.M1 **Ready**, E7.M2 **Ready**. | +| **Status** | In Progress — **E7M3-01 catalog landed** ([NEO-133](https://linear.app/neon-sprawl/issue/NEO-133)); **E7M3-02 server faction catalog load landed** ([NEO-134](https://linear.app/neon-sprawl/issue/NEO-134)): fail-fast `content/factions/*_factions.json`, `IFactionDefinitionRegistry`, quest faction cross-ref + E7M3 bundle/grid gates; **E7M3-03 faction standing + reputation delta stores landed** ([NEO-135](https://linear.app/neon-sprawl/issue/NEO-135)): `IFactionStandingStore`, `IReputationDeltaStore`, in-memory + Postgres `V009`/`V010`; **E7M3-04 `ReputationOperations` landed** ([NEO-136](https://linear.app/neon-sprawl/issue/NEO-136)): auditable `TryApplyDelta` orchestration ([NEO-136 plan](../../plans/NEO-136-implementation-plan.md)); **E7M3-05 `FactionGateOperations` landed** ([NEO-137](https://linear.app/neon-sprawl/issue/NEO-137)): quest accept gate eval + `faction_gate_blocked` ([NEO-137 plan](../../plans/NEO-137-implementation-plan.md)). Slice 3 backlog [E7M3-pre-production-backlog.md](../../plans/E7M3-pre-production-backlog.md): **E7M3-06** [NEO-138](https://linear.app/neon-sprawl/issue/NEO-138) → **E7M3-11** [NEO-143](https://linear.app/neon-sprawl/issue/NEO-143). Upstream: E7.M1 **Ready**, E7.M2 **Ready**. | | **Linear** | Label **`E7.M3`** · [E7M3-pre-production-backlog.md](../../plans/E7M3-pre-production-backlog.md) | ## Purpose diff --git a/docs/decomposition/modules/documentation_and_implementation_alignment.md b/docs/decomposition/modules/documentation_and_implementation_alignment.md index 23311ec..0594edf 100644 --- a/docs/decomposition/modules/documentation_and_implementation_alignment.md +++ b/docs/decomposition/modules/documentation_and_implementation_alignment.md @@ -61,7 +61,7 @@ Rows appear when work starts; default for unlisted modules is **Planned** / not | E5.M3 | Ready | **E5M3-01 catalog landed ([NEO-100](https://linear.app/neon-sprawl/issue/NEO-100)):** encounter + reward-table schemas, `prototype_encounters.json`, `prototype_reward_tables.json`, CI gates. **E5M3-02 server load ([NEO-101](https://linear.app/neon-sprawl/issue/NEO-101)):** fail-fast startup loaders for encounter + reward-table catalogs (CI parity). **E5M3-03 registries ([NEO-102](https://linear.app/neon-sprawl/issue/NEO-102)):** `IEncounterDefinitionRegistry` + `IRewardTableDefinitionRegistry` + DI. **E5M3-04 HTTP read ([NEO-103](https://linear.app/neon-sprawl/issue/NEO-103)):** **`GET /game/world/encounter-definitions`** — `EncounterDefinitionsWorldApi` + nested **`rewardTable`** summary ([NEO-103](../../plans/NEO-103-implementation-plan.md)); [server README — Encounter definitions (NEO-103)](../../../server/README.md#encounter-definitions-neo-103); Bruno `bruno/neon-sprawl-server/encounter-definitions/`. **E5M3-05 stores ([NEO-104](https://linear.app/neon-sprawl/issue/NEO-104)):** **`IEncounterProgressStore`** + **`IEncounterCompletionStore`** + **`EncounterProgressOperations`** ([NEO-104](../../plans/NEO-104-implementation-plan.md)); [server README — Encounter progress (NEO-104)](../../../server/README.md#encounter-progress--completion-stores-neo-104). **E5M3-06 completion grants ([NEO-105](https://linear.app/neon-sprawl/issue/NEO-105)):** **`EncounterCompletionOperations`** + **`EncounterCompleteEvent`** result payload ([NEO-105](../../plans/NEO-105-implementation-plan.md)); [server README — Encounter completion (NEO-105)](../../../server/README.md#encounter-completion--inventory-grants-neo-105). **E5M3-07 combat wiring ([NEO-106](https://linear.app/neon-sprawl/issue/NEO-106)):** **`EncounterCombatWiring`** on **`AbilityCastApi`** ([NEO-106](../../plans/NEO-106-implementation-plan.md)); [server README — Encounter combat wiring (NEO-106)](../../../server/README.md#encounter-combat-wiring-neo-106). **E5M3-09 event record ([NEO-107](https://linear.app/neon-sprawl/issue/NEO-107)):** **`IEncounterCompleteEventStore`** + E7.M2 hook stub ([NEO-107](../../plans/NEO-107-implementation-plan.md)); [server README — Encounter complete event (NEO-107)](../../../server/README.md#encounter-complete-event-record-neo-107). **E5M3-08 per-player GET ([NEO-108](https://linear.app/neon-sprawl/issue/NEO-108)):** **`GET /game/players/{id}/encounter-progress`** — `EncounterProgressApi` + DTOs ([NEO-108](../../plans/NEO-108-implementation-plan.md)); [server README — Per-player encounter progress (NEO-108)](../../../server/README.md#per-player-encounter-progress-neo-108); Bruno `bruno/neon-sprawl-server/encounter-progress/`. **E5M3-10 telemetry ([NEO-109](https://linear.app/neon-sprawl/issue/NEO-109)):** comment-only **`encounter_start`**, **`encounter_complete`**, **`reward_attribution`**, **`encounter_complete_denied`** in **`EncounterProgressOperations`** / **`EncounterCompletionOperations`** ([NEO-109](../../plans/NEO-109-implementation-plan.md)); [server README — Encounter telemetry hooks (NEO-109)](../../../server/README.md#encounter-telemetry-hooks-neo-109). **E5M3-11 client HUD ([NEO-110](https://linear.app/neon-sprawl/issue/NEO-110)):** **`encounter_progress_client.gd`**, **`EncounterProgressLabel`** / **`EncounterCompleteLabel`**; boot + defeat-triggered GET; inventory refresh on **`completed`** ([NEO-110](../../plans/NEO-110-implementation-plan.md), [`NEO-110` manual QA](../../manual-qa/NEO-110.md)); [client README — Encounter progress + loot HUD (NEO-110)](../../../client/README.md#encounter-progress--loot-hud-neo-110). **E5M3-12 client capstone ([NEO-111](https://linear.app/neon-sprawl/issue/NEO-111)):** playable encounter clear loop — [`NEO-111` manual QA](../../manual-qa/NEO-111.md); [client README — End-to-end encounter clear loop (NEO-111)](../../../client/README.md#end-to-end-encounter-clear-loop-neo-111); plan [NEO-111](../../plans/NEO-111-implementation-plan.md). **Epic 5 Slice 3 client capstone complete.** Epic 5 Slice 3 backlog [E5M3-prototype-backlog.md](../../plans/E5M3-prototype-backlog.md) **E5M3-01** [NEO-100](https://linear.app/neon-sprawl/issue/NEO-100) → **E5M3-12** [NEO-111](https://linear.app/neon-sprawl/issue/NEO-111) **landed**. Prototype spine: **`prototype_combat_pocket`** → **`prototype_combat_pocket_clear`**; idempotent completion; per-defeat gig XP unchanged ([NEO-44](../../plans/NEO-44-implementation-plan.md)). Upstream **E5.M2 Ready**, **E3.M3** inventory landed. | [NEO-111 plan](../../plans/NEO-111-implementation-plan.md), [NEO-110 plan](../../plans/NEO-110-implementation-plan.md), [NEO-109 plan](../../plans/NEO-109-implementation-plan.md), [NEO-108 plan](../../plans/NEO-108-implementation-plan.md), [NEO-107 plan](../../plans/NEO-107-implementation-plan.md), [NEO-106 plan](../../plans/NEO-106-implementation-plan.md), [NEO-105 plan](../../plans/NEO-105-implementation-plan.md), [NEO-104 plan](../../plans/NEO-104-implementation-plan.md), [NEO-103 plan](../../plans/NEO-103-implementation-plan.md), [NEO-102 plan](../../plans/NEO-102-implementation-plan.md), [E5_M3](E5_M3_EncounterAndRewardTables.md), label **`E5.M3`** on NEO-100–NEO-111 | | E7.M2 | Ready | **E7M2-01 catalog landed ([NEO-124](https://linear.app/neon-sprawl/issue/NEO-124)):** `quest-reward-bundle` + `quest-skill-xp-grant` schemas; **`completionRewardBundle`** on four frozen E7.M1 quests; CI bundle freeze + cross-ref gates. **E7M2-02 server load ([NEO-125](https://linear.app/neon-sprawl/issue/NEO-125)):** fail-fast quest catalog **`completionRewardBundle`** validation at startup — `PrototypeE7M2QuestCatalogRules` + bundle schema `$ref` registration ([NEO-125](../../plans/NEO-125-implementation-plan.md)); [server README — Quest catalog (NEO-125)](../../../server/README.md#quest-catalog-contentquests-neo-113). **E7M2-03 delivery store ([NEO-126](https://linear.app/neon-sprawl/issue/NEO-126)):** idempotent **`IRewardDeliveryStore`** + **`RewardDeliveryEvent`** in `Game/Rewards/` — in-memory prototype ([NEO-126](../../plans/NEO-126-implementation-plan.md)); [server README — Reward delivery store (NEO-126)](../../../server/README.md#reward-delivery-store-neo-126). **E7M2-04 router apply ([NEO-127](https://linear.app/neon-sprawl/issue/NEO-127)):** **`RewardRouterOperations.TryDeliverQuestCompletion`** — item + skill XP bundle apply with compensating rollback + store record ([NEO-127](../../plans/NEO-127-implementation-plan.md)); [server README — Reward router (NEO-127)](../../../server/README.md#reward-router-neo-127). **E7M2-05 quest-state wiring ([NEO-128](https://linear.app/neon-sprawl/issue/NEO-128)):** **`QuestStateOperations.TryMarkComplete`** + **`QuestObjectiveWiring`** deliver-then-mark via router ([NEO-128](../../plans/NEO-128-implementation-plan.md)); [server README — Quest state operations (NEO-117)](../../../server/README.md#quest-state-operations-neo-117). **E7M2-06 HTTP read ([NEO-129](https://linear.app/neon-sprawl/issue/NEO-129)):** **`GET …/quest-progress`** **`completionRewardSummary`** from **`IRewardDeliveryStore`** ([NEO-129](../../plans/NEO-129-implementation-plan.md)); Bruno `bruno/neon-sprawl-server/quest-progress/Get quest progress after gather intro complete.bru`. **E7M2-07 telemetry ([NEO-130](https://linear.app/neon-sprawl/issue/NEO-130)):** comment-only **`reward_delivery`** + **`unlock_granted`** stub hook sites in **`RewardRouterOperations.TryDeliverQuestCompletion`** ([NEO-130](../../plans/NEO-130-implementation-plan.md)); [server README — Reward telemetry hooks (NEO-130)](../../../server/README.md#reward-telemetry-hooks-neo-130). **E7M2-08 client HUD ([NEO-131](https://linear.app/neon-sprawl/issue/NEO-131)):** Godot **`QuestRewardDeliveryLabel`** paints **`completionRewardSummary`** on in-session completion transition ([NEO-131](../../plans/NEO-131-implementation-plan.md)); [client README — Quest completion reward HUD (NEO-131)](../../../client/README.md#quest-completion-reward-hud-neo-131). **E7M2-09 client capstone ([NEO-132](https://linear.app/neon-sprawl/issue/NEO-132)):** playable quest reward delivery loop — [`NEO-132` manual QA](../../manual-qa/NEO-132.md); [client README — End-to-end quest reward loop (NEO-132)](../../../client/README.md#end-to-end-quest-reward-loop-neo-132); plan [NEO-132](../../plans/NEO-132-implementation-plan.md). **Epic 7 Slice 2 client capstone complete.** Backlog **E7M2-01** [NEO-124](https://linear.app/neon-sprawl/issue/NEO-124) → **E7M2-09** [NEO-132](https://linear.app/neon-sprawl/issue/NEO-132) **landed**. **NEO-43 prep landed:** **`MissionRewardSkillXpGrant`**. **Encounter loot unchanged** (E5.M3 direct grants). Upstream: E7.M1 **Ready**, E2.M2 grant stack, E3.M3 inventory **Ready**. | [E7M2-prototype-backlog.md](../../plans/E7M2-prototype-backlog.md), [E7_M2](E7_M2_RewardAndUnlockRouter.md), [NEO-124](../../plans/NEO-124-implementation-plan.md), [NEO-125](../../plans/NEO-125-implementation-plan.md), [NEO-126](../../plans/NEO-126-implementation-plan.md), [NEO-127](../../plans/NEO-127-implementation-plan.md), [NEO-128](../../plans/NEO-128-implementation-plan.md), [NEO-129](../../plans/NEO-129-implementation-plan.md), [NEO-130](../../plans/NEO-130-implementation-plan.md), [NEO-131](../../plans/NEO-131-implementation-plan.md), [NEO-132](../../plans/NEO-132-implementation-plan.md), [NEO-43](../../plans/NEO-43-implementation-plan.md), label **`E7.M2`** on NEO-124–NEO-132 | | E7.M1 | Ready | **E7M1-01 catalog landed ([NEO-112](https://linear.app/neon-sprawl/issue/NEO-112)):** quest schemas, `prototype_quests.json`, CI gates (four frozen quest ids, objective cross-refs, acyclic prerequisites, chain terminal token). **E7M1-02 server load ([NEO-113](https://linear.app/neon-sprawl/issue/NEO-113)):** fail-fast startup load of `content/quests/*_quests.json` — `server/NeonSprawl.Server/Game/Quests/` ([NEO-113](../../plans/NEO-113-implementation-plan.md)); [server README — Quest catalog](../../../server/README.md#quest-catalog-contentquests-neo-113). **E7M1-03 registry ([NEO-114](https://linear.app/neon-sprawl/issue/NEO-114)):** **`IQuestDefinitionRegistry`** + DI ([NEO-114](../../plans/NEO-114-implementation-plan.md)). **E7M1-04 HTTP read ([NEO-115](https://linear.app/neon-sprawl/issue/NEO-115)):** **`GET /game/world/quest-definitions`** — `QuestDefinitionsWorldApi` + DTOs ([NEO-115](../../plans/NEO-115-implementation-plan.md)); [server README — Quest definitions (NEO-115)](../../../server/README.md#quest-definitions-neo-115); Bruno `bruno/neon-sprawl-server/quest-definitions/`. **E7M1-05 store ([NEO-116](https://linear.app/neon-sprawl/issue/NEO-116)):** **`IPlayerQuestStateStore`** + in-memory/Postgres persistence ([NEO-116](../../plans/NEO-116-implementation-plan.md)); [server README — Quest progress store (NEO-116)](../../../server/README.md#quest-progress-store-neo-116). **E7M1-06 operations ([NEO-117](https://linear.app/neon-sprawl/issue/NEO-117)):** **`QuestStateOperations`** + reason codes ([NEO-117](../../plans/NEO-117-implementation-plan.md)); [server README — Quest state operations (NEO-117)](../../../server/README.md#quest-state-operations-neo-117). **E7M1-07 objective wiring ([NEO-118](https://linear.app/neon-sprawl/issue/NEO-118)):** **`QuestObjectiveWiring`** on gather/craft/encounter + **`inventory_has_item`** snapshot passes ([NEO-118](../../plans/NEO-118-implementation-plan.md)); [server README — Quest objective wiring (NEO-118)](../../../server/README.md#quest-objective-wiring-neo-118). **E7M1-08 per-player GET ([NEO-119](https://linear.app/neon-sprawl/issue/NEO-119)):** **`GET /game/players/{id}/quest-progress`** — `QuestProgressApi` + DTOs; GET-side inventory refresh ([NEO-119](../../plans/NEO-119-implementation-plan.md)); [server README — Per-player quest progress (NEO-119)](../../../server/README.md#per-player-quest-progress-neo-119); Bruno `bruno/neon-sprawl-server/quest-progress/`. **E7M1-09 accept POST ([NEO-120](https://linear.app/neon-sprawl/issue/NEO-120)):** **`POST /game/players/{id}/quests/{questId}/accept`** — `QuestAcceptApi` + DTOs; **`QuestStateOperations.TryAccept`** ([NEO-120](../../plans/NEO-120-implementation-plan.md)); [server README — Quest accept POST (NEO-120)](../../../server/README.md#quest-accept-post-neo-120); Bruno accept spine in `bruno/neon-sprawl-server/quest-progress/`. **E7M1-10 telemetry ([NEO-121](https://linear.app/neon-sprawl/issue/NEO-121)):** comment-only **`quest_start`**, **`quest_step_complete`**, **`quest_complete`**, **`quest_accept_denied`** hook sites in **`QuestStateOperations`** ([NEO-121](../../plans/NEO-121-implementation-plan.md)); [server README — Quest telemetry hooks (NEO-121)](../../../server/README.md#quest-telemetry-hooks-neo-121). **E7M1-11 client HUD ([NEO-122](https://linear.app/neon-sprawl/issue/NEO-122)):** **`quest_progress_client.gd`**, **`quest_definitions_client.gd`**, **`QuestProgressLabel`** / **`QuestAcceptFeedbackLabel`**; boot + event-driven GET refresh; **Q** / **Shift+Q** accept ([NEO-122](../../plans/NEO-122-implementation-plan.md), [`NEO-122` manual QA](../../manual-qa/NEO-122.md)); [client README — Quest progress + accept HUD (NEO-122)](../../../client/README.md#quest-progress--accept-hud-neo-122). **E7M1-12 client capstone ([NEO-123](https://linear.app/neon-sprawl/issue/NEO-123)):** playable four-quest onboarding chain — [`NEO-123` manual QA](../../manual-qa/NEO-123.md); [client README — End-to-end onboarding quest loop (NEO-123)](../../../client/README.md#end-to-end-onboarding-quest-loop-neo-123); plan [NEO-123](../../plans/NEO-123-implementation-plan.md). **Epic 7 Slice 1 client capstone complete.** Backlog **E7M1-01** [NEO-112](https://linear.app/neon-sprawl/issue/NEO-112) → **E7M1-12** [NEO-123](https://linear.app/neon-sprawl/issue/NEO-123) **landed**. Upstream: E3.M1 gather **Ready**, E3.M2 craft **Ready**, E5.M3 encounter **`contract_handoff_token`** + **`EncounterCompleteEvent`** **Ready**. | [NEO-123 plan](../../plans/NEO-123-implementation-plan.md), [NEO-122 plan](../../plans/NEO-122-implementation-plan.md), [NEO-121 plan](../../plans/NEO-121-implementation-plan.md), [NEO-120 plan](../../plans/NEO-120-implementation-plan.md), [NEO-119 plan](../../plans/NEO-119-implementation-plan.md), [NEO-118 plan](../../plans/NEO-118-implementation-plan.md), [NEO-117 plan](../../plans/NEO-117-implementation-plan.md), [NEO-116 plan](../../plans/NEO-116-implementation-plan.md), [NEO-115 plan](../../plans/NEO-115-implementation-plan.md), [NEO-114 plan](../../plans/NEO-114-implementation-plan.md), [NEO-113 plan](../../plans/NEO-113-implementation-plan.md), [NEO-112 plan](../../plans/NEO-112-implementation-plan.md), [E7M1-prototype-backlog.md](../../plans/E7M1-prototype-backlog.md), [E7_M1](E7_M1_QuestStateMachine.md), label **`E7.M1`** on NEO-112–NEO-123 | -| E7.M3 | In Progress | **E7M3-01 catalog landed ([NEO-133](https://linear.app/neon-sprawl/issue/NEO-133)):** faction + gate/rep schemas, `prototype_factions.json`, quest extensions, five-quest CI gates, minimal server roster parity. **E7M3-02 server load landed ([NEO-134](https://linear.app/neon-sprawl/issue/NEO-134)):** fail-fast faction catalog, `IFactionDefinitionRegistry`, quest `factionGateRules` / `reputationGrants` parse + E7M3 cross-ref/bundle/grid gates ([NEO-134 plan](../../plans/NEO-134-implementation-plan.md)). **E7M3-03 stores landed ([NEO-135](https://linear.app/neon-sprawl/issue/NEO-135)):** `IFactionStandingStore`, `IReputationDeltaStore`, in-memory + Postgres `V009`/`V010` ([NEO-135 plan](../../plans/NEO-135-implementation-plan.md)); [server README — Faction standing store (NEO-135)](../../../server/README.md#faction-standing-store-neo-135). **E7M3-04 ops landed ([NEO-136](https://linear.app/neon-sprawl/issue/NEO-136)):** `ReputationOperations.TryApplyDelta` — standing + audit orchestration with compensating rollback ([NEO-136 plan](../../plans/NEO-136-implementation-plan.md)); [server README — ReputationOperations (NEO-136)](../../../server/README.md#reputationoperations-neo-136). **E7M3-05+** [NEO-137](https://linear.app/neon-sprawl/issue/NEO-137) → **E7M3-11** [NEO-143](https://linear.app/neon-sprawl/issue/NEO-143). Two frozen factions; operator-chain **`reputationGrants`** (+15 Grid Operators); gated **`prototype_quest_grid_contract`**; client capstone [NEO-143](https://linear.app/neon-sprawl/issue/NEO-143). Upstream: E7.M1 **Ready**, E7.M2 **Ready**. | [NEO-133 plan](../../plans/NEO-133-implementation-plan.md), [NEO-134 plan](../../plans/NEO-134-implementation-plan.md), [NEO-135 plan](../../plans/NEO-135-implementation-plan.md), [NEO-136 plan](../../plans/NEO-136-implementation-plan.md), [E7M3-pre-production-backlog.md](../../plans/E7M3-pre-production-backlog.md), [E7_M3](E7_M3_FactionReputationLedger.md), label **`E7.M3`** on NEO-133–NEO-143 | +| E7.M3 | In Progress | **E7M3-01 catalog landed ([NEO-133](https://linear.app/neon-sprawl/issue/NEO-133)):** faction + gate/rep schemas, `prototype_factions.json`, quest extensions, five-quest CI gates, minimal server roster parity. **E7M3-02 server load landed ([NEO-134](https://linear.app/neon-sprawl/issue/NEO-134)):** fail-fast faction catalog, `IFactionDefinitionRegistry`, quest `factionGateRules` / `reputationGrants` parse + E7M3 cross-ref/bundle/grid gates ([NEO-134 plan](../../plans/NEO-134-implementation-plan.md)). **E7M3-03 stores landed ([NEO-135](https://linear.app/neon-sprawl/issue/NEO-135)):** `IFactionStandingStore`, `IReputationDeltaStore`, in-memory + Postgres `V009`/`V010` ([NEO-135 plan](../../plans/NEO-135-implementation-plan.md)); [server README — Faction standing store (NEO-135)](../../../server/README.md#faction-standing-store-neo-135). **E7M3-04 ops landed ([NEO-136](https://linear.app/neon-sprawl/issue/NEO-136)):** `ReputationOperations.TryApplyDelta` — standing + audit orchestration with compensating rollback ([NEO-136 plan](../../plans/NEO-136-implementation-plan.md)); [server README — ReputationOperations (NEO-136)](../../../server/README.md#reputationoperations-neo-136). **E7M3-05 gate eval landed ([NEO-137](https://linear.app/neon-sprawl/issue/NEO-137)):** `FactionGateOperations.TryEvaluate` wired into `QuestStateOperations.TryAccept`; `faction_gate_blocked` deny ([NEO-137 plan](../../plans/NEO-137-implementation-plan.md)); [server README — FactionGateOperations (NEO-137)](../../../server/README.md#factiongateoperations-neo-137). **E7M3-06+** [NEO-138](https://linear.app/neon-sprawl/issue/NEO-138) → **E7M3-11** [NEO-143](https://linear.app/neon-sprawl/issue/NEO-143). Two frozen factions; operator-chain **`reputationGrants`** (+15 Grid Operators); gated **`prototype_quest_grid_contract`**; client capstone [NEO-143](https://linear.app/neon-sprawl/issue/NEO-143). Upstream: E7.M1 **Ready**, E7.M2 **Ready**. | [NEO-133 plan](../../plans/NEO-133-implementation-plan.md), [NEO-134 plan](../../plans/NEO-134-implementation-plan.md), [NEO-135 plan](../../plans/NEO-135-implementation-plan.md), [NEO-136 plan](../../plans/NEO-136-implementation-plan.md), [NEO-137 plan](../../plans/NEO-137-implementation-plan.md), [E7M3-pre-production-backlog.md](../../plans/E7M3-pre-production-backlog.md), [E7_M3](E7_M3_FactionReputationLedger.md), label **`E7.M3`** on NEO-133–NEO-143 | --- diff --git a/docs/plans/NEO-137-implementation-plan.md b/docs/plans/NEO-137-implementation-plan.md index 4677d2a..3a491c1 100644 --- a/docs/plans/NEO-137-implementation-plan.md +++ b/docs/plans/NEO-137-implementation-plan.md @@ -56,9 +56,18 @@ Other decisions settled by Linear AC, backlog, and repo precedent (no additional ## Acceptance criteria checklist -- [ ] Accept returns **`faction_gate_blocked`** when standing below **`minStanding`**. -- [ ] Accept succeeds when all rules satisfied. -- [ ] `dotnet test` covers gate deny, threshold success, and no-gate quests. +- [x] Accept returns **`faction_gate_blocked`** when standing below **`minStanding`**. +- [x] Accept succeeds when all rules satisfied. +- [x] `dotnet test` covers gate deny, threshold success, and no-gate quests. + +## Implementation reconciliation (shipped) + +- **Operations:** `FactionGateOperations.TryEvaluate` — AND gate eval via standing store reads. +- **Types:** `FactionGateEvaluateOutcome`, `FactionGateEvaluateReasonCodes`. +- **Wire:** `QuestStateOperations.TryAccept` + `QuestAcceptApi` inject `IFactionStandingStore`; `QuestStateReasonCodes.FactionGateBlocked`. +- **Tests:** `FactionGateOperationsTests` (5 cases), grid contract integration in `QuestStateOperationsTests` + `QuestAcceptApiTests` (790 tests green). +- **Bruno:** deny-only `Accept grid contract faction gate deny.bru`; success deferred to NEO-138. +- **Docs:** `server/README.md` FactionGateOperations section; E7.M3 module + alignment register updated. ## Technical approach diff --git a/server/NeonSprawl.Server.Tests/Game/Factions/FactionGateOperationsTests.cs b/server/NeonSprawl.Server.Tests/Game/Factions/FactionGateOperationsTests.cs new file mode 100644 index 0000000..a396cf6 --- /dev/null +++ b/server/NeonSprawl.Server.Tests/Game/Factions/FactionGateOperationsTests.cs @@ -0,0 +1,111 @@ +using Microsoft.Extensions.DependencyInjection; +using Microsoft.Extensions.Options; +using NeonSprawl.Server.Game.Factions; +using NeonSprawl.Server.Game.PositionState; +using NeonSprawl.Server.Game.Quests; +using NeonSprawl.Server.Tests; +using Xunit; + +namespace NeonSprawl.Server.Tests.Game.Factions; + +public sealed class FactionGateOperationsTests +{ + private const string PlayerId = "dev-local-1"; + private const string GridFactionId = PrototypeE7M3QuestFactionRules.GridContractGateFactionId; + private const int GridMinStanding = PrototypeE7M3QuestFactionRules.GridContractMinStanding; + + [Fact] + public void TryEvaluate_ShouldPass_WhenRulesEmpty() + { + // Arrange + var standingStore = CreateStandingStore(); + // Act + var outcome = FactionGateOperations.TryEvaluate(PlayerId, [], standingStore); + // Assert + Assert.True(outcome.Success); + Assert.Null(outcome.ReasonCode); + Assert.Null(outcome.FailingFactionId); + } + + [Fact] + public void TryEvaluate_ShouldPass_WhenStandingAtMin() + { + // Arrange + var standingStore = CreateStandingStore(); + Assert.True(standingStore.TryApplyStandingDelta(PlayerId, GridFactionId, GridMinStanding).Success); + var rules = new[] { new FactionGateRuleRow(GridFactionId, GridMinStanding) }; + // Act + var outcome = FactionGateOperations.TryEvaluate(PlayerId, rules, standingStore); + // Assert + Assert.True(outcome.Success); + Assert.Null(outcome.ReasonCode); + } + + [Fact] + public void TryEvaluate_ShouldDeny_WhenStandingBelowMin() + { + // Arrange + var standingStore = CreateStandingStore(); + Assert.True(standingStore.TryApplyStandingDelta(PlayerId, GridFactionId, GridMinStanding - 1).Success); + var rules = new[] { new FactionGateRuleRow(GridFactionId, GridMinStanding) }; + // Act + var outcome = FactionGateOperations.TryEvaluate(PlayerId, rules, standingStore); + // Assert + Assert.False(outcome.Success); + Assert.Equal(FactionGateEvaluateReasonCodes.GateBlocked, outcome.ReasonCode); + Assert.Equal(GridFactionId, outcome.FailingFactionId); + Assert.Equal(GridMinStanding, outcome.RequiredMinStanding); + Assert.Equal(GridMinStanding - 1, outcome.CurrentStanding); + } + + [Fact] + public void TryEvaluate_ShouldDenyUnknownFaction_WhenStoreDenies() + { + // Arrange + var standingStore = CreateStandingStore(); + const string unknownFactionId = "prototype_faction_missing"; + var rules = new[] { new FactionGateRuleRow(unknownFactionId, 0) }; + // Act + var outcome = FactionGateOperations.TryEvaluate(PlayerId, rules, standingStore); + // Assert + Assert.False(outcome.Success); + Assert.Equal(FactionStandingReasonCodes.UnknownFaction, outcome.ReasonCode); + Assert.Equal(unknownFactionId, outcome.FailingFactionId); + } + + [Fact] + public async Task Host_ShouldResolveStandingStoreForGateEval_WhenStartupSucceeds() + { + // Arrange + await using var factory = new InMemoryWebApplicationFactory(); + using var client = factory.CreateClient(); + _ = await client.GetAsync("/health"); + var standingStore = factory.Services.GetRequiredService(); + var rules = new[] { new FactionGateRuleRow(GridFactionId, GridMinStanding) }; + // Act + var outcome = FactionGateOperations.TryEvaluate(PlayerId, rules, standingStore); + // Assert + Assert.False(outcome.Success); + Assert.Equal(FactionGateEvaluateReasonCodes.GateBlocked, outcome.ReasonCode); + } + + private static InMemoryFactionStandingStore CreateStandingStore() + { + var registry = CreatePrototypeRegistry(); + var options = Options.Create(new GamePositionOptions { DevPlayerId = PlayerId }); + return new InMemoryFactionStandingStore(options, registry); + } + + private static FactionDefinitionRegistry CreatePrototypeRegistry() + { + var gridFactionId = PrototypeE7M3QuestFactionRules.GridContractGateFactionId; + var rustFactionId = "prototype_faction_rust_collective"; + var byId = new Dictionary(StringComparer.Ordinal) + { + [gridFactionId] = PrototypeE7M3FactionCatalogRules.ExpectedFactionFreeze[gridFactionId], + [rustFactionId] = PrototypeE7M3FactionCatalogRules.ExpectedFactionFreeze[rustFactionId], + }; + var catalog = new FactionDefinitionCatalog("/tmp/catalog", byId, catalogJsonFileCount: 1); + return new FactionDefinitionRegistry(catalog); + } +} diff --git a/server/NeonSprawl.Server.Tests/Game/Quests/QuestAcceptApiTests.cs b/server/NeonSprawl.Server.Tests/Game/Quests/QuestAcceptApiTests.cs index 5df5ff9..a2029c5 100644 --- a/server/NeonSprawl.Server.Tests/Game/Quests/QuestAcceptApiTests.cs +++ b/server/NeonSprawl.Server.Tests/Game/Quests/QuestAcceptApiTests.cs @@ -3,6 +3,7 @@ using System.Net.Http.Json; using System.Text; using System.Text.Json; using Microsoft.Extensions.DependencyInjection; +using NeonSprawl.Server.Game.Factions; using NeonSprawl.Server.Game.Items; using NeonSprawl.Server.Game.Mastery; using NeonSprawl.Server.Game.Quests; @@ -18,6 +19,8 @@ public sealed class QuestAcceptApiTests private const string PlayerId = "dev-local-1"; private const string GatherQuestId = PrototypeE7M1QuestCatalogRules.GatherIntroQuestId; private const string RefineQuestId = PrototypeE7M1QuestCatalogRules.RefineIntroQuestId; + private const string ChainQuestId = PrototypeE7M1QuestCatalogRules.ChainQuestId; + private const string GridContractQuestId = PrototypeE7M1QuestCatalogRules.GridContractQuestId; [Fact] public async Task PostQuestAccept_ShouldReturnNotFound_WhenPlayerUnknown() @@ -217,6 +220,7 @@ public sealed class QuestAcceptApiTests var perkUnlockEngine = services.GetRequiredService(); var perkStore = services.GetRequiredService(); var deliveryStore = services.GetRequiredService(); + var standingStore = services.GetRequiredService(); var timeProvider = TimeProvider.System; Assert.True(QuestStateOperations.TryAccept( PlayerId, @@ -231,6 +235,7 @@ public sealed class QuestAcceptApiTests perkUnlockEngine, perkStore, deliveryStore, + standingStore, timeProvider).Success); Assert.True(QuestStateOperations.TryMarkComplete( PlayerId, @@ -289,4 +294,28 @@ public sealed class QuestAcceptApiTests Assert.Equal(QuestStateReasonCodes.UnknownQuest, body.ReasonCode); Assert.Null(body.Quest); } + + [Fact] + public async Task PostQuestAccept_ShouldDenyFactionGateBlocked_WhenGridContractBelowThreshold() + { + // Arrange + await using var factory = new InMemoryWebApplicationFactory(); + var client = factory.CreateClient(); + var progressStore = factory.Services.GetRequiredService(); + Assert.True(progressStore.TryActivate(PlayerId, ChainQuestId, out _)); + Assert.True(progressStore.TryMarkComplete(PlayerId, ChainQuestId, DateTimeOffset.UtcNow, out _)); + + // Act + var response = await client.PostAsync( + $"/game/players/{PlayerId}/quests/{GridContractQuestId}/accept", + JsonContent.Create(new QuestAcceptRequest { SchemaVersion = QuestAcceptRequest.CurrentSchemaVersion })); + + // Assert + Assert.Equal(HttpStatusCode.OK, response.StatusCode); + var body = await response.Content.ReadFromJsonAsync(); + Assert.NotNull(body); + Assert.False(body!.Accepted); + Assert.Equal(QuestStateReasonCodes.FactionGateBlocked, body.ReasonCode); + Assert.Null(body.Quest); + } } diff --git a/server/NeonSprawl.Server.Tests/Game/Quests/QuestObjectiveWiringTests.cs b/server/NeonSprawl.Server.Tests/Game/Quests/QuestObjectiveWiringTests.cs index 518342d..530ba2a 100644 --- a/server/NeonSprawl.Server.Tests/Game/Quests/QuestObjectiveWiringTests.cs +++ b/server/NeonSprawl.Server.Tests/Game/Quests/QuestObjectiveWiringTests.cs @@ -1,6 +1,7 @@ using Microsoft.Extensions.DependencyInjection; using NeonSprawl.Server.Game.Crafting; using NeonSprawl.Server.Game.Encounters; +using NeonSprawl.Server.Game.Factions; using NeonSprawl.Server.Game.Gathering; using NeonSprawl.Server.Game.Items; using NeonSprawl.Server.Game.Mastery; @@ -302,6 +303,7 @@ public sealed class QuestObjectiveWiringTests deps.PerkUnlockEngine, deps.PerkStore, deps.DeliveryStore, + deps.StandingStore, deps.TimeProvider); private static QuestStateOperationResult TryAdvanceStep(QuestWiringTestDependencies deps, string questId, int step) => @@ -442,6 +444,7 @@ public sealed class QuestObjectiveWiringTests services.GetRequiredService(), services.GetRequiredService(), services.GetRequiredService(), + services.GetRequiredService(), TimeProvider.System); } @@ -464,5 +467,6 @@ public sealed class QuestObjectiveWiringTests IEncounterCompleteEventStore CompleteEventStore, IPlayerPerkStateStore PerkStore, IRewardDeliveryStore DeliveryStore, + IFactionStandingStore StandingStore, TimeProvider TimeProvider); } diff --git a/server/NeonSprawl.Server.Tests/Game/Quests/QuestProgressApiTests.cs b/server/NeonSprawl.Server.Tests/Game/Quests/QuestProgressApiTests.cs index eceb0fd..2cdec63 100644 --- a/server/NeonSprawl.Server.Tests/Game/Quests/QuestProgressApiTests.cs +++ b/server/NeonSprawl.Server.Tests/Game/Quests/QuestProgressApiTests.cs @@ -3,6 +3,7 @@ using System.Net.Http.Json; using Microsoft.Extensions.DependencyInjection; using NeonSprawl.Server.Game.Crafting; using NeonSprawl.Server.Game.Encounters; +using NeonSprawl.Server.Game.Factions; using NeonSprawl.Server.Game.Gathering; using NeonSprawl.Server.Game.Items; using NeonSprawl.Server.Game.Mastery; @@ -400,6 +401,7 @@ public sealed class QuestProgressApiTests deps.PerkUnlockEngine, deps.PerkStore, deps.DeliveryStore, + deps.StandingStore, deps.TimeProvider); private static QuestStateOperationResult TryMarkComplete(QuestWiringTestDependencies deps, string questId) => @@ -493,6 +495,7 @@ public sealed class QuestProgressApiTests services.GetRequiredService(), services.GetRequiredService(), services.GetRequiredService(), + services.GetRequiredService(), TimeProvider.System); } @@ -515,5 +518,6 @@ public sealed class QuestProgressApiTests IEncounterCompleteEventStore CompleteEventStore, IPlayerPerkStateStore PerkStore, IRewardDeliveryStore DeliveryStore, + IFactionStandingStore StandingStore, TimeProvider TimeProvider); } diff --git a/server/NeonSprawl.Server.Tests/Game/Quests/QuestStateOperationsTests.cs b/server/NeonSprawl.Server.Tests/Game/Quests/QuestStateOperationsTests.cs index 3d39198..40dbed5 100644 --- a/server/NeonSprawl.Server.Tests/Game/Quests/QuestStateOperationsTests.cs +++ b/server/NeonSprawl.Server.Tests/Game/Quests/QuestStateOperationsTests.cs @@ -1,4 +1,5 @@ using Microsoft.Extensions.DependencyInjection; +using NeonSprawl.Server.Game.Factions; using NeonSprawl.Server.Game.Items; using NeonSprawl.Server.Game.Mastery; using NeonSprawl.Server.Game.PositionState; @@ -19,6 +20,62 @@ public sealed class QuestStateOperationsTests private const string CombatQuestId = PrototypeE7M1QuestCatalogRules.CombatIntroQuestId; private const string ChainQuestId = PrototypeE7M1QuestCatalogRules.ChainQuestId; private const string ChainObjectiveId = PrototypeE7M1QuestCatalogRules.ChainFirstObjectiveId; + private const string GridContractQuestId = PrototypeE7M1QuestCatalogRules.GridContractQuestId; + private const string GridFactionId = PrototypeE7M3QuestFactionRules.GridContractGateFactionId; + + [Fact] + public async Task TryAccept_ShouldDenyFactionGateBlocked_WhenGridContractBelowThreshold() + { + // Arrange + await using var factory = new InMemoryWebApplicationFactory(); + var deps = ResolveDependencies(factory); + CompleteChainPrerequisite(deps); + + // Act + var result = TryAccept(deps, GridContractQuestId); + + // Assert + Assert.False(result.Success); + Assert.Equal(QuestStateReasonCodes.FactionGateBlocked, result.ReasonCode); + Assert.Null(result.Snapshot); + Assert.False(deps.ProgressStore.TryGetProgress(PlayerId, GridContractQuestId, out _)); + } + + [Fact] + public async Task TryAccept_ShouldAcceptGridContract_WhenStandingAtThreshold() + { + // Arrange + await using var factory = new InMemoryWebApplicationFactory(); + var deps = ResolveDependencies(factory); + CompleteChainPrerequisite(deps); + SeedGridStanding(deps, PrototypeE7M3QuestFactionRules.GridContractMinStanding); + + // Act + var result = TryAccept(deps, GridContractQuestId); + + // Assert + Assert.True(result.Success); + Assert.Null(result.ReasonCode); + Assert.NotNull(result.Snapshot); + Assert.Equal(QuestProgressStatus.Active, result.Snapshot!.Status); + } + + [Fact] + public async Task TryAccept_ShouldDenyFactionGateBlocked_WhenStandingOneBelowThreshold() + { + // Arrange + await using var factory = new InMemoryWebApplicationFactory(); + var deps = ResolveDependencies(factory); + CompleteChainPrerequisite(deps); + SeedGridStanding(deps, PrototypeE7M3QuestFactionRules.GridContractMinStanding - 1); + + // Act + var result = TryAccept(deps, GridContractQuestId); + + // Assert + Assert.False(result.Success); + Assert.Equal(QuestStateReasonCodes.FactionGateBlocked, result.ReasonCode); + } [Fact] public async Task TryAccept_ShouldActivateGatherIntro_WhenNotStarted() @@ -438,6 +495,38 @@ public sealed class QuestStateOperationsTests Assert.True(canWrite); } + private static void CompleteChainPrerequisite(QuestTestDependencies deps) + { + Assert.True(deps.ProgressStore.TryActivate(PlayerId, ChainQuestId, out _)); + Assert.True(deps.ProgressStore.TryMarkComplete( + PlayerId, + ChainQuestId, + DateTimeOffset.UtcNow, + out _)); + } + + private static void SeedGridStanding(QuestTestDependencies deps, int standing) + { + if (standing == 0) + { + return; + } + + var auditStore = deps.ReputationDeltaStore; + var outcome = ReputationOperations.TryApplyDelta( + PlayerId, + GridFactionId, + standing, + $"seed-{standing}", + ReputationDeltaSourceKinds.QuestCompletion, + ChainQuestId, + deps.StandingStore, + auditStore, + deps.TimeProvider); + Assert.True(outcome.Success); + Assert.Equal(standing, deps.StandingStore.TryGetStanding(PlayerId, GridFactionId).Standing); + } + private static int CountBagItem(PlayerInventorySnapshot snapshot, string itemId) { var total = 0; @@ -505,6 +594,7 @@ public sealed class QuestStateOperationsTests deps.PerkUnlockEngine, deps.PerkStore, deps.DeliveryStore, + deps.StandingStore, deps.TimeProvider); private static QuestStateOperationResult TryAdvanceStep(QuestTestDependencies deps, string questId, int newStepIndex) => @@ -538,6 +628,8 @@ public sealed class QuestStateOperationsTests services.GetRequiredService(), services.GetRequiredService(), services.GetRequiredService(), + services.GetRequiredService(), + services.GetRequiredService(), TimeProvider.System); } @@ -552,5 +644,7 @@ public sealed class QuestStateOperationsTests PerkUnlockEngine PerkUnlockEngine, IPlayerPerkStateStore PerkStore, IRewardDeliveryStore DeliveryStore, + IFactionStandingStore StandingStore, + IReputationDeltaStore ReputationDeltaStore, TimeProvider TimeProvider); } diff --git a/server/NeonSprawl.Server/Game/Factions/FactionGateEvaluateOutcome.cs b/server/NeonSprawl.Server/Game/Factions/FactionGateEvaluateOutcome.cs new file mode 100644 index 0000000..9996cec --- /dev/null +++ b/server/NeonSprawl.Server/Game/Factions/FactionGateEvaluateOutcome.cs @@ -0,0 +1,9 @@ +namespace NeonSprawl.Server.Game.Factions; + +/// Result of (NEO-137). +public readonly record struct FactionGateEvaluateOutcome( + bool Success, + string? ReasonCode, + string? FailingFactionId, + int? RequiredMinStanding, + int? CurrentStanding); diff --git a/server/NeonSprawl.Server/Game/Factions/FactionGateEvaluateReasonCodes.cs b/server/NeonSprawl.Server/Game/Factions/FactionGateEvaluateReasonCodes.cs new file mode 100644 index 0000000..3e798e5 --- /dev/null +++ b/server/NeonSprawl.Server/Game/Factions/FactionGateEvaluateReasonCodes.cs @@ -0,0 +1,7 @@ +namespace NeonSprawl.Server.Game.Factions; + +/// Stable deny reason codes for (NEO-137). +public static class FactionGateEvaluateReasonCodes +{ + public const string GateBlocked = "gate_blocked"; +} diff --git a/server/NeonSprawl.Server/Game/Factions/FactionGateOperations.cs b/server/NeonSprawl.Server/Game/Factions/FactionGateOperations.cs new file mode 100644 index 0000000..5d28dfa --- /dev/null +++ b/server/NeonSprawl.Server/Game/Factions/FactionGateOperations.cs @@ -0,0 +1,61 @@ +using NeonSprawl.Server.Game.Quests; + +namespace NeonSprawl.Server.Game.Factions; + +/// +/// Evaluates minimum-standing gates (NEO-137). +/// Quest accept wiring: . +/// NEO-141 telemetry hook site: deny return path below. +/// +public static class FactionGateOperations +{ + /// + /// All rules must pass (AND). Empty rules succeed immediately. + /// Compares player standing vs with standing >= minStanding. + /// + public static FactionGateEvaluateOutcome TryEvaluate( + string playerId, + IReadOnlyList rules, + IFactionStandingStore standingStore) + { + var normalizedPlayerId = FactionStandingIds.NormalizePlayerId(playerId); + if (rules.Count == 0) + { + return Success(); + } + + foreach (var rule in rules) + { + var factionId = FactionStandingIds.NormalizeFactionId(rule.FactionId); + var read = standingStore.TryGetStanding(normalizedPlayerId, factionId); + if (!read.Success) + { + return Deny(read.ReasonCode, factionId, rule.MinStanding, null); + } + + if (read.Standing < rule.MinStanding) + { + // --- Telemetry hook site (NEO-141): future E9.M1 catalog event `faction_gate_blocked` --- + // TODO(E9.M1): catalog emit — playerId, factionId, minStanding, currentStanding, gate context. + // No ingest or ILogger here (comments-only). + return Deny( + FactionGateEvaluateReasonCodes.GateBlocked, + factionId, + rule.MinStanding, + read.Standing); + } + } + + return Success(); + } + + private static FactionGateEvaluateOutcome Success() => + new(true, null, null, null, null); + + private static FactionGateEvaluateOutcome Deny( + string? reasonCode, + string factionId, + int minStanding, + int? currentStanding) => + new(false, reasonCode, factionId, minStanding, currentStanding); +} diff --git a/server/NeonSprawl.Server/Game/Quests/QuestAcceptApi.cs b/server/NeonSprawl.Server/Game/Quests/QuestAcceptApi.cs index 90efda5..94f7330 100644 --- a/server/NeonSprawl.Server/Game/Quests/QuestAcceptApi.cs +++ b/server/NeonSprawl.Server/Game/Quests/QuestAcceptApi.cs @@ -1,3 +1,4 @@ +using NeonSprawl.Server.Game.Factions; using NeonSprawl.Server.Game.Items; using NeonSprawl.Server.Game.Mastery; using NeonSprawl.Server.Game.PositionState; @@ -18,7 +19,8 @@ public static class QuestAcceptApi IPlayerInventoryStore inventoryStore, IItemDefinitionRegistry itemRegistry, ISkillDefinitionRegistry skillRegistry, IPlayerSkillProgressionStore skillProgressionStore, ISkillLevelCurve levelCurve, PerkUnlockEngine perkUnlockEngine, IPlayerPerkStateStore perkStore, - IRewardDeliveryStore deliveryStore, TimeProvider timeProvider) => + IRewardDeliveryStore deliveryStore, IFactionStandingStore standingStore, + TimeProvider timeProvider) => { if (body is not null && body.SchemaVersion != 0 && @@ -46,6 +48,7 @@ public static class QuestAcceptApi perkUnlockEngine, perkStore, deliveryStore, + standingStore, timeProvider); return Results.Json(MapResponse(trimmedId, deliveryStore, result)); diff --git a/server/NeonSprawl.Server/Game/Quests/QuestStateOperations.cs b/server/NeonSprawl.Server/Game/Quests/QuestStateOperations.cs index 658de66..4e46128 100644 --- a/server/NeonSprawl.Server/Game/Quests/QuestStateOperations.cs +++ b/server/NeonSprawl.Server/Game/Quests/QuestStateOperations.cs @@ -1,3 +1,4 @@ +using NeonSprawl.Server.Game.Factions; using NeonSprawl.Server.Game.Items; using NeonSprawl.Server.Game.Mastery; using NeonSprawl.Server.Game.Rewards; @@ -29,6 +30,7 @@ public static class QuestStateOperations PerkUnlockEngine perkUnlockEngine, IPlayerPerkStateStore perkStore, IRewardDeliveryStore deliveryStore, + IFactionStandingStore standingStore, TimeProvider timeProvider) { if (!questRegistry.TryNormalizeKnown(questId, out var normalizedQuestId) || @@ -61,6 +63,15 @@ public static class QuestStateOperations } } + var gate = FactionGateOperations.TryEvaluate( + playerId, + definition.FactionGateRules, + standingStore); + if (!gate.Success) + { + return DenyAccept(playerId, normalizedQuestId, QuestStateReasonCodes.FactionGateBlocked); + } + if (progressStore.TryActivate(playerId, normalizedQuestId, out var snapshot)) { // --- Telemetry hook site (NEO-121): future E9.M1 catalog event `quest_start` --- diff --git a/server/NeonSprawl.Server/Game/Quests/QuestStateReasonCodes.cs b/server/NeonSprawl.Server/Game/Quests/QuestStateReasonCodes.cs index 44eb53f..43fc59b 100644 --- a/server/NeonSprawl.Server/Game/Quests/QuestStateReasonCodes.cs +++ b/server/NeonSprawl.Server/Game/Quests/QuestStateReasonCodes.cs @@ -16,4 +16,6 @@ public static class QuestStateReasonCodes public const string NotActive = "not_active"; public const string InvalidStepIndex = "invalid_step_index"; + + public const string FactionGateBlocked = "faction_gate_blocked"; } diff --git a/server/README.md b/server/README.md index 1aedd94..6900738 100644 --- a/server/README.md +++ b/server/README.md @@ -96,6 +96,18 @@ Game code applies standing changes through **`ReputationOperations.TryApplyDelta Plan: [NEO-136 implementation plan](../../docs/plans/NEO-136-implementation-plan.md). +## FactionGateOperations (NEO-137) + +Quest accept evaluates **`FactionGateRule`** rows through **`FactionGateOperations.TryEvaluate`** before activation. Wired from **`QuestStateOperations.TryAccept`** after prerequisite checks and before **`TryActivate`**. + +**Semantics:** all rules must pass (AND). Empty rule list succeeds immediately. Each rule compares player standing from **`IFactionStandingStore.TryGetStanding`** against **`minStanding`** with **`standing >= minStanding`**. Unknown faction ids fail closed via the standing store boundary (startup catalog cross-ref prevents bad content at load). + +**Deny reason code:** **`faction_gate_blocked`** on **`QuestStateReasonCodes`** when any gate fails. Accept HTTP response returns **`accepted: false`** with that **`reasonCode`** (HTTP 200, same as other structured accept denies). + +**Prototype quest:** **`prototype_quest_grid_contract`** requires **`prototype_faction_grid_operators`** standing **≥ 15** after **`prototype_quest_operator_chain`** prerequisite is complete. Rep grants that reach +15 standing land in NEO-138; success Bruno smoke deferred until then. + +Plan: [NEO-137 implementation plan](../../docs/plans/NEO-137-implementation-plan.md). + ## Resource-node catalog (`content/resource-nodes`, NEO-58) On startup the host loads every **`*_resource_nodes.json`** and **`*_resource_yields.json`** under the resource-nodes directory, validates each row against **`content/schemas/resource-node-def.schema.json`** and **`resource-yield-row.schema.json`**, requires **`schemaVersion` 1** per file, rejects **duplicate `nodeDefId`** values across files, cross-checks yield **`itemId`** values against the **item catalog loaded first**, and enforces the **prototype Slice 2** roster gate (same rules as **`scripts/validate_content.py`**). If anything is missing or invalid, the process **exits during startup** with an actionable error—there is no silent fallback. @@ -281,14 +293,14 @@ Sample default response (no quests accepted): ### Quest accept POST (NEO-120) -**`POST /game/players/{id}/quests/{questId}/accept`** transitions **`not_started` → `active`** via **`QuestStateOperations.TryAccept`**. Unknown or blank player ids return **404** (position gate). Request body is optional v1 — omit body, send `{}`, or `{ "schemaVersion": 1 }`; **400** when body is present with `schemaVersion` other than **1** (unset `0` is treated as omitted). +**`POST /game/players/{id}/quests/{questId}/accept`** transitions **`not_started` → `active`** via **`QuestStateOperations.TryAccept`**. Unknown or blank player ids return **404** (position gate). Request body is optional v1 — omit body, send `{}`, or `{ "schemaVersion": 1 }`; **400** when body is present with `schemaVersion` other than **1** (unset `0` is treated as omitted). Faction-gated quests (NEO-137) deny with **`faction_gate_blocked`** when standing is below any **`FactionGateRule.minStanding`** after prerequisites pass. Response (`schemaVersion` **1**): **`accepted`** (`true`/`false`), optional **`reasonCode`** on deny, optional **`quest`** row (same shape as GET list entries). Structured denies return **HTTP 200** with **`accepted: false`** (inventory/craft precedent). Accept-time **`inventory_has_item`** wiring runs inside **`TryAccept`** (NEO-118). | Outcome | `accepted` | `reasonCode` | `quest` row | |---------|------------|--------------|-------------| | Success | `true` | omitted | active snapshot | -| Deny (no row) | `false` | e.g. `unknown_quest`, `prerequisite_incomplete` | omitted | +| Deny (no row) | `false` | e.g. `unknown_quest`, `prerequisite_incomplete`, `faction_gate_blocked` | omitted | | Deny (existing row) | `false` | e.g. `already_active`, `already_completed` | current snapshot | Plan: [NEO-120 implementation plan](../../docs/plans/NEO-120-implementation-plan.md); Bruno `bruno/neon-sprawl-server/quest-progress/` (accept spine).